Re: [PATCH v7 11/34] drm/atomic_sro: Create kernel parameter to force or disable readout

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/atomic_sro: missing kernel-parameters.txt entry for drm.atomic_readout
--

commit c7a4855501de73acc47469e5832c891678cde200
Author: Maxime Ripard <mripard@kernel.org>

drm/atomic_sro: Create kernel parameter to force or disable readout

This commit adds the atomic_readout module parameter to control hardware
state readout behavior and introduces drm_atomic_sro_device_can_readout()
to check whether readout is supported and enabled on a DRM device.

> diff --git a/drivers/gpu/drm/drm_atomic_state_readout.c b/drivers/gpu/drm/drm_atomic_state_readout.c
> index 2f8df00e993eb..e93b0e4f0839e 100644
> --- a/drivers/gpu/drm/drm_atomic_state_readout.c
> +++ b/drivers/gpu/drm/drm_atomic_state_readout.c
> @@ -14,6 +14,42 @@
>  #include "drm_internal.h"
>  #include "drm_crtc_internal.h"
>  
> +enum drm_atomic_readout_status {
> +	DRM_ATOMIC_READOUT_DISABLED = 0,
> +	DRM_ATOMIC_READOUT_ENABLED,
> +	DRM_ATOMIC_READOUT_SKIP_MISSING_COMPARE,
> +	DRM_ATOMIC_READOUT_SKIP_MISSING_READOUT,
> +};
> +
> +static unsigned int atomic_readout = DRM_ATOMIC_READOUT_ENABLED;
> +module_param_unsafe(atomic_readout, uint, 0400);
> +MODULE_PARM_DESC(atomic_readout,
> +		 "Enable Hardware State Readout (0 = disabled, 1 = enabled, 2 = ignore missing compares, 3 = ignore missing readouts and compares, default = 1)");

[Severity: Low]
Since drivers/gpu/drm/drm_atomic_state_readout.c is built into the drm
module whenever CONFIG_DRM is enabled, module_param_unsafe(atomic_readout,
...) exposes drm.atomic_readout on the kernel command line.

Should this new boot and module parameter also be documented in
Documentation/admin-guide/kernel-parameters.txt?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-drm-state-readout-v7-0-25e5163d75c3@kernel.org?part=11