From: sashiko-bot@kernel.org
To: "Lefteris Koutrakis" <lefteris.koutrakis@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] powerpc: dts: Add support for WatchGuard Firebox T30
Date: Thu, 29 Oct 2026 11:39:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-189204@kernel.org> (raw)
In-Reply-To: <20261029112742.10238-1-lefteris.koutrakis@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: vendor-prefixes: broken YAML and pattern for watchguard
--
commit 00a5866796adbcc672fe6cb4dfd1295ffc4e930c
Author: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>
powerpc: dts: Add support for WatchGuard Firebox T30
This commit adds initial device tree support for the WatchGuard Firebox T30
board, enables building firebox-t30.dtb under CONFIG_MPC85xx_RDB, and adds
the watchguard vendor prefix to vendor-prefixes.yaml.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index ba20029693734..73b6cdf72b8d9 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1995,3 +1995,5 @@ patternProperties:
> additionalProperties: false
>
> ...
> + "watchguard,":
> + description: WatchGuard Technologies, Inc.
[Severity: Low]
Does adding the watchguard prefix here break dt_binding_check and
dtbs_check?
In Documentation/devicetree/bindings/vendor-prefixes.yaml, this entry is
appended after additionalProperties: false and the ... YAML document-end
marker, which causes dt-doc-validate and dt-mk-schema to fail with a YAML
parser error.
Additionally, entries under patternProperties use anchored regular
expressions and are kept in alphabetical order:
"^waveshare,.*":
description: Waveshare Electronics
"^wd,.*":
description: Western Digital Corp.
Should this entry instead be placed alphabetically inside patternProperties
as "^watchguard,.*":?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029112742.10238-1-lefteris.koutrakis@gmail.com?part=1
next prev parent reply other threads:[~2026-10-29 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 11:27 [PATCH v2] powerpc: dts: Add support for WatchGuard Firebox T30 Lefteris Koutrakis
2026-10-29 11:39 ` sashiko-bot [this message]
2026-10-29 11:44 ` Krzysztof Kozlowski
2026-10-29 17:38 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189204@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lefteris.koutrakis@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.