Re: [PATCH RFC 8/9] fat: sync the inode in fat_free_eofblocks()

[sashiko-bot@kernel.org]

> fat_evict_inode() calls fat_free_eofblocks() for a linked inode to give
> back the clusters that were fallocated past the initialized size. For an
> empty file that also resets the start cluster in the directory entry. It
> truncates the clusters and writes the inode with:
> 
>   sync_inode_metadata(inode, inode_needs_sync(inode));
> 
> Unless the inode is IS_SYNC that is WB_SYNC_NONE writeback. It copies
> the inode into the directory entry buffer, marks the buffer dirty and
> sets I_METADATA_WRITEBACK. Then the inode goes away and with it the only
> thing that would have told a later fsync() that the directory entry
> still has to be written.
> 
> FAT doesn't have that problem. Its buffers are tracked on the FAT inode
> and fat_file_fsync() writes them out on every fsync() of any file on the
> [ ... ]
> there is to pass 1 for wait.
> 
> Fixes: b13bb33eacb7 ("fat: add fat_fallocate operation")
> Cc: stable@vger.kernel.org # v7.3
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-work-inode-metadata_writeback-v1-0-7d6c678a585d@kernel.org?part=8