Re: [PATCH v10 13/16] ARM: dts: aspeed: anacapa: Remove LTC4287 power monitors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ARM: dts: aspeed: anacapa: patch reverts nodes added earlier in same series
--

commit 03870aab7cb0f129ffba68f6d70cf51a5d0e4fd0
Author: Carl Lee <carl.lee@amd.com>

ARM: dts: aspeed: anacapa: Remove LTC4287 power monitors

This patch removes seven lltc,ltc4287 power-monitor nodes from the i2c@0 and
i2c@1 mux channels in aspeed-bmc-facebook-anacapa-evt2.dtsi to avoid I2C
address conflicts.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi
> index f546a7b5786a1..5c0d874fa24af 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi
> @@ -83,30 +83,6 @@ gpio@24 {
>  					"RPDB_FAN7_PRSNT_N_R", "RPDB_FAN8_PRSNT_N_R",
>  					"", "";
>  			};
> -
> -			power-monitor@42 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x42>;
> -				shunt-resistor-micro-ohms = <150>;
> -			};
> -
> -			power-monitor@43 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x43>;
> -				shunt-resistor-micro-ohms = <150>;
> -			};
> -
> -			power-monitor@44 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x44>;
> -				shunt-resistor-micro-ohms = <250>;
> -			};
> -
> -			power-monitor@45 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x45>;
> -				shunt-resistor-micro-ohms = <250>;
> -			};
>  		};
>  
>  		i2c@1 {
> @@ -177,24 +153,6 @@ gpio@24 {
>  					"","",
>  					"","";
>  			};
> -
> -			power-monitor@40 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x40>;
> -				shunt-resistor-micro-ohms = <150>;
> -			};
> -
> -			power-monitor@41 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x41>;
> -				shunt-resistor-micro-ohms = <150>;
> -			};
> -
> -			power-monitor@45 {
> -				compatible = "lltc,ltc4287";
> -				reg = <0x45>;
> -				shunt-resistor-micro-ohms = <250>;
> -			};
>  		};
>  	};
>  };

[Severity: Low]
Earlier in this same patch series, commit 366f7e6a0a5d ("ARM: dts: aspeed:
anacapa: evt2: Add shunt resistor values for HSC monitors") added these exact
power-monitor@42, power-monitor@43, power-monitor@44, and power-monitor@45
nodes under i2c@0, and power-monitor@40, power-monitor@41, and
power-monitor@45 under i2c@1 in
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dtsi.

This patch then deletes those same 42 lines because the nodes conflict with
other I2C addresses on those buses, leaving intermediate commits in the series
with known I2C address conflicts during bisection.

Could both patches be dropped from the series, or squashed together, rather
than adding broken nodes in one patch and reverting them five patches later?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-anacapa-devlop-phase-devicetree-v10-0-26ee3cf9d9d0@gmail.com?part=13