Re: [PATCH RESEND rdma-next 2/2] RDMA/irdma: Do not change mr->pd in driver during rereg_mr

[sashiko-bot@kernel.org]

> Previously, IB_MR_REREG_PD would cause the driver to set
> iwmr->ibmr.pd to the new PD before reregistering with HW because
> irdma_hwreg_mr() retrieves the PD from there.
> 
> ib_uverbs_rereg_mr() only moves the PD usecnt from the old PD to
> the new one and updates mr->pd itself after the driver's
> rereg_user_mr() call succeeds.
> 
> So, if the rereg_user_mr() call fails, the MR is left pointing at
> a PD that does not account for it while the old PD keeps the reference,
> which means the old PD can never be deallocated, while the new PD can
> be deallocated even though the MR still points at it.
> 
> Fix this by removing the PD update from the driver and just letting
> the core handle it. This required plumbing the PD as an argument
> through a few functions. This works because the core passes the
> PD unconditionally and provides the current PD if IB_MR_REREG_PD is
> not set.
> 
> Fixes: 5ac388db27c4 ("RDMA/irdma: Add support to re-register a memory region")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029141849.1575012-1-jmoroni@google.com?part=2