Re: [PATCH v9 4/4] watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] watchdog: aaeon: missing kernel-parameters.txt entry for timeout param
--

commit 56cdb5c8b2505a3a5bbfb7ace81364353e737628
Author: Thomas Perrot (Schneider Electric) <thomas.perrot@bootlin.com>

watchdog: aaeon: Add watchdog driver for SRG-IMX8P MCU

This commit adds a watchdog driver for the Aaeon SRG-IMX8P onboard
microcontroller, supporting configurable software timeouts via ioctl,
Device Tree, or a module parameter.

[ ... ]

> diff --git a/drivers/watchdog/aaeon_mcu_wdt.c b/drivers/watchdog/aaeon_mcu_wdt.c
> new file mode 100644
> index 0000000000000..beded3d6326fd
> --- /dev/null
> +++ b/drivers/watchdog/aaeon_mcu_wdt.c
> @@ -0,0 +1,171 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Aaeon MCU Watchdog driver
> + *
> + * Copyright (C) 2026 Bootlin
> + * Author: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com>
> + * Author: Thomas Perrot <thomas.perrot@bootlin.com>
> + */
> +
> +#include <linux/mfd/aaeon-mcu.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/watchdog.h>
> +
> +#define AAEON_MCU_PING_WDT		0x73
> +
> +#define AAEON_MCU_WDT_TIMEOUT		240
> +#define AAEON_MCU_WDT_HEARTBEAT_MS	25000
> +/* The MCU cannot expire earlier than its fixed heartbeat. */
> +#define AAEON_MCU_WDT_MIN_TIMEOUT	(AAEON_MCU_WDT_HEARTBEAT_MS / 1000)
> +
> +static unsigned int timeout;
> +module_param(timeout, uint, 0);
> +MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds");

[Severity: Low]
Should this new timeout module parameter (accessible on the kernel command
line as aaeon_mcu_wdt.timeout) also be documented in
Documentation/admin-guide/kernel-parameters.txt?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-dev-b4-aaeon-mcu-driver-v9-0-f9b6d0cc180d@bootlin.com?part=4