From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59068606A31A for ; Fri, 30 Oct 2026 03:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PW1FSVkc; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VoAc007W DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=lcKj7csra/+fxwpQDOY/I1A64qlP2hryko1b/12CUcU=; b=PW1FSVkc/X/4IKGX1lWv82P7ca gvtn6iuNl20aaQIanjO0Qd7Of86KoKwpVXoYOI6aoKYjOFn/klvXGWDZJEsHYLAqkgGmwOUozncPY nbCV8WLdARQewY238M7U56/Q2M4ROmDReAHOxrgR8xkfFSlgPZ3XlEqU0pVWhCsoq4KO/+jMC6/iw o6BPm7H5XUkTLp9x/ZWPGFHq3g++db5OH+WPoEVkGLHq39ajtvSUo39Sxs1xg/yhxn+JIU+dnIjNb iNDYnMKifHmnKY3qYqG1yNiDRYfoqi6UKHoH5lkUsXKV/nRm72rbXBhgOpcWt7xDWSmbKUF5am4bH LRv7Ccvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdTt-0000000Ajvn-0Eub; Fri, 30 Oct 2026 03:40:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdTr-0000000Ajuv-1fSk for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:40:39 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 29285409A4; Fri, 30 Oct 2026 03:40:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96F3B1F000C1; Fri, 30 Oct 2026 03:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331639; bh=lcKj7csra/+fxwpQDOY/I1A64qlP2hryko1b/12CUcU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VoAc007W0oSPPCat2Lfr0FWDBkot2j9byg/06oA8YgtEr8fH0b2BZjHE4xteI3wYy 1/v/t9qBhqhuCPjCbP9Y+MvswjdwFbhE2aKcHwkMQP/3BSqyzn4aonNhoaG4kQCaOI rwT/eeMbWSaV5mJcd1gKSQsp/rd4z9CDUUDRpo9Bn8tHYTXz3reMJ8lXxnf+rH3V3N D1+BdT6Zohj18HW0bYjbarW+cm/ng7MIsF1zKtonq74df3P3Gq5W/4n2CS3H5cIgRd DoMEHFvj+M4qRjg72povEAW5URtQhRwxkHJ+01msOwtjkOHCkRXhGyM2UyGCR6+2XC +P/sOS0TxEsGw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 09/47] mm/rmap: handle device-exclusive entries in folio_referenced_one() To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261029-fixes_core-v2-9-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-9-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:40:36 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > page_vma_mapped_walk() can return non-present device-exclusive entries, > but folio_referenced_one() passes them to PTE young-bit accessors that > require present PTEs. >=20 > We must neither call clear_flush_young_ptes_notify() nor > folio_pte_batch() with non-present entries. For example, clearing the > young bit on non-present PTEs can corrupt the entry: on arm64 > PTE_AF overlaps the swap type, so clearing it turns a device-exclusive > entry into an ordinary swap entry. >=20 > folio_pte_batch() will VM_WARN_ON_FOLIO. >=20 > Apply the same approach as the previous fixes to e.g., damon_ptep_mkold(): > treat these entries as old from the CPU's perspective and obtain their > young state through the MMU notifier. >=20 > Skip PTE batching and MGLRU look-around for non-present entries, and > don't modify non-present PTEs. >=20 > Fixes: b756a3b5e7ea ("mm: device exclusive memory access") > Reviewed-by: Lorenzo Stoakes (ARM) > Cc: stable@vger.kernel.org > Reported-by: Josef Bacik > Reviewed-by: Harry Yoo (Meta) > Reviewed-by: Barry Song > Reviewed-by: Dev Jain > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D9