From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16453606A31A for ; Fri, 30 Oct 2026 03:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ut5i85XC; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WjrSZjUw DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=g0txQIdNUS00TTCoh9m0KFKNs8md1S+caUoT+80en9E=; b=Ut5i85XC99GhBaotU9xVp4B2py Hr+1C9Tq5TXm0kB57h2XNhgi9857vgGLGdqtQCnoXq4DqrXHK1kmjgJb8YFYLpZo0d+vzf6h0uzTx IhwstsxWxnTeHdvVZVfYvjLuBdwaNoViQ64oGvj1Hu52vO+kQW88edE/ouSJy7R3oGUU7Jk+LS/jx g6nuCgoAsdwuREkhNvmpdv401DUCFGoZIkIWPt0uPqvBK818pt355hvfawbGvUgDH3F7hWW5Bd03v h1Mq/g0NUtR3cEbLNWHg99xfJIiKNWVBn8n/1g4u7xqPQnbEr0gqDblSsjWTNrht+v8ZUlvOFXk/7 2Ilp83ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdUI-0000000AkEe-3Df5; Fri, 30 Oct 2026 03:41:06 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMdUG-0000000AkDt-3nsu for kexec@lists.infradead.org; Fri, 30 Oct 2026 03:41:04 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 96C8043C46; Fri, 30 Oct 2026 03:41:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BDF1F000C1; Fri, 30 Oct 2026 03:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793331664; bh=g0txQIdNUS00TTCoh9m0KFKNs8md1S+caUoT+80en9E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=WjrSZjUwhyt/+8z5+6OAtW7j2PEsyy4MlaO/CaXntRYBPTnBuExfUCFYvnfb20AV6 iCkeTPTd5dzMNisMgDmfCwNhXIy1dYdfv2jGWLikD8N4xKEmZCdO+jC7igj9Wrr6I7 T+deJRHsQUfEyhypZIUWDBo73GK0YUZR8ojVvO7NdFIsuhEuTKu8Rzeq2fzk8z9l6q LE7sCfOn/k+7jUZ8/he4rgf+MGFjaImCyHDwfMysdcA9eGSKsq95SJybDT50Xyo7Oj j1RQA5Bv32qtfXJ1En9O1kjAkEY1kWUQng2aEf2zu+L/uyxrTQzX+gSBt6fuL+gg95 JDwI/KagwaTiA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 16/47] mm/khugepaged: fix PMD table lock leak in try_collapse_pte_mapped_thp() To: =?utf-8?b?RGF2aWQgSGlsZGVuYnJhbmQgKEFybSk=?= , "Andrew Morton" , "Johannes Weiner" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Kairui Song" , "Barry Song" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "Baoquan He" , "Baolin Wang" , "Liam R. Howlett" , "Vlastimil Babka" , "Mike Rapoport" , "Suren Baghdasaryan" , "Michal Hocko" , "Kees Cook" , "Peter Zijlstra" , "Jann Horn" , "Pedro Falcato" , "Hugh Dickins" , "Pasha Tatashin" , "Pratyush Yadav" , =?utf-8?b?TWF0dGhldyBXaWxjb3ggKE9yYWNsZSk=?= , "Jan Kara" , "Zi Yan" , "Lance Yang" , "Rik van Riel" , "Harry Yoo" , "Alistair Popple" , "Nico Pache" , "Ryan Roberts" , "Dev Jain" , "Usama Arif" , "Kiryl Shutsemau" , "Matthew Brost" , "John Hubbard" , "Peter Xu" , "Will Deacon" , "Aneesh Kumar K.V" , "Nick Piggin" , "Oscar Salvador" , "Minchan Kim" , "Muchun Song" , "Xu Xin" , "Chengming Zhou" , "Chris Li" , "Kemeng Shi" , "Nhat Pham" , "Youngjun Park" , "Gregory Price" , "Joshua Hahn" , "Rakie Kim" , "Ying Huang" , "Jason Gunthorpe" Cc: kexec@lists.infradead.org, "Josef Bacik" In-Reply-To: <20261029-fixes_core-v2-16-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> <20261029-fixes_core-v2-16-a64ce7f83abb@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 03:41:01 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > From: Josef Bacik >=20 > For a private mapping with userfaultfd, try_collapse_pte_mapped_thp() > takes the PMD table lock before it maps the page table for the second tim= e. > If that (pte_offset_map_rw_nolock) fails, because the page table vanished > in the meantime due to concurrent page table reclaim, it leaves through > the abort label, where the PMD table lock is unlocked if it differs from > PTE table lock. >=20 > In case the PMD table lock and the PTE table lock match, which is the > case without CONFIG_SPLIT_PTE_PTLOCKS after pte_offset_map_rw_nolock() > failed, we miss to unlock the PMD table. >=20 > To fix it, forget the PTE table lock when we unmap+unlock the PTE table. >=20 > Fix generated by an LLM and sent by Josef Bacik in private. >=20 > Fixes: 6375e95f381e ("mm: pgtable: reclaim empty PTE page in madvise(MADV= _DONTNEED)") > Cc: stable@vger.kernel.org > Signed-off-by: Josef Bacik > [ david: move the ptl =3D NULL handling; rewrite description, drop wrong = comments ] > Reviewed-by: Gregory Price (Meta) > Tested-by: Gregory Price (Meta) > Signed-off-by: David Hildenbrand (Arm) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-fixes_core= -v2-0-a64ce7f83abb@kernel.org?part=3D16