Re: [PATCH net-next V2 2/3] net/mlx5: E-Switch, introduce generic work queue dispatch helper

[sashiko-bot@kernel.org]

> From: Mark Bloch <mbloch@nvidia.com>
> 
> Each E-Switch work item requires the same boilerplate: acquire the
> devlink lock, check whether the work is stale, dispatch to the
> appropriate handler, and release the lock. Factor this out.
> 
> Add a func callback to mlx5_host_work so the generic handler
> esw_wq_handler() can dispatch to the right function without
> duplicating locking logic. Introduce mlx5_esw_add_work() as the
> single enqueue point: it stamps the work item with the current
> generation counter and queues it onto the E-Switch work queue.
> 
> Refactor esw_vfs_changed_event_handler() to match the new contract:
> it no longer receives work_gen or out as parameters. It queries
> mlx5_esw_query_functions() itself and owns the kvfree() of the
> result. The devlink lock is acquired and released by esw_wq_handler()
> before dispatching, so the handler runs with the lock already held.
> 
> Update mlx5_esw_funcs_changed_handler() to use mlx5_esw_add_work().
> 
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260428051018.219093-1-tariqt@nvidia.com?part=2