All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ratheesh Kannoth" <rkannoth@marvell.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v12 net-next 2/9] net/mlx5e: trim stack use in PCIe congestion threshold helper
Date: Fri, 30 Oct 2026 04:54:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-190397@kernel.org> (raw)
In-Reply-To: <20260508034912.4082520-3-rkannoth@marvell.com>

> union devlink_param_value grew when U64 array parameters were added.
> Keeping a four-element array of that union in
> mlx5e_pcie_cong_get_thresh_config() inflated the stack frame past the
> -Wframe-larger-than limit.
> 
> Read each driverinit value into a single reused union, then store the
> four u16 thresholds in struct mlx5e_pcie_cong_thresh field order via a
> temporary u16 pointer to config.
> 
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508034912.4082520-1-rkannoth@marvell.com?part=2


  parent reply	other threads:[~2026-10-30  4:54 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  3:49 [Intel-wired-lan] [PATCH v12 net-next 0/9] octeontx2-af: npc: Enhancements Ratheesh Kannoth
2026-05-08  3:49 ` Ratheesh Kannoth
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 1/9] octeontx2-af: npc: cn20k: debugfs enhancements Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  2:25   ` Ratheesh Kannoth
2026-05-11  2:25     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 2/9] net/mlx5e: trim stack use in PCIe congestion threshold helper Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-08  9:02   ` [Intel-wired-lan] " David Laight
2026-05-08  9:02     ` David Laight
2026-10-30  4:54   ` sashiko-bot [this message]
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 3/9] devlink: pass param values by pointer Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11 13:39   ` Przemek Kitszel
2026-05-11 13:39     ` [Intel-wired-lan] " Przemek Kitszel
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 4/9] devlink: Implement devlink param multi attribute nested data values Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  2:31   ` Ratheesh Kannoth
2026-05-11  2:31     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 5/9] octeontx2-af: npc: cn20k: add subbank search order control Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  2:32   ` Ratheesh Kannoth
2026-05-11  2:32     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 6/9] octeontx2: cn20k: Coordinate default rules with NIX LF lifecycle Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  2:44   ` Ratheesh Kannoth
2026-05-11  2:44     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 7/9] octeontx2-af: npc: Support for custom KPU profile from filesystem Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  3:23   ` Ratheesh Kannoth
2026-05-11  3:23     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-05-11  3:27   ` Ratheesh Kannoth
2026-05-11  3:27     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-05-11 11:55   ` Loktionov, Aleksandr
2026-05-11 11:55     ` Loktionov, Aleksandr
2026-05-12  2:11     ` Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 8/9] octeontx2: cn20k: Respect NPC MCAM X2/X4 profile in flows and DFT alloc Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  3:25   ` Ratheesh Kannoth
2026-05-11  3:25     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot
2026-05-08  3:49 ` [Intel-wired-lan] [PATCH v12 net-next 9/9] octeontx2-af: npc: cn20k: Allocate npc_priv and dstats dynamically Ratheesh Kannoth
2026-05-08  3:49   ` Ratheesh Kannoth
2026-05-11  3:26   ` Ratheesh Kannoth
2026-05-11  3:26     ` [Intel-wired-lan] " Ratheesh Kannoth
2026-10-30  4:54   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-190397@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rkannoth@marvell.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.