Re: [PATCH net-next v6 01/12] dt-bindings: net: airoha: Add EN7581 ethernet-ports properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incomplete schema constraint allows `#address-cells` and `#size-cells` on unsupported GDM1 and GDM2 ports.
- [Low] Schema validation failure for `ethernet-port@[0-5]$` child nodes due to `$nodename` mismatch.
--

commit ec4617f6004fa83e07ac8747b6e514e55a246569
Author: Lorenzo Bianconi <lorenzo@kernel.org>

dt-bindings: net: airoha: Add EN7581 ethernet-ports properties

This commit adds support for connecting multiple external SerDes to GDM3
or GDM4 ports via an arbiter for EN7581 and AN7583 SoCs. It introduces
the ethernet-port property to model net_devices connected to these GDM
ports.

> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> index fbe2ddcdd909c..642f300c09450 100644
> --- a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> @@ -130,6 +130,50 @@ patternProperties:
>          maximum: 4
>          description: GMAC port identifier
>  
> +      '#address-cells':
> +        const: 1
> +      '#size-cells':
> +        const: 0
> +

Does defining these properties in the main block inadvertently allow them on
GDM1 and GDM2?

The commit message notes that ports 1 and 2 do not support the connection
with the external arbiter, but placing them in this outer block makes them
permissible for all ports rather than just GDM3 and GDM4.

[ ... ]

> +          patternProperties:
> +            "^ethernet-port@[0-5]$":
> +              type: object
> +              unevaluatedProperties: false
> +              $ref: ethernet-controller.yaml#

Will this fail schema validation during make dt_binding_check?

The core ethernet-controller.yaml schema enforces a nodename regular
expression of ^ethernet(@.*)?$, which does not appear to match the
ethernet-port@X pattern used here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260511-airoha-eth-multi-serdes-v6-0-c899462c4f75@kernel.org?part=1