Re: [PATCH 08/13 RFC net-next] net: ping: split IPv4 specific logic into ping_ipv4.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately states that error handling functions were moved to the new file, but `ping_err()` remains in `ping.c`.
--

--- Patch [8]: [PATCH 08/13 RFC net-next] net: ping: split IPv4 specific logic into ping_ipv4.c ---
commit 3efab348e36b9a0fdec89cd6eb3bf8beee163acf
Author: Fernando Fernandez Mancera <fmancera@suse.de>

net: ping: split IPv4 specific logic into ping_ipv4.c

This commit isolates IPv4-specific ping functions into a new file,
ping_ipv4.c, to allow compiling the INET subsystem without IPv4.
It moves packet transmission routines and modifies ping.c to use
CONFIG_IPV4 guards for the remaining shared logic.

> This patch creates ping_ipv4.c and move all the functions for packet
> transmission, error handling and the AF_INET ping_prot definition from
> ping.c to the new file.

[Severity: Medium]
Is this description accurate regarding the error handling functions?

Looking at the patch, the ICMP error handling function ping_err() was not
moved to ping_ipv4.c. Instead, it was left in net/ipv4/ping.c and modified
in-place with IS_ENABLED(CONFIG_IPV4) guards because it also serves as the
error entry point for IPv6.

Could the commit message be updated to clarify that ping_err() remains in
the generic ping.c file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712013941.4570-1-fmancera@suse.de?part=8