From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFFA8606A32A for ; Fri, 30 Oct 2026 07:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dSoY2mcq Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2101B10E849; Fri, 30 Oct 2026 07:04:39 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B76D10E849 for ; Fri, 30 Oct 2026 07:04:33 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C8B4F42E63; Fri, 30 Oct 2026 07:04:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A94C1F000C1; Fri, 30 Oct 2026 07:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793343872; bh=AQViuW8zNNdDAkH107WPOx22iLQNlN+ChjPHckc5kic=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dSoY2mcqvqDL58RwSOhHCB5YpG++Rnuw+wuGxJW6GLLCmp+zxBEIkUeSBCfXXFTwF i9yXIVDIipmzmiA2xPVuXOu0BBY4CBlA2jJ147qUO33Yr//TeyteBZ9jyZGQGFWV9Y LoyH8uKCmLE7fKfC6z5d2sw9lmh+Pl7/r9hvspPWUA1pz/ELJ5OX0KrudtgH7lkUkP F6xYUH0o0G0oXyGe+cFf56/Jfq1i3XjfL1bKtIrUNfbNkaO5XsgxgNtfwxV/woZUkk TjJdk3Hc0zIF2ktnzbb8DGdi6IBxITdyLdiSSKbj08c6iW6O47y8cksTbLM8LkXTH4 6NVDprYg2LTRg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 6/6] arm64: dts: rockchip: rk356x: Add eDP controller and phy nodes To: "Damon Ding" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261030064905.2248999-7-damon.ding@rock-chips.com> References: <20261030064905.2248999-1-damon.ding@rock-chips.com> <20261030064905.2248999-7-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 07:04:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "dri-devel" X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] arm64: dts: rockchip: rk356x: PCLK_EDPPHY_GRF never enabled for ed= p_phy -- commit 4fc93be7caab95400abe782b268ff22b9c12b905 Author: Damon Ding arm64: dts: rockchip: rk356x: Add eDP controller and phy nodes This commit adds the eDP PHY GRF syscon node, its child eDP PHY node, and the eDP controller node to the RK3566/RK3568 base device tree. > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/b= oot/dts/rockchip/rk356x-base.dtsi > index a5832895bd392..7a5168548e55a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > @@ -403,6 +403,24 @@ usb2phy1_grf: syscon@fdca8000 { > reg =3D <0x0 0xfdca8000 0x0 0x8000>; > }; > =20 > + edp_phy_grf: syscon@fdcb0000 { > + compatible =3D "rockchip,rk3568-edp-phy-grf", "syscon", "simple-mfd"; > + reg =3D <0x0 0xfdcb0000 0x0 0x8000>; > + clocks =3D <&cru PCLK_EDPPHY_GRF>; > + ranges =3D <0x0 0x0 0xfdcb0000 0x100>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + edp_phy: phy@0 { > + compatible =3D "rockchip,rk3568-edp-phy"; > + reg =3D <0x0 0x100>; > + clocks =3D <&pmucru XIN_OSC0_EDPPHY_G>; > + clock-names =3D "refclk"; > + #phy-cells =3D <0>; > + status =3D "disabled"; > + }; > + }; [Severity: High] With PCLK_EDPPHY_GRF placed on the parent edp_phy_grf node while edp_phy ma= ps its register window directly, will PCLK_EDPPHY_GRF ever get enabled before the PHY driver accesses the registers at 0xfdcb0000? In drivers/phy/rockchip/phy-rockchip-naneng-edp.c, rockchip_edp_phy_probe() maps the child reg window directly and creates its own MMIO regmap rather than looking up the parent syscon regmap, and only gets refclk: drivers/phy/rockchip/phy-rockchip-naneng-edp.c:rockchip_edp_phy_probe() { ... regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(regs)) return PTR_ERR(regs); edpphy->regmap =3D devm_regmap_init_mmio(dev, regs, &rockchip_edp_phy_regm= ap_config); if (IS_ERR(edpphy->regmap)) return dev_err_probe(dev, PTR_ERR(edpphy->regmap), "Failed to init regmap\n"); edpphy->refclk =3D devm_clk_get(dev, "refclk"); ... } Because no consumer calls syscon_node_to_regmap() on edp_phy_grf (and even = if one did, syscon only attaches the clock to its own regmap), and simple-pm-b= us treats simple-mfd as ONLY_BUS without managing its clocks, nothing claims or enables PCLK_EDPPHY_GRF. In drivers/clk/rockchip/clk-rk3568.c, PCLK_EDPPHY_GRF is a gated clock that is not marked critical: GATE(PCLK_EDPPHY_GRF, "pclk_edpphy_grf", "pclk_top", 0, RK3568_CLKGATE_CON(34), 14, GFLAGS), Wouldn't clk_disable_unused() gate PCLK_EDPPHY_GRF off, causing unclocked MMIO accesses in rockchip_edp_phy_configure() and rockchip_edp_phy_power_on= () when an RK3566/RK3568 board enables edp and edp_phy? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261030064905.2248= 999-1-damon.ding@rock-chips.com?part=3D6 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBA1606A31C for ; Fri, 30 Oct 2026 07:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ta+UjCX3; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dSoY2mcq DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=VLcTlngyiCMPkILoMemMHIoOyoBzubKObv39oNVn09o=; b=Ta+UjCX3yxtlrO46j9FB0x+f99 J93gEC8NTo3C0sJ/bZuz4O/JyurL5QWVOdy6iIq/UeRLcmtDWvhcjngSqVa/uZ8lLNPvw+SLYg9GN CY5odZk/GYTTnLPQ8g2MHY+7PHek03cAZzbwbwtMRXMDeLoz5wCbJRQR6+ZGK4y1T4pDjE9nWhfTX 9uXIDmyEdy1gcY3EM8GuWxx3bzqzJ93cNLKOW9iZqVHBzDHDOGBeHYA/ew0UmoifKGm1GRb1mIpem aT6/OkXMAvqlvkRZw+RYyxE0ZaRI76+kkxX9L4uLI8ZIddLPfYMZJoHM0Uq0Qw4baEh4APi8Dz+Dm tNR8LIfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMgfC-0000000Ay9r-07LR; Fri, 30 Oct 2026 07:04:34 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMgfB-0000000Ay9l-2YG9 for linux-phy@lists.infradead.org; Fri, 30 Oct 2026 07:04:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C8B4F42E63; Fri, 30 Oct 2026 07:04:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A94C1F000C1; Fri, 30 Oct 2026 07:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793343872; bh=AQViuW8zNNdDAkH107WPOx22iLQNlN+ChjPHckc5kic=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dSoY2mcqvqDL58RwSOhHCB5YpG++Rnuw+wuGxJW6GLLCmp+zxBEIkUeSBCfXXFTwF i9yXIVDIipmzmiA2xPVuXOu0BBY4CBlA2jJ147qUO33Yr//TeyteBZ9jyZGQGFWV9Y LoyH8uKCmLE7fKfC6z5d2sw9lmh+Pl7/r9hvspPWUA1pz/ELJ5OX0KrudtgH7lkUkP F6xYUH0o0G0oXyGe+cFf56/Jfq1i3XjfL1bKtIrUNfbNkaO5XsgxgNtfwxV/woZUkk TjJdk3Hc0zIF2ktnzbb8DGdi6IBxITdyLdiSSKbj08c6iW6O47y8cksTbLM8LkXTH4 6NVDprYg2LTRg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 6/6] arm64: dts: rockchip: rk356x: Add eDP controller and phy nodes To: "Damon Ding" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261030064905.2248999-7-damon.ding@rock-chips.com> References: <20261030064905.2248999-1-damon.ding@rock-chips.com> <20261030064905.2248999-7-damon.ding@rock-chips.com> Date: Fri, 30 Oct 2026 07:04:31 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGFybTY0OiBkdHM6IHJv Y2tjaGlwOiByazM1Nng6IFBDTEtfRURQUEhZX0dSRiBuZXZlciBlbmFibGVkIGZvciBlZHBfcGh5 Ci0tCgpjb21taXQgNGZjOTNiZTdjYWFiOTU0MDBhYmU3ODJiMjY4ZmYyMmI5YzEyYjkwNQpBdXRo b3I6IERhbW9uIERpbmcgPGRhbW9uLmRpbmdAcm9jay1jaGlwcy5jb20+Cgphcm02NDogZHRzOiBy b2NrY2hpcDogcmszNTZ4OiBBZGQgZURQIGNvbnRyb2xsZXIgYW5kIHBoeSBub2RlcwoKVGhpcyBj b21taXQgYWRkcyB0aGUgZURQIFBIWSBHUkYgc3lzY29uIG5vZGUsIGl0cyBjaGlsZCBlRFAgUEhZ IG5vZGUsIGFuZAp0aGUgZURQIGNvbnRyb2xsZXIgbm9kZSB0byB0aGUgUkszNTY2L1JLMzU2OCBi YXNlIGRldmljZSB0cmVlLgoKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazM1NngtYmFzZS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1 NngtYmFzZS5kdHNpCj4gaW5kZXggYTU4MzI4OTViZDM5Mi4uN2E1MTY4NTQ4ZTU1YSAxMDA2NDQK PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2eC1iYXNlLmR0c2kKPiAr KysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2eC1iYXNlLmR0c2kKPiBAQCAt NDAzLDYgKzQwMywyNCBAQCB1c2IycGh5MV9ncmY6IHN5c2NvbkBmZGNhODAwMCB7Cj4gIAkJcmVn ID0gPDB4MCAweGZkY2E4MDAwIDB4MCAweDgwMDA+Owo+ICAJfTsKPiAgCj4gKwllZHBfcGh5X2dy Zjogc3lzY29uQGZkY2IwMDAwIHsKPiArCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzU2OC1l ZHAtcGh5LWdyZiIsICJzeXNjb24iLCAic2ltcGxlLW1mZCI7Cj4gKwkJcmVnID0gPDB4MCAweGZk Y2IwMDAwIDB4MCAweDgwMDA+Owo+ICsJCWNsb2NrcyA9IDwmY3J1IFBDTEtfRURQUEhZX0dSRj47 Cj4gKwkJcmFuZ2VzID0gPDB4MCAweDAgMHhmZGNiMDAwMCAweDEwMD47Cj4gKwkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47Cj4gKwkJI3NpemUtY2VsbHMgPSA8MT47Cj4gKwo+ICsJCWVkcF9waHk6IHBo eUAwIHsKPiArCQkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazM1NjgtZWRwLXBoeSI7Cj4gKwkJ CXJlZyA9IDwweDAgMHgxMDA+Owo+ICsJCQljbG9ja3MgPSA8JnBtdWNydSBYSU5fT1NDMF9FRFBQ SFlfRz47Cj4gKwkJCWNsb2NrLW5hbWVzID0gInJlZmNsayI7Cj4gKwkJCSNwaHktY2VsbHMgPSA8 MD47Cj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gKwkJfTsKPiArCX07CgpbU2V2ZXJpdHk6 IEhpZ2hdCldpdGggUENMS19FRFBQSFlfR1JGIHBsYWNlZCBvbiB0aGUgcGFyZW50IGVkcF9waHlf Z3JmIG5vZGUgd2hpbGUgZWRwX3BoeSBtYXBzCml0cyByZWdpc3RlciB3aW5kb3cgZGlyZWN0bHks IHdpbGwgUENMS19FRFBQSFlfR1JGIGV2ZXIgZ2V0IGVuYWJsZWQgYmVmb3JlCnRoZSBQSFkgZHJp dmVyIGFjY2Vzc2VzIHRoZSByZWdpc3RlcnMgYXQgMHhmZGNiMDAwMD8KCkluIGRyaXZlcnMvcGh5 L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1uYW5lbmctZWRwLmMsIHJvY2tjaGlwX2VkcF9waHlfcHJv YmUoKQptYXBzIHRoZSBjaGlsZCByZWcgd2luZG93IGRpcmVjdGx5IGFuZCBjcmVhdGVzIGl0cyBv d24gTU1JTyByZWdtYXAgcmF0aGVyCnRoYW4gbG9va2luZyB1cCB0aGUgcGFyZW50IHN5c2NvbiBy ZWdtYXAsIGFuZCBvbmx5IGdldHMgcmVmY2xrOgoKZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLW5hbmVuZy1lZHAuYzpyb2NrY2hpcF9lZHBfcGh5X3Byb2JlKCkgewoJLi4uCglyZWdz ID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApOwoJaWYgKElTX0VSUihy ZWdzKSkKCQlyZXR1cm4gUFRSX0VSUihyZWdzKTsKCgllZHBwaHktPnJlZ21hcCA9IGRldm1fcmVn bWFwX2luaXRfbW1pbyhkZXYsIHJlZ3MsICZyb2NrY2hpcF9lZHBfcGh5X3JlZ21hcF9jb25maWcp OwoJaWYgKElTX0VSUihlZHBwaHktPnJlZ21hcCkpCgkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2 LCBQVFJfRVJSKGVkcHBoeS0+cmVnbWFwKSwKCQkJCSAgICAgIkZhaWxlZCB0byBpbml0IHJlZ21h cFxuIik7CgoJZWRwcGh5LT5yZWZjbGsgPSBkZXZtX2Nsa19nZXQoZGV2LCAicmVmY2xrIik7Cgku Li4KfQoKQmVjYXVzZSBubyBjb25zdW1lciBjYWxscyBzeXNjb25fbm9kZV90b19yZWdtYXAoKSBv biBlZHBfcGh5X2dyZiAoYW5kIGV2ZW4gaWYKb25lIGRpZCwgc3lzY29uIG9ubHkgYXR0YWNoZXMg dGhlIGNsb2NrIHRvIGl0cyBvd24gcmVnbWFwKSwgYW5kIHNpbXBsZS1wbS1idXMKdHJlYXRzIHNp bXBsZS1tZmQgYXMgT05MWV9CVVMgd2l0aG91dCBtYW5hZ2luZyBpdHMgY2xvY2tzLCBub3RoaW5n IGNsYWltcyBvcgplbmFibGVzIFBDTEtfRURQUEhZX0dSRi4KCkluIGRyaXZlcnMvY2xrL3JvY2tj aGlwL2Nsay1yazM1NjguYywgUENMS19FRFBQSFlfR1JGIGlzIGEgZ2F0ZWQgY2xvY2sgdGhhdApp cyBub3QgbWFya2VkIGNyaXRpY2FsOgoKCUdBVEUoUENMS19FRFBQSFlfR1JGLCAicGNsa19lZHBw aHlfZ3JmIiwgInBjbGtfdG9wIiwgMCwKCQkJUkszNTY4X0NMS0dBVEVfQ09OKDM0KSwgMTQsIEdG TEFHUyksCgpXb3VsZG4ndCBjbGtfZGlzYWJsZV91bnVzZWQoKSBnYXRlIFBDTEtfRURQUEhZX0dS RiBvZmYsIGNhdXNpbmcgdW5jbG9ja2VkCk1NSU8gYWNjZXNzZXMgaW4gcm9ja2NoaXBfZWRwX3Bo eV9jb25maWd1cmUoKSBhbmQgcm9ja2NoaXBfZWRwX3BoeV9wb3dlcl9vbigpCndoZW4gYW4gUksz NTY2L1JLMzU2OCBib2FyZCBlbmFibGVzIGVkcCBhbmQgZWRwX3BoeT8KCi0tIApTYXNoaWtvIEFJ IHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEwMzAwNjQ5MDUu MjI0ODk5OS0xLWRhbW9uLmRpbmdAcm9jay1jaGlwcy5jb20/cGFydD02CgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK