All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Abhijit Gangurde" <abhijit.gangurde@amd.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [for-next 1/1] RDMA/ionic: Use a linear QID space when udma_shift is zero
Date: Fri, 30 Oct 2026 08:29:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-190690@kernel.org> (raw)
In-Reply-To: <20261030082402.841751-1-abhijit.gangurde@amd.com>

> Firmware reports udma_shift as the log2 of the number of queues in
> a queue group. A value of zero means the queues are not striped
> across two UDMAs, so the QID space is linear and the device has one UDMA.
> 
> The interleaved bitid/qid transform treats bit 0 as the UDMA selector
> when the group shift is zero. QID 1 then becomes bitid
> 1 << half_qid_shift, and freeing that QID releases the wrong allocator
> index. Skip the transform and select one UDMA so QP and CQ allocation
> uses the QID directly.
> 
> Fixes: e8521822c733 ("RDMA/ionic: Register device ops for control path")
> Reported-by: Keith Lucas <keith.lucas@oracle.com>
> Link: https://lore.kernel.org/r/20261021161651.4020222-1-haakon.bugge@oracle.com
> Cc: stable@vger.kernel.org # 6.18
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030082402.841751-1-abhijit.gangurde@amd.com?part=1


      reply	other threads:[~2026-10-30  8:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30  8:24 [for-next 1/1] RDMA/ionic: Use a linear QID space when udma_shift is zero Abhijit Gangurde
2026-10-30  8:29 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-190690@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=abhijit.gangurde@amd.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.