All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jani Nikula" <jani.nikula@intel.com>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 09/13] drm/i915/debugfs: pass struct drm_printer to intel_{dp, dp_mst, hdmi}_crtc_info()
Date: Fri, 30 Oct 2026 12:10:32 +0000	[thread overview]
Message-ID: <sashiko-outbox-190995@kernel.org> (raw)
In-Reply-To: <fbe87ba2285dcc3c03b462202b3c66468c40ad3d.1793361738.git.jani.nikula@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/i915/debugfs: commit subject names *_crtc_info() instead of *_info()
--

commit cbb2b1bf881fc1a6e876fdc89f4b11f179ca6fee
Author: Jani Nikula <jani.nikula@intel.com>

>     drm/i915/debugfs: pass struct drm_printer to intel_{dp, dp_mst, hdmi}_crtc_info()
>     
>     Pass struct drm_printer to intel_dp_info(), intel_dp_mst_info(), and
>     intel_hdmi_info().
>     
>     Prefer struct drm_printer * over struct seq_file * to unify and allow
>     use of drm_printer helpers.
>     
>     Signed-off-by: Jani Nikula <jani.nikula@intel.com>

[Severity: Low]
This isn't a bug, but the commit subject references
intel_{dp, dp_mst, hdmi}_crtc_info() whereas the functions modified in
drivers/gpu/drm/i915/display/intel_display_debugfs.c (called from
intel_connector_info()) are intel_dp_info(), intel_dp_mst_info(), and
intel_hdmi_info(). Should the subject line refer to
intel_{dp, dp_mst, hdmi}_info() instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793361738.git.jani.nikula@intel.com?part=9

  reply	other threads:[~2026-10-30 12:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 12:03 [PATCH 00/13] drm/dp, drm/i915: conversions from seq_file to drm_printer Jani Nikula
2026-10-30 12:03 ` [PATCH 01/13] drm/dp: pass struct drm_printer to drm_dp_downstream_debug() Jani Nikula
2026-10-30 12:03 ` [PATCH 02/13] drm/dp: prefer drm_printf_indent() over inline \t Jani Nikula
2026-10-30 12:03 ` [PATCH 03/13] drm/i915/debugfs: pass struct drm_printer to intel_plane_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 04/13] drm/i915/debugfs: pass struct drm_printer to crtc_updates_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 05/13] drm/i915/debugfs: convert crtc_updates_info() to use drm_printf_indent() Jani Nikula
2026-10-30 12:03 ` [PATCH 06/13] drm/i915/debugfs: pass struct drm_printer to intel_scaler_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 07/13] drm/i915/debugfs: pass struct drm_printer to intel_encoder_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 08/13] drm/i915/debugfs: pass struct drm_printer to intel_crtc_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 09/13] drm/i915/debugfs: pass struct drm_printer to intel_{dp, dp_mst, hdmi}_crtc_info() Jani Nikula
2026-10-30 12:10   ` sashiko-bot [this message]
2026-10-30 12:03 ` [PATCH 10/13] drm/i915/debugfs: pass struct drm_printer to intel_hdcp_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 11/13] drm/i915/debugfs: refactor intel_seq_print_mode() into intel_print_mode() Jani Nikula
2026-10-30 12:03 ` [PATCH 12/13] drm/i915/debugfs: pass struct drm_printer to intel_connector_info() Jani Nikula
2026-10-30 12:03 ` [PATCH 13/13] drm/i915/debugfs: prefer drm_printf_indent() over inline \t Jani Nikula
2026-10-30 13:14 ` ✗ CI.checkpatch: warning for drm/dp, drm/i915: conversions from seq_file to drm_printer Patchwork
2026-10-30 13:16 ` ✓ CI.KUnit: success " Patchwork
2026-10-30 13:39 ` ✓ i915.CI.BAT: " Patchwork
2026-10-30 13:52 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-30 22:29 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-190995@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.