From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2619606A339 for ; Fri, 30 Oct 2026 16:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xQ5dyBIZ; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IjvECOsR DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=PnOqwRMeYmp6yvMFRl49Ma+GWNaSajmVebt1So43oqE=; b=xQ5dyBIZPnQukS/RwuR66PV1Ud R884KMazG2HNtVzdpxeR16+Bj+72IZDqfcWvrTazuwEIhNWKk3EzGp5EN25Pmib54kaiue9Kxw43A XBX0Jyguk2iv7czFak9LF3sESbiHGsnSd+lXVoV4TBqbFQqLHAXjNGgCcN5X/0X9xJaeQ48UiVNkF IyZq9hoZ5qtB7HUa61huOKScQWdioAk7+7y4/ylJSIG/Fb+YZPHsUK6jaPv+9Rnp26RXvMtkFfMLz 04yTh3im7X+AupIdj0wQscU1/P+erseRPYYcjDkrzw9Ivdu9zqVH9BzoEuI7+9PUIUkwJWTinRsZZ fEs450kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMpB2-0000000C5gp-1eD3; Fri, 30 Oct 2026 16:10:00 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xMpB1-0000000C5ep-1vFt for linux-mtd@lists.infradead.org; Fri, 30 Oct 2026 16:09:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E1EDB602CA; Fri, 30 Oct 2026 16:09:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 166301F00A15; Fri, 30 Oct 2026 16:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793376598; bh=4f6c50MfKRylF6izNPl1SWtjUxb1UX+AC8qxKNq77dA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IjvECOsR6+cnwW+krKeqX6TWhRgnEw9YrQrOV40dgHGPIARR3NcGCDrCO8QmiyCTp NU4YH/77lOTvaxi5pAjiJbATh+MA87TeI//mtDuR3M15qQBq6MLFYWpjzkg7cxNo1F RDP4/uHtg6C/SfjJE5m0lya+LI8G6mipsibVliUbT+rLKJrjEn0q7YFtOAlR/+WNBG gugCjVV7pCiYzTEAEgZfKDnxClW6QVjCbSHi4iZF/94oRuVLUfJlL+fWm3B7TWhHQN 3zSPIyAuaDdvu2VVfvm2KPlCyUdQxO973uAa2inK4Tl4yKoomQIlqFcssrisdcSKAH aJMmtl3Xtmedg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 11/34] hfs: don't set SB_RDONLY after MDB write errors To: "Christian Brauner" , "Jan Kara" Cc: "Al Viro" , linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org, "Viacheslav Dubeyko" , dsterba@suse.cz, tytso@mit.edu, "Mark Fasheh" , "Joel Becker" , "Joseph Qi" In-Reply-To: <20261029-work-fs-sb_rdonly-v2-11-2f44f64f0b66@kernel.org> References: <20261029-work-fs-sb_rdonly-v2-0-2f44f64f0b66@kernel.org> <20261029-work-fs-sb_rdonly-v2-11-2f44f64f0b66@kernel.org> Date: Fri, 30 Oct 2026 16:09:57 +0000 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gaGZzOiBoZnNfZmls ZV90cnVuY2F0ZSgpIGVhcmx5IHJldHVybiBsZWF2ZXMgaW4tbWVtb3J5IGlub2RlIHNpemVzIGlu Y29uc2lzdGVudAotLQoKY29tbWl0IGE2ZTc0M2YwNmFmOWVkYjU5ZDk0MzY3Y2MxODliYmRiNWI4 YmQ4ODMKQXV0aG9yOiBDaHJpc3RpYW4gQnJhdW5lciA8YnJhdW5lckBrZXJuZWwub3JnPgoKaGZz OiBkb24ndCBzZXQgU0JfUkRPTkxZIGFmdGVyIE1EQiB3cml0ZSBlcnJvcnMKCkluc3RlYWQgb2Yg c2V0dGluZyBTQl9SRE9OTFkgd2l0aG91dCBob2xkaW5nIHNfdW1vdW50IHdoZW4gYW4gTURCIHdy aXRlIGZhaWxzLAp0aGlzIGNvbW1pdCByZWNvcmRzIHRoZSBlcnJvciBpbiBhIG5ldyBIRlNfRkxH X0VNRVJHRU5DWV9STyBmbGFnIGFuZCByZWplY3RzCnN1YnNlcXVlbnQgZmlsZXN5c3RlbSBtb2Rp ZmljYXRpb25zIHdpdGggRVJPRlMuCgo+IGRpZmYgLS1naXQgYS9mcy9oZnMvZXh0ZW50LmMgYi9m cy9oZnMvZXh0ZW50LmMKPiBpbmRleCAyNjM1NzA4NjUxN2ZjLi5kYWNmN2NlMWZmZTRhIDEwMDY0 NAo+IC0tLSBhL2ZzL2hmcy9leHRlbnQuYwo+ICsrKyBiL2ZzL2hmcy9leHRlbnQuYwoKWyAuLi4g XQoKPiBAQCAtNDkxLDYgKzQ5NCw4IEBAIHZvaWQgaGZzX2ZpbGVfdHJ1bmNhdGUoc3RydWN0IGlu b2RlICppbm9kZSkKPiAgCWhmc19kYmcoImlubyAlbGx1LCBwaHlzX3NpemUgJWxsdSAtPiBpX3Np emUgJWxsdVxuIiwKPiAgCQlpbm9kZS0+aV9pbm8sIChsb25nIGxvbmcpSEZTX0koaW5vZGUpLT5w aHlzX3NpemUsCj4gIAkJaW5vZGUtPmlfc2l6ZSk7Cj4gKwlpZiAodW5saWtlbHkoaGZzX2VtZXJn ZW5jeV9ybyhzYikpKQo+ICsJCXJldHVybjsKPiAgCWlmIChpbm9kZS0+aV9zaXplID4gSEZTX0ko aW5vZGUpLT5waHlzX3NpemUpIHsKPiAgCQlzdHJ1Y3QgYWRkcmVzc19zcGFjZSAqbWFwcGluZyA9 IGlub2RlLT5pX21hcHBpbmc7Cj4gIAkJdm9pZCAqZnNkYXRhID0gTlVMTDsKCltTZXZlcml0eTog TWVkaXVtXQpDYW4gcmV0dXJuaW5nIGF0IHRoZSB0b3Agb2YgaGZzX2ZpbGVfdHJ1bmNhdGUoKSBp biBmcy9oZnMvZXh0ZW50LmMgbGVhdmUKaW4tbWVtb3J5IGlub2RlIHNpemUgbWV0YWRhdGEgaW5j b25zaXN0ZW50IHdoZW4gSEZTX0ZMR19FTUVSR0VOQ1lfUk8gKG9yClNCX1NUQVRFX0VNRVJHRU5D WV9STyBpbiB0aGUgZm9sbG93LXVwIGNvbW1pdCAiaGZzOiB1c2UgdGhlIGdlbmVyaWMKZW1lcmdl bmN5IHJlYWQtb25seSBzdGF0ZSIpIGlzIHNldCBjb25jdXJyZW50bHkgYnkgdGhlIG1kYl93b3Jr IHdvcmtlciBvcgpzeW5jX2ZzKCk/CgpGaXJzdCwgaW4gdGhlIGV4cGFuZGluZyB0cnVuY2F0ZSBw YXRoIHZpYSBoZnNfaW5vZGVfc2V0YXR0cigpIGluCmZzL2hmcy9pbm9kZS5jIChvciBub3RpZnlf Y2hhbmdlKCkgaW4gdGhlIGZvbGxvdy11cCBjb21taXQpOgoKICAgIGlmICgoYXR0ci0+aWFfdmFs aWQgJiBBVFRSX1NJWkUpICYmCiAgICAgICAgYXR0ci0+aWFfc2l6ZSAhPSBpX3NpemVfcmVhZChp bm9kZSkpIHsKICAgICAgICAgICAgaW5vZGVfZGlvX3dhaXQoaW5vZGUpOwoKICAgICAgICAgICAg ZXJyb3IgPSBpbm9kZV9uZXdzaXplX29rKGlub2RlLCBhdHRyLT5pYV9zaXplKTsKICAgICAgICAg ICAgaWYgKGVycm9yKQogICAgICAgICAgICAgICAgICAgIHJldHVybiBlcnJvcjsKCiAgICAgICAg ICAgIHRydW5jYXRlX3NldHNpemUoaW5vZGUsIGF0dHItPmlhX3NpemUpOwogICAgICAgICAgICBo ZnNfZmlsZV90cnVuY2F0ZShpbm9kZSk7CgpJZiBIRlNfRkxHX0VNRVJHRU5DWV9STyBpcyBzZXQg YWZ0ZXIgdGhlIGluaXRpYWwgcmVhZC1vbmx5IGNoZWNrIChmb3IKZXhhbXBsZSwgd2hpbGUgd2Fp dGluZyBpbiBpbm9kZV9kaW9fd2FpdCgpKSwgdHJ1bmNhdGVfc2V0c2l6ZSgpIHVwZGF0ZXMKaW5v ZGUtPmlfc2l6ZSBhbmQgdGhlbiBoZnNfZmlsZV90cnVuY2F0ZSgpIHJldHVybnMgZWFybHkgYmVm b3JlIHJlYWNoaW5nCnRoZSBleHBhbnNpb24gYmxvY2s6CgogICAgaWYgKGlub2RlLT5pX3NpemUg PiBIRlNfSShpbm9kZSktPnBoeXNfc2l6ZSkgewogICAgICAgICAgICAuLi4KICAgICAgICAgICAg cmVzID0gaGZzX3dyaXRlX2JlZ2luKE5VTEwsIG1hcHBpbmcsIHNpemUgKyAxLCAwLCAmZm9saW8s CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZnNkYXRhKTsKICAgICAgICAgICAgLi4uCiAg ICAgICAgICAgIGlmIChyZXMpCiAgICAgICAgICAgICAgICAgICAgaW5vZGUtPmlfc2l6ZSA9IEhG U19JKGlub2RlKS0+cGh5c19zaXplOwogICAgICAgICAgICByZXR1cm47CiAgICB9CgpXaXRob3V0 IHRoZSBlYXJseSByZXR1cm4sIGhmc193cml0ZV9iZWdpbigpIGZhaWxzIHdpdGggLUVST0ZTIGFu ZCByZXZlcnRzCmlub2RlLT5pX3NpemUgYmFjayB0byBIRlNfSShpbm9kZSktPnBoeXNfc2l6ZS4g V2l0aCB0aGUgZWFybHkgcmV0dXJuLApoZnNfaW5vZGVfc2V0YXR0cigpIHN1Y2NlZWRzIHdpdGgg aW5vZGUtPmlfc2l6ZSBsYXJnZXIgdGhhbgpIRlNfSShpbm9kZSktPnBoeXNfc2l6ZSBhbmQgSEZT X0koaW5vZGUpLT5mc19ibG9ja3MsIGNhdXNpbmcgc3Vic2VxdWVudApidWZmZXJlZCByZWFkcyB2 aWEgaGZzX3JlYWRfZm9saW8oKSAtPiBibG9ja19yZWFkX2Z1bGxfZm9saW8oKSAtPgpoZnNfZ2V0 X2Jsb2NrKCkgdG8gc2VlIHVuYWxsb2NhdGVkIGJsb2NrcyBhbmQgcmV0dXJuIHplcm8tZmlsbGVk IHBhZ2VzIHVwCnRvIHRoZSBuZXcgaW5vZGUtPmlfc2l6ZS4KClNlY29uZCwgd2hlbiBhbiBleHRl bmRpbmcgd3JpdGUgaW4gaGZzX3dyaXRlX2JlZ2luKCkgb3IgaGZzX2RpcmVjdF9JTygpCmFsbG9j YXRlcyBzb21lIGJsb2NrcyB2aWEgaGZzX2dldF9ibG9jaygpIChpbmNyZW1lbnRpbmcKSEZTX0ko aW5vZGUpLT5waHlzX3NpemUsIEhGU19JKGlub2RlKS0+ZnNfYmxvY2tzLCBhbmQgaW5vZGUtPmlf Ynl0ZXMpIGFuZAp0aGVuIGhpdHMgLUVST0ZTIG9uIGEgc3Vic2VxdWVudCBibG9jayBhZnRlciBI RlNfRkxHX0VNRVJHRU5DWV9STyBpcyBzZXQsCmVycm9yIGNsZWFudXAgY2FsbHMgaGZzX3dyaXRl X2ZhaWxlZCgpOgoKICAgIHN0YXRpYyB2b2lkIGhmc193cml0ZV9mYWlsZWQoc3RydWN0IGFkZHJl c3Nfc3BhY2UgKm1hcHBpbmcsIGxvZmZfdCB0bykKICAgIHsKICAgICAgICAgICAgc3RydWN0IGlu b2RlICppbm9kZSA9IG1hcHBpbmctPmhvc3Q7CgogICAgICAgICAgICBpZiAodG8gPiBpbm9kZS0+ aV9zaXplKSB7CiAgICAgICAgICAgICAgICAgICAgdHJ1bmNhdGVfcGFnZWNhY2hlKGlub2RlLCBp bm9kZS0+aV9zaXplKTsKICAgICAgICAgICAgICAgICAgICBoZnNfZmlsZV90cnVuY2F0ZShpbm9k ZSk7CiAgICAgICAgICAgIH0KICAgIH0KClJldHVybmluZyBlYXJseSBhdCB0aGUgdG9wIG9mIGhm c19maWxlX3RydW5jYXRlKCkgc2tpcHMgdGhlIG91dDogbGFiZWwKYWRqdXN0bWVudHMgYXMgd2Vs bCwgbGVhdmluZyBIRlNfSShpbm9kZSktPnBoeXNfc2l6ZSwKSEZTX0koaW5vZGUpLT5mc19ibG9j a3MsIGFuZCB0aGUgaW5vZGUgYnl0ZSBjb3VudCBpbmZsYXRlZCBwYXN0Cmlub2RlLT5pX3NpemUu CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0 LzIwMjYxMDI5LXdvcmstZnMtc2JfcmRvbmx5LXYyLTAtMmY0NGY2NGYwYjY2QGtlcm5lbC5vcmc/ cGFydD0xMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 224F060A260A for ; Fri, 30 Oct 2026 16:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IjvECOsR Received: by kanga.kvack.org (Postfix) id DC1516B05BD; Fri, 30 Oct 2026 12:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D49846B05BE; Fri, 30 Oct 2026 12:10:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B74F76B05BF; Fri, 30 Oct 2026 12:10:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 758316B05BD for ; Fri, 30 Oct 2026 12:10:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0395A80719 for ; Fri, 30 Oct 2026 16:10:00 +0000 (UTC) X-FDA: 85379779002.07.B6A9B1A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf23.hostedemail.com (Postfix) with ESMTP id 6428014000A for ; Fri, 30 Oct 2026 16:09:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=IjvECOsR; spf=pass (imf23.hostedemail.com: domain of sashiko-bot@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sashiko-bot@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1793376599; b=spqWbj38jRLEDmp53th+B1cX6TprYvOfMeD1Vzo3E31u3HC576WAzD3QsPk/evecrC2dGM B5ls8c+d3ttQFPbG7XewD5RLDrHrKTalQzzwJsIpmz32Mk02XcEGEB/rWVFbHf25IIP7yX fybnUbrsUvO5aN5dUClxrDe3j9FXK2c= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=IjvECOsR; spf=pass (imf23.hostedemail.com: domain of sashiko-bot@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sashiko-bot@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1793376599; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4f6c50MfKRylF6izNPl1SWtjUxb1UX+AC8qxKNq77dA=; b=sKHc6df9wLff1bcCm8B0PIGyG7B2Dng0J03wV5JNCzTJvkIGCU8LK0+c65JsYsfn+TSzIy ZFTXJb7ROOpFupmOfYiaUTWOdgELASctyh2MXfkDSzt4E3xOKlwtwwSR3AyVJ/52+gPKIg wLO89gEbEW9b+PaLEmnEkEww3pWAIv4= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E1EDB602CA; Fri, 30 Oct 2026 16:09:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 166301F00A15; Fri, 30 Oct 2026 16:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793376598; bh=4f6c50MfKRylF6izNPl1SWtjUxb1UX+AC8qxKNq77dA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IjvECOsR6+cnwW+krKeqX6TWhRgnEw9YrQrOV40dgHGPIARR3NcGCDrCO8QmiyCTp NU4YH/77lOTvaxi5pAjiJbATh+MA87TeI//mtDuR3M15qQBq6MLFYWpjzkg7cxNo1F RDP4/uHtg6C/SfjJE5m0lya+LI8G6mipsibVliUbT+rLKJrjEn0q7YFtOAlR/+WNBG gugCjVV7pCiYzTEAEgZfKDnxClW6QVjCbSHi4iZF/94oRuVLUfJlL+fWm3B7TWhHQN 3zSPIyAuaDdvu2VVfvm2KPlCyUdQxO973uAa2inK4Tl4yKoomQIlqFcssrisdcSKAH aJMmtl3Xtmedg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 11/34] hfs: don't set SB_RDONLY after MDB write errors Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" , "Jan Kara" Cc: "Al Viro" , linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org, "Viacheslav Dubeyko" , dsterba@suse.cz, tytso@mit.edu, "Mark Fasheh" , "Joel Becker" , "Joseph Qi" In-Reply-To: <20261029-work-fs-sb_rdonly-v2-11-2f44f64f0b66@kernel.org> References: <20261029-work-fs-sb_rdonly-v2-0-2f44f64f0b66@kernel.org> <20261029-work-fs-sb_rdonly-v2-11-2f44f64f0b66@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 16:09:57 +0000 X-Rspam-User: X-Rspamd-Queue-Id: 6428014000A X-Stat-Signature: wjixqwd5ewze1rqespxqzsdxj194ro4h X-Rspamd-Server: rspam01 X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-HE-Tag: 1793376599-335923 X-HE-Meta: U2FsdGVkX1+0gkc6rc7PZ2fyFhtxgtKmewgy1PGpmfrDPL77FYacDvscXtZDghzSfk7AfKl5nZTZ7Atky/TLrihCqfyfN/BugXqxvGyJErw4jTG7kaHrxeQAk2Z7bL8XsRI0nazcDA/0dClRm6yWWoGtkPRMA6Vz2p4FWX7hhDxGw7tioZDtH/ls5InZx0zWlTIKXelQbis8ieoY+tbifIINVOK/7ysa0unxs1rSjsbBjJHrTSkuTTQPMpsXoOLh5bJlYJN2FUBnW3P0dJ8yWeRSj1mXv4SW4bsho4Dl2R+ilVL+StkOy/OcQ4NOpkhQz1WhlT9+9LkPQqkJuuEpHQ3nC0ZtLhRkN9ylFjP4Q+3AFXvYCjoEFneHm6M+FndJ77ITyCWeLju0BhaiIWQyEurYqOuCaZpv5v1OaUqzt8gOROS6obtr0dqJpYHjdYwsw4GhkJvwiMTkU4G4pZr1rB/moArAmaKlQ2eTBYwbA0+/HUIZ4ioWOArOJ+633SRyXbeq5fryLigo2kCsxbu9xcJzH3cuU+UPTF4t7L50pusGzckeaPxIp/eLeJTigaAxigL0bSAWyN/VmYkY+7+VwM3EFt1MGFGK90WMo/3u/EFDH1bYj8U2nIyT8iRtf+h4NPibBGyxCzbnpMgKKRAfag2f4nVqcuGbFkOQzGnaLjF+l6YTca7ILfNk/JQcy4IBAvscowRSkL+yloFE5+ZytbgPq2HzV5/1AbJjW/4tlTIRuIj4rn5Ij7j16qqTyXLMV/E9CfuOygKXlJbX1lv/KFvzEfXlMqV41Jsvwkm+lyFqJaE3GxIPPFcIgld/Wo87HEKD8V9rJAP938+5Z8CP2HqqguYuC+BTHFniTJv3yKcHWm7EjLjiKddFo4R/G8sqUPhQ9h3EpHAZCbiMkqoSNYZL9wKARLzbAl5jW4S5WuSj+e1IfZh+Z8B17+g3m+KO8EvwaiFRDQLnzb4GNWJ L1cP0+py LUnO7ztdfHogEW7nvVd7kKmHeY+BnlpXapErxW6ErOVqbBZF1kdQu1Ua6dLVdK5rCBOvGdkIZH/F9Z0+zXdlXfOTPRqB7bQEUePe/9jLhb4BQI1MeS0k6ptgdb7YCIjN09hh20PPzS+aPBI3chDpqU1mGvllJaUzttt8pILnhedv+HgNePSmNHqcBz8vvC9Nth4AjhzksBlG81xWkOAUm3c1GQfiYIxDFbOccbZJcEmHHx46kKhP1nB/8OX+QXwAZv8d2hldVTjICxkTo5ieQg6nIaUZI8ovsWolKeKud2Va3z0fcxAQDR4ZjnPiYsXRdQDCoyyQD75NWvyKjbiNxUpB0KjmMjFIVv9wNvCRQm/t8rIgxcThpBHhd8F4c8jFSbZw7tg0yiZjzYEKjLYiLNeoaDayK5FyBoJFA2G34o8YnoljkkVefAAtrE5wsFQSB5Qb2/YTlDll9fq3bWHhXCf0X53BYj6rHBNNLWKiEPdGyjeiBCV9WtuOAKZ+tj5dV9F+WWj8JnMvi6xrJrLm6/R12XIs3xD+Fk8ij0/qRT5LfD/Hunh75Im/osHe07k8COjCwELWwevcijAnzie08Kb3JjSpEQQiJ5Si9F9OgIkV7s0AoaY/31hB9M0lpVdCkk9QB Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] hfs: hfs_file_truncate() early return leaves in-memory inode siz= es inconsistent -- commit a6e743f06af9edb59d94367cc189bbdb5b8bd883 Author: Christian Brauner hfs: don't set SB_RDONLY after MDB write errors Instead of setting SB_RDONLY without holding s_umount when an MDB write fai= ls, this commit records the error in a new HFS_FLG_EMERGENCY_RO flag and rejects subsequent filesystem modifications with EROFS. > diff --git a/fs/hfs/extent.c b/fs/hfs/extent.c > index 26357086517fc..dacf7ce1ffe4a 100644 > --- a/fs/hfs/extent.c > +++ b/fs/hfs/extent.c [ ... ] > @@ -491,6 +494,8 @@ void hfs_file_truncate(struct inode *inode) > hfs_dbg("ino %llu, phys_size %llu -> i_size %llu\n", > inode->i_ino, (long long)HFS_I(inode)->phys_size, > inode->i_size); > + if (unlikely(hfs_emergency_ro(sb))) > + return; > if (inode->i_size > HFS_I(inode)->phys_size) { > struct address_space *mapping =3D inode->i_mapping; > void *fsdata =3D NULL; [Severity: Medium] Can returning at the top of hfs_file_truncate() in fs/hfs/extent.c leave in-memory inode size metadata inconsistent when HFS_FLG_EMERGENCY_RO (or SB_STATE_EMERGENCY_RO in the follow-up commit "hfs: use the generic emergency read-only state") is set concurrently by the mdb_work worker or sync_fs()? First, in the expanding truncate path via hfs_inode_setattr() in fs/hfs/inode.c (or notify_change() in the follow-up commit): if ((attr->ia_valid & ATTR_SIZE) && attr->ia_size !=3D i_size_read(inode)) { inode_dio_wait(inode); error =3D inode_newsize_ok(inode, attr->ia_size); if (error) return error; truncate_setsize(inode, attr->ia_size); hfs_file_truncate(inode); If HFS_FLG_EMERGENCY_RO is set after the initial read-only check (for example, while waiting in inode_dio_wait()), truncate_setsize() updates inode->i_size and then hfs_file_truncate() returns early before reaching the expansion block: if (inode->i_size > HFS_I(inode)->phys_size) { ... res =3D hfs_write_begin(NULL, mapping, size + 1, 0, &folio, &fsdata); ... if (res) inode->i_size =3D HFS_I(inode)->phys_size; return; } Without the early return, hfs_write_begin() fails with -EROFS and reverts inode->i_size back to HFS_I(inode)->phys_size. With the early return, hfs_inode_setattr() succeeds with inode->i_size larger than HFS_I(inode)->phys_size and HFS_I(inode)->fs_blocks, causing subsequent buffered reads via hfs_read_folio() -> block_read_full_folio() -> hfs_get_block() to see unallocated blocks and return zero-filled pages up to the new inode->i_size. Second, when an extending write in hfs_write_begin() or hfs_direct_IO() allocates some blocks via hfs_get_block() (incrementing HFS_I(inode)->phys_size, HFS_I(inode)->fs_blocks, and inode->i_bytes) and then hits -EROFS on a subsequent block after HFS_FLG_EMERGENCY_RO is set, error cleanup calls hfs_write_failed(): static void hfs_write_failed(struct address_space *mapping, loff_t to) { struct inode *inode =3D mapping->host; if (to > inode->i_size) { truncate_pagecache(inode, inode->i_size); hfs_file_truncate(inode); } } Returning early at the top of hfs_file_truncate() skips the out: label adjustments as well, leaving HFS_I(inode)->phys_size, HFS_I(inode)->fs_blocks, and the inode byte count inflated past inode->i_size. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261029-work-fs-sb= _rdonly-v2-0-2f44f64f0b66@kernel.org?part=3D11