From: sashiko-bot@kernel.org
To: "Simon Song" <xinmengs@nvidia.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 7/9] rust: pci: add SR-IOV enable and disable tokens
Date: Fri, 30 Oct 2026 17:21:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-191326@kernel.org> (raw)
In-Reply-To: <20261030171230.196717-8-xinmengs@nvidia.com>
> From: Zhi Wang <zhiw@nvidia.com>
>
> Enabling VFs can succeed before the driver's remaining setup fails.
> Use a callback-scoped token to return an enabled guard that disables
> SR-IOV when dropped, rolling back those VFs on a later error.
>
> Add SriovEnable, SriovEnabled and SriovDisable for the split callbacks
> introduced next. Tie each token to its PF and callback lifetime, and
> limit the enabled count to the user's request. The PCI adapter disarms
> the guard when accepting a successful enable callback.
>
> Require a VfRegistration to own final VF teardown after that handoff.
> Drivers that do not share data with VFs can register (). A disable
> token permits explicit shutdown without forcing it on a rejected
> request.
>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> Signed-off-by: Simon Song <xinmengs@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261030171230.196717-1-xinmengs@nvidia.com?part=7
next prev parent reply other threads:[~2026-10-30 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 17:12 [PATCH v5 0/9] Add Rust PCI SR-IOV support Simon Song
2026-10-30 17:12 ` [PATCH v5 1/9] rust: pci: add internal SR-IOV enable and disable helpers Simon Song
2026-10-30 17:17 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 2/9] rust: pci: add vtable attribute to pci::Driver trait Simon Song
2026-10-30 17:17 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 3/9] rust: pci: add is_virtfn(), to check for VFs Simon Song
2026-10-30 17:21 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 4/9] rust: pci: add num_vf(), to return number of VFs Simon Song
2026-10-30 17:21 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 5/9] rust: pci: drop driver data before remove returns Simon Song
2026-10-30 17:21 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 6/9] rust: pci: add typed SR-IOV PF registration data Simon Song
2026-10-30 17:32 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 7/9] rust: pci: add SR-IOV enable and disable tokens Simon Song
2026-10-30 17:21 ` sashiko-bot [this message]
2026-10-30 17:12 ` [PATCH v5 8/9] rust: pci: add SR-IOV enable and disable callbacks Simon Song
2026-10-30 17:23 ` sashiko-bot
2026-10-30 17:12 ` [PATCH v5 9/9] samples: rust: add Rust SR-IOV PF and VF driver samples Simon Song
2026-10-30 17:26 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-191326@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xinmengs@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.