Re: [PATCH] usb: typec: ucsi: retry init only while the PPM is not ready

[sashiko-bot@kernel.org]

> Commit 254261381538 ("usb: typec: ucsi: retry init when the PPM
> answers early commands incorrectly") makes ucsi_init_work() retry
> ucsi_init() on -ENODEV and -EINVAL, a hundred times over ten seconds,
> to cover a PPM that is not ready to answer commands correctly for a
> short window during boot.
> 
> It catches more than that. ucsi_register_port() also fails with
> -ENODEV when no USB role switch is available, and logs that at error
> level, so every retry runs it again and logs it again. Where a machine
> without a usable role switch used to log
> 
>   ucsi_acpi USBC000:00: error -ENODEV: con1: failed to get usb role switch
>   ucsi_acpi USBC000:00: error -ENODEV: PPM init failed
> 
> it now logs a hundred and one copies of the first line, followed by
> [ ... ]
> 
> Fixes: 254261381538 ("usb: typec: ucsi: retry init when the PPM answers early commands incorrectly")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Closes: https://lore.kernel.org/r/CAHk-=wjGk9rBTphk1OAwcqGAE1__KJgMr3B-8X4hKFPX8Wm=BQ@mail.gmail.com
> Signed-off-by: Jacob Riff <jacob@riff.dk>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031032400.38349-1-jacob@riff.dk?part=1