Re: [PATCH mptcp-next v2 8/8] selftests: bpf: mptcp: test a scheduler reinjecting on an idle subflow

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: multi-line comments in test_reinject() and bpf_reinject_get_retrans() violate BPF comment style
--

commit 85b159ecf48bf639151eb32d4b50cba4bfb3a107
Author: Abdul Wasey <w453y.me@gmail.com>

selftests: bpf: mptcp: test a scheduler reinjecting on an idle subflow

This commit adds a bpf mptcp scheduler selftest (bpf_reinject) that sends
new data only on the first subflow and reinjects up to 64 KB on another
subflow when get_retrans is invoked for an idle subflow.

> diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> index 4302c16cb6bb4..723f42b458270 100644
> --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
> +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
[ ... ]
> @@ -821,6 +822,27 @@ static void test_burst(void)
>  	mptcp_bpf_burst__destroy(skel);
>  }
>  
> +/* New data only goes on the first subflow, so the second one only carries
> + * what the scheduler asks the core to reinject when it goes idle.
> + */
> +static void test_reinject(void)
[ ... ]
> diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_reinject.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_reinject.c
> new file mode 100644
> index 0000000000000..3e315c7ead67c
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_reinject.c
> @@ -0,0 +1,70 @@
[ ... ]
> +/* On an MPTCP RTO, resend on the first subflow. When the core asks because
> + * a subflow is idle, resend up to 64 KB of what the first subflow holds on
> + * another one, so the second address only carries reinjected data.
> + */
> +SEC("struct_ops")
> +int BPF_PROG(bpf_reinject_get_retrans, struct mptcp_sock *msk)

[Severity: Low]
This isn't a bug, but the new multi-line comments above test_reinject() in
tools/testing/selftests/bpf/prog_tests/mptcp.c and above
bpf_reinject_get_retrans() in
tools/testing/selftests/bpf/progs/mptcp_bpf_reinject.c place comment text on
the same line as the opening /* delimiter. Could these be formatted with the
opening /* on its own line to match the bpf coding style?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031-mptcp-sched-opp-retrans-v2-0-e9c4a30f6841@kernel.org?part=8