From: sashiko-bot@kernel.org
To: "Ingyu Jang" <ingyujang25@korea.ac.kr>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/x86/amd/core: Make amd_core_pmu_init() return void
Date: Sun, 01 Nov 2026 04:08:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-192267@kernel.org> (raw)
In-Reply-To: <20261101040356.3204097-1-ingyujang25@korea.ac.kr>
> amd_core_pmu_init() has always returned 0 since commit 471af006a747
> ("perf/x86/amd: Constrain Large Increment per Cycle events") removed
> its -ENODEV path for unknown CPU families, so the error check in
> amd_pmu_init() never triggers.
>
> Change the function's return type to void and remove the dead check.
>
> Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261101040356.3204097-1-ingyujang25@korea.ac.kr?part=1
next prev parent reply other threads:[~2026-11-01 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 4:03 [PATCH] perf/x86/amd/core: Make amd_core_pmu_init() return void Ingyu Jang
2026-11-01 4:08 ` sashiko-bot [this message]
2026-11-02 13:49 ` Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-192267@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ingyujang25@korea.ac.kr \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.