Re: [RFC PATCH v2 3/6] mm/damon/vaddr: implement sz_filter_passed for migrate_{hot,cold} action

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mm/damon/vaddr: undeclared dests in damos_va_migrate_pmd_entry()
--

commit 7670e03c4d866e7e831b34d6066cefe5b658b73a
Author: SJ Park <sj@kernel.org>

mm/damon/vaddr: implement sz_filter_passed for migrate_{hot,cold} action

This commit adds sz_filter_passed accounting to the DAMON_VADDR
migrate_hot and migrate_cold actions by passing the counter through
damos_va_migrate_private and accumulating the size of folios that pass
ops filters in damos_va_migrate_pmd_entry().

> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index b1d7bcf7305bb..6fd0e07b60705 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
[ ... ]
> @@ -846,7 +847,7 @@ static int damos_va_migrate_pmd_entry(pmd_t *pmd, unsigned long addr,
>  	struct damos_va_migrate_private *priv = walk->private;
>  	struct list_head *migration_lists = priv->migration_lists;
>  	struct damos *s = priv->scheme;
> -	struct damos_migrate_dests *dests = &s->migrate_dests;
> +	unsigned long *sz_filter_passed = priv->sz_filter_passed;
>  	struct folio *folio;
>  	spinlock_t *ptl;
>  	pte_t *start_pte, *pte, ptent;
> @@ -865,6 +866,7 @@ static int damos_va_migrate_pmd_entry(pmd_t *pmd, unsigned long addr,
>  		if (damos_va_filter_out(s, folio, walk->vma, addr, NULL, pmd))
>  			goto huge_out;
>  		s->last_applied = folio;
> +		*sz_filter_passed += folio_size(folio);
>  		damos_va_migrate_dests_add(folio, walk->vma, addr, dests,
>  				migration_lists);

[Severity: Low]
Was the declaration of dests in damos_va_migrate_pmd_entry() removed by
accident when adding sz_filter_passed?

Both the transparent hugepage path above and the PTE loop below in
damos_va_migrate_pmd_entry() still pass dests to
damos_va_migrate_dests_add(), which causes mm/damon/vaddr.c to fail to
compile with an undeclared identifier error when CONFIG_DAMON_VADDR is
enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261101171630.81477-1-sj@kernel.org?part=3