Re: [PATCH v3 7/7] remoteproc: sunxi: Add KUnit tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] remoteproc: sunxi: missing CONFIG_PM dependency in KUnit test
- [Low] remoteproc: sunxi: missing __force on __iomem casts in use_mmio_mocks()
--

commit 9db9877d3095c9678cf19b6cc5cf48fbc1c0e95d
Author: Tim Michals <tcmichals@gmail.com>

remoteproc: sunxi: Add KUnit tests

This commit adds 26 KUnit tests for the Allwinner sunxi remoteproc driver,
covering address translation, lifecycle callbacks, crash handling, firmware
parsing, and mailbox notifications using KUnit static stubs and mock
providers.

> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index d2929a3290c3f..6516e272689e4 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -348,6 +348,21 @@ config SUNXI_REMOTEPROC
>  	  To compile this driver as a module, choose M here: the module will
>  	  be called sunxi_rproc.
>  
> +config SUNXI_REMOTEPROC_KUNIT_TEST
> +	tristate "KUnit tests for Allwinner sunxi remoteproc" if !KUNIT_ALL_TESTS
> +	depends on SUNXI_REMOTEPROC && KUNIT && COMMON_CLK && RESET_CONTROLLER
> +	default KUNIT_ALL_TESTS

[Severity: Medium]
Should SUNXI_REMOTEPROC_KUNIT_TEST also depend on PM?

In include/linux/pm.h, the usage_count member of struct dev_pm_info is only
defined when CONFIG_PM is enabled:

    #ifdef CONFIG_PM
        ...
        atomic_t        usage_count;

When CONFIG_PM is disabled, expect_powered_off(),
test_prepare_unprepare_order(), and test_prepare_power_up_failure() in
drivers/remoteproc/sunxi_rproc_kunit.c fail to compile because they read
dev->power.usage_count unconditionally.

In addition, test_prepare_power_up_failure() relies on dev_pm_domain_set()
and pm_runtime_enable() so that sunxi_rproc_prepare() ->
pm_runtime_resume_and_get() invokes mock_failing_pm_domain.ops.runtime_resume
and returns -EIO. When CONFIG_PM is disabled, those helpers are no-op stubs
and pm_runtime_resume_and_get() returns 0 instead of -EIO.

[ ... ]

> diff --git a/drivers/remoteproc/sunxi_rproc_kunit.c b/drivers/remoteproc/sunxi_rproc_kunit.c
> new file mode 100644
> index 0000000000000..0931564dc22bb
> --- /dev/null
> +++ b/drivers/remoteproc/sunxi_rproc_kunit.c

[ ... ]

> +static void use_mmio_mocks(struct test_context *ctx)
> +{
> +	ctx->priv.cfg_va = (void __iomem *)ctx->mock_cfg_regs;
> +	ctx->priv.remap_va = (void __iomem *)&ctx->mock_remap_reg;
> +	ctx->priv.sram0_va = (void __iomem *)ctx->mock_sram_buf;
> +	ctx->priv.sram0_size = sizeof(ctx->mock_sram_buf);
> +	ctx->priv.sram1_va = (void __iomem *)ctx->mock_sram1_buf;
> +	ctx->priv.sram1_size = sizeof(ctx->mock_sram1_buf);
> +}

[Severity: Low]
Unlike FAKE_SRAM_VA and FAKE_SRAM1_VA, which use (void __force __iomem *),
the casts in use_mmio_mocks() omit __force when casting normal kernel
memory buffers to __iomem pointers. Should these casts use
(void __force __iomem *) to avoid Sparse address-space warnings when
building with C=1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261101185735.762559-1-tcmichals@gmail.com?part=7