Re: [PATCH v2 1/7] dt-bindings: mfd: Describe the BCM6846 PMC complex

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] dt-bindings: mfd: brcm,bcm6846-pmc references files added in next patch
- [Low] dt-bindings: mfd: brcm,bcm6846-pmc example child nodes out of name order
- [Low] MAINTAINERS: missing S: status field in BROADCOM BCMBCA PMC3 PMB DRIVER
--

commit 39aa42d4e944629fc1763b294af564d34ce88b86
Author: Linus Walleij <linusw@kernel.org>

dt-bindings: mfd: Describe the BCM6846 PMC complex

This commit adds the Device Tree binding schema for the Broadcom BCM6846
Power Management Controller (PMC3) complex and adds a corresponding
entry in MAINTAINERS.

> diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
> new file mode 100644
> index 0000000000000..78aef68bc3183
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml
> @@ -0,0 +1,82 @@

[ ... ]

> +patternProperties:
> +  '^bus@[0-9a-f]+$':
> +    $ref: /schemas/soc/bcm/brcm,bcm6846-pmb.yaml#
> +    description: PMB configuration, keyhole and address mapping registers
> +
> +required:
> +  - compatible
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/brcm,bcm6846-pmb.h>
> +    #include <dt-bindings/reset/brcm,bcm6846-pmb.h>

[Severity: Low]
As reported by Krzysztof Kozlowski on RFC [1], does running
make dt_binding_check fail at this commit because patternProperties
references /schemas/soc/bcm/brcm,bcm6846-pmb.yaml# and the example
includes dt-bindings/clock/brcm,bcm6846-pmb.h and
dt-bindings/reset/brcm,bcm6846-pmb.h before they exist in the tree?

Those headers, the referenced schema, and the child compatibles
(brcm,bcm6846-pmb, brcm,bcm6846-pmb-clock, brcm,bcm6846-pmb-reset, and
brcm,bcm6846-pmb-pvtmon) are only introduced in the subsequent patch,
commit 44e16c21f8b2 ("dt-bindings: soc: Describe the BCM6846 Processor
Monitor Bus"). Should that patch be ordered before this one so that
schema validation and example compilation succeed at every commit in the
series?

> +
> +    system-controller@ffb00000 {
> +        /* Broadcom BCM6846 Power Management Controller complex */
> +        compatible = "brcm,bcm6846-pmc", "simple-mfd";
> +        ranges = <0x0 0xffb00000 0x21000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        /* Called PMB Processor Monitor Bus in vendor tree */
> +        bus@20100 {
> +            compatible = "brcm,bcm6846-pmb";
> +            reg = <0x20100 0x200>;
> +
> +            pmb_clk: clock-controller {
> +                compatible = "brcm,bcm6846-pmb-clock";
> +                clocks = <&osc50m>;
> +                clock-names = "ref";
> +                #clock-cells = <1>;
> +            };
> +
> +            pmb_reset: reset-controller {
> +                compatible = "brcm,bcm6846-pmb-reset";
> +                #reset-cells = <1>;
> +            };
> +
> +            hwmon {
> +                compatible = "brcm,bcm6846-pmb-pvtmon";

[Severity: Low]
Should the hwmon node be placed before pmb_reset: reset-controller in
the bus@20100 example node?

For child nodes without unit addresses, DTS coding style requires
alpha-numerical ordering by node name, and check_child_name_order() in
scripts/dtc/dt-check-style --mode=strict warns when hwmon appears after
reset-controller.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 93abbb315065d..eb4b3b631e82c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5444,6 +5444,10 @@ N:	bcm[9]?6856
>  N:	bcm[9]?6858
>  N:	bcm[9]?6878
>  
> +BROADCOM BCMBCA PMC3 PMB DRIVER
> +M:	Linus Walleij <linusw@kernel.org>
> +F:	Documentation/devicetree/bindings/mfd/brcm,bcm6846-pmc.yaml

[Severity: Low]
Is this new MAINTAINERS entry missing an S: status line (such as
S: Maintained)? Without it, scripts/get_maintainer.pl
--self-test=sections reports a section without status warning.

[1] https://lore.kernel.org/r/ddfe83b7-d4b8-4d56-a295-fde63519bdde@kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261101-xg6846b-bcmbca-xrdp-reset-v2-0-455fe9eed5ee@kernel.org?part=1