Re: [PATCH v3 04/12] arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: redundant IPA properties in sm6350-lena board DTS
--

commit ea5a49fe7f1eb96f27686737dd2b4c7bc009edc7
Author: erebion <erebion@erebion.eu>

arm64: dts: qcom: sm6350-lena: Enable ADSP, CDSP, IPA & MPSS

This commit enables the ADSP, CDSP, IPA, and MPSS nodes in the Device
Tree for the Sony Xperia 10 III (pdx213).

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 1e89c9798edf8..ce351a3fa8727 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts

[ ... ]

> @@ -325,6 +337,20 @@ touchscreen@48 {
>  	};
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/sm6350/sony/pdx213/ipa_fws.mbn";
> +	memory-region = <&pil_ipa_fw_mem>;
> +	qcom,gsi-loader = "self";
> +
> +	status = "okay";
> +};

[Severity: Low]
Are memory-region and qcom,gsi-loader needed in &ipa here?

Commit dc88d56f27e0 ("arm64: dts: qcom: sm6350: consolidate IPA
properties") moved both properties into the base ipa: ipa@1e40000 node in
arch/arm64/boot/dts/qcom/sm6350.dtsi:

	ipa: ipa@1e40000 {
		compatible = "qcom,sm6350-ipa";
		...
		qcom,gsi-loader = "self";
		memory-region = <&pil_ipa_fw_mem>;
		status = "disabled";
	};

and dropped them from board files such as
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts. Could &ipa in
arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts only specify
firmware-name and status = "okay", matching &adsp, &cdsp, and &mpss?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-pdx213-upstream-3-v3-0-cdc3be96d257@erebion.eu?part=4