Re: [PATCH bpf-next] selftests/bpf: Use memfd_create instead of mkstemp in d_path

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests/bpf: deprecated CHECK() used in test_d_path_mem_access()
--

commit 70ec4540d31dab1fed0411808b9f6ef87d380925
Author: Jonathan Bastari Thamrin <thamrinjonathan@gmail.com>

selftests/bpf: Use memfd_create instead of mkstemp in d_path

This commit replaces mkstemp() in /dev/shm with memfd_create() in
test_d_path_mem_access() so the check_mem_access subtest can run under
vmtest.sh when /dev/shm is not mounted.

> diff --git a/tools/testing/selftests/bpf/prog_tests/d_path.c b/tools/testing/selftests/bpf/prog_tests/d_path.c
> index 1a2a2f1abf033..0f0150d73262b 100644
> --- a/tools/testing/selftests/bpf/prog_tests/d_path.c
> +++ b/tools/testing/selftests/bpf/prog_tests/d_path.c

[ ... ]

> @@ -230,13 +230,12 @@ static void test_d_path_mem_access(void)
>  
>  	bss = skel->bss;
>  
> -	localfd = mkstemp(path_template);
> -	if (CHECK(localfd < 0, "trigger", "mkstemp failed\n"))
> +	localfd = memfd_create("d_path_loadgen", 0);
> +	if (CHECK(localfd < 0, "trigger", "memfd_create failed\n"))
>  		goto cleanup;

[Severity: Low]
This isn't a bug, but since CHECK() is deprecated in BPF selftests, should
this updated check in test_d_path_mem_access() use ASSERT_OK_FD() from
tools/testing/selftests/bpf/test_progs.h instead (similar to commit
47687a29b2c3 ("selftests/bpf: Use memfd_create instead of shm_open in
cgroup_iter_memcg"))?

	if (!ASSERT_OK_FD(localfd, "memfd_create"))
		goto cleanup;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-d-path-memfd-v1-1-692a5664b36d@gmail.com?part=1