Re: [PATCH 1/2] dt-bindings: arm: fsl: Add ADLINK LEC-iMX95

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arm: fsl: undocumented adlink vendor prefix in fsl.yaml
--

commit adf2fbda79acf7e7bef8349bedcf40bfbb38f343
Author: Dinesh kumar v <dineshkumarv85@gmail.com>

dt-bindings: arm: fsl: Add ADLINK LEC-iMX95

This commit adds compatible strings to Documentation/devicetree/bindings/arm/fsl.yaml
for the ADLINK LEC-iMX95 module and its I-Pi SMARC Plus carrier board.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 656f2596e1d53..c3f4c2814d6c0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1597,6 +1597,12 @@ properties:
>            - const: variscite,var-dart-mx95 # Variscite DART-MX95 SOM
>            - const: fsl,imx95
>  
> +      - description: ADLINK LEC-iMX95 based Boards
> +        items:
> +          - const: adlink,lec-imx95-ipi-smarc
> +          - const: adlink,lec-imx95
> +          - const: fsl,imx95

[Severity: Low]
Is the adlink vendor prefix documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml?

Looking at patternProperties in
Documentation/devicetree/bindings/vendor-prefixes.yaml, the entries go
directly from adieng to admatec without an entry for adlink:

  "^adieng,.*":
    description: ADI Engineering, Inc.
  "^admatec,.*":
    description: admatec GmbH
  "^advantech,.*":
    description: Advantech Corporation

Without registering "^adlink,.*" in vendor-prefixes.yaml, running
dt_binding_check, dtbs_check, or scripts/checkpatch.pl reports an
undocumented vendor prefix for adlink,lec-imx95-ipi-smarc and
adlink,lec-imx95.

Also, in the i.MX95 section of properties.compatible.oneOf in
Documentation/devicetree/bindings/arm/fsl.yaml, the vendor board groups
(PHYTEC, Toradex, Variscite) are ordered alphabetically by vendor. Should the
ADLINK LEC-iMX95 based Boards entry be placed before PHYTEC i.MX 95 FPSC
based Boards instead of after Variscite DART-MX95 based Boards?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102065645.121046-1-dinesh.v@adlinktech.com?part=1