From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793608740; b=3nE3zz2ZzjZyuXLM7x5rjMHLXA/nOhw4fPlKj4uKZ8f6na7pq4X3vqM+WHPthnfXjSfA m/QXagAuxRN48PnBcQEzBHdXoVER6qxtN4bpVUWgg0ZUvauq7G8Iw8gWRo5N4OTqpxnQT 0XfXAy3wXeF9FKE8XUITY3JwvAC2oBVjNLOkFhCTLkmfcNIu35RWRPLtJ8qsFzHKyFUOY SBIfx57zVgEcCkxCR+obMF5gCZ2gmLu9C+k9O2bno4YgNbthbVKtdWGzSf3N2fvh84cbd iVtmlay4KKgO2LfDEim9xxn8Z4KnJ0b0fCfLLoH4c9xzFXfkQATup1gUnLFGrOoMh6A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793608740; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=+ujXPh5DWImCZX0JZvrqR6XdNCQ9pQMh1AAs5cuycDw=; b=1/ti5gcWkpFIXalD090ZGE/MQhN2kBNaEvUzTjliF9J3CJPFksNM8xuq8u3eaTIIRUnq GJLmiOG7VsNPeDPIsgr0/LdcdXdBUBTce0/MSf1XAndD+hi6bvKJDqO+NepeFk+O5NDVg dsaLyGqVRgqh7VZYVdN5RoNPKnvm3hlKISiKT+7TJtWHi1YOhYmEugFe1OBIqkDO7ARkn Ne3pUg/MRlCpSda7cGfrYlba8HwcWayo3zmDLiKCFksI6BI9UJu3McXobbgA4tKvNnJRk v0vydK+bwx4QVnSgiK0PqAuiyfZ134RVcodId28YptrvyLjCKJlp1KYlZgPpLpZZxAA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LIUlEg6q; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7432606A327 for ; Mon, 2 Nov 2026 08:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LIUlEg6q Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04F8E1F00A18; Mon, 2 Nov 2026 08:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793608739; bh=+ujXPh5DWImCZX0JZvrqR6XdNCQ9pQMh1AAs5cuycDw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=LIUlEg6qDTYcydeff3YbsDqdkgXDQNAYrO2VdNd68YqcYI76REarYWvHpdKAd7zEu RUW1CzLuol4ymEUOkmAPONi9kywNAdix6xuHeKyfvjcY5oFfn3NciXMArVG41hLF4U 6BbZzFnJjFdDXZ2UmjVctL6uqNpQC7vT6OLz6HSOTrtaaZwxrU2l43m6CrENlzOjPV WWNTEqFK2J+tXVkvmBaOj0HTNBw/HJw7zGotsV6rMh0+AGCWODJZSca2NojR9rgB/D MID6RjyFxgstbSuXZ5PZrOluop7PH4wTyBffQscrDYY3JdU1TKi8mWgbxhsWOmJAMD LO4DPi40v6UgQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: cix: add Sky1 USB/DP combo PHY driver Reply-To: sashiko-reviews@lists.linux.dev To: "Gary Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261102082112.2306326-3-gary.yang@cixtech.com> References: <20261102082112.2306326-1-gary.yang@cixtech.com> <20261102082112.2306326-3-gary.yang@cixtech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 02 Nov 2026 08:38:58 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 7 potential issue(= s) to consider: - [High] phy: cix: udphy_dp_phy_set_rate() checks DPCD codes instead of Mb/= s link_rate - [High] phy: cix: udphy_dp_phy_set_voltages() applies lane 0 settings to a= ll lanes - [High] phy: cix: mode tracking in cix_usbdp_phy_power_on() leaks clk and = skips init - [High] phy: cix: udphy_dp_phy_configure() accesses MMIO when DP PHY is un= powered - [High] phy: cix: udphy_dp_phy_verify_config() mishandles dp->lanes and dp= ->set_lanes - [High] phy: cix: cix_u3phy_ops omits .init/.power_on and misuses .set_mode - [Medium] phy: cix: cix_udphy_probe() resets PHY despite bootloader handov= er claim -- commit d4e0ce4573b0a846fb24af3d6c745c7798d8f7a9 Author: Gary Yang phy: cix: add Sky1 USB/DP combo PHY driver This commit adds a driver for the CIX Sky1 USB/DP combo PHY, exposing separate child PHYs for the SuperSpeedPlus USB lane and DisplayPort lane while registering a Type-C orientation switch and mode mux. > diff --git a/drivers/phy/cix/phy-cix-usbdp.c b/drivers/phy/cix/phy-cix-us= bdp.c > new file mode 100644 > index 0000000000000..d596e89c74f76 > --- /dev/null > +++ b/drivers/phy/cix/phy-cix-usbdp.c [ ... ] > +static int sky1_udphy_exit(struct cix_udphy *udphy) > +{ > + reset_control_assert(udphy->reset); > + reset_control_assert(udphy->preset); > + clk_disable_unprepare(udphy->apb_clk); > + return 0; > +} > + > +static int sky1_udphy_init(struct cix_udphy *udphy) > +{ > + int ret; > + u32 value; > + const struct cix_udphy_con_dir *con_dir =3D &udphy->cfg->con_dir[udphy-= >id]; > + > + regmap_update_bits(udphy->usbphy_syscon, con_dir->offset, > + GENMASK(con_dir->bit, con_dir->bit), > + udphy->flip << con_dir->bit); > + > + usleep_range(10, 20); > + > + regmap_read(udphy->usbphy_syscon, con_dir->offset, &value); > + > + /* usb rcsu reset is default deassert */ > + reset_control_assert(udphy->reset); > + reset_control_assert(udphy->preset); > + > + ret =3D sky1_udphy_clk_enable(udphy->apb_clk); > + if (ret) { > + dev_err(udphy->dev, "Failed to prepare_enable udphy apb clock\n"); > + return ret; > + } [ ... ] > +static int udphy_orien_sw_set(struct typec_switch_dev *sw, > + enum typec_orientation orien) > +{ > + struct cix_udphy *udphy =3D typec_switch_get_drvdata(sw); > + > + mutex_lock(&udphy->mutex); > + > + if (orien =3D=3D TYPEC_ORIENTATION_NONE) > + goto unlock_ret; > + > + udphy->flip =3D (orien =3D=3D TYPEC_ORIENTATION_REVERSE) ? true : false; > + > +unlock_ret: > + mutex_unlock(&udphy->mutex); > + return 0; > +} [ ... ] > +static int cix_usbdp_phy_power_on(struct cix_udphy *udphy) > +{ > + const struct cix_udphy_cfg *phy_cfgs =3D udphy->cfg; > + int ret; > + > + if (udphy->cur_mode =3D=3D udphy->next_mode) > + return 0; > + > + if ((udphy->cur_mode =3D=3D UDPHY_MODE_USB || udphy->cur_mode =3D=3D UD= PHY_MODE_DP) && > + udphy->next_mode =3D=3D UDPHY_MODE_DP_USB) > + return 0; > + > + if (phy_cfgs->udphy_init) { > + ret =3D phy_cfgs->udphy_init(udphy); > + if (ret) { > + dev_err(udphy->dev, "failed to init udphy\n"); > + return ret; > + } > + } > + > + return 0; > +} > + > +static int cix_usbdp_phy_power_off(struct cix_udphy *udphy) > +{ > + const struct cix_udphy_cfg *phy_cfgs =3D udphy->cfg; > + int ret; > + > + if (phy_cfgs->udphy_exit) { > + ret =3D phy_cfgs->udphy_exit(udphy); > + if (ret) { > + dev_err(udphy->dev, "failed to exit udphy\n"); > + return ret; > + } > + } > + > + udphy->cur_mode =3D UDPHY_MODE_NONE; > + return 0; > +} > + > +static int udphy_dp_phy_power_on(struct phy *phy) > +{ > + struct cix_udphy *udphy =3D phy_get_drvdata(phy); > + int ret =3D 0; > + > + mutex_lock(&udphy->mutex); > + if (!(udphy->next_mode & UDPHY_MODE_DP)) > + goto unlock; > + > + ret =3D cix_usbdp_phy_power_on(udphy); > + if (ret) > + goto unlock; > + > + phy_set_bus_width(phy, udphy_dplane_get(udphy)); > + if (udphy->next_mode =3D=3D UDPHY_MODE_DP) > + udphy->cur_mode =3D UDPHY_MODE_DP; > + else > + udphy->cur_mode |=3D UDPHY_MODE_DP; > + > +unlock: > + mutex_unlock(&udphy->mutex); > + return ret; > +} [Severity: High] Can the mode tracking in cix_usbdp_phy_power_on() and udphy_dp_phy_power_on= () leak theudphy->apb_clk enable count or skip needed hardware re-initializati= on? First, sky1_udphy_init() unconditionally calls sky1_udphy_clk_enable(udphy->apb_clk), whereas sky1_udphy_exit() only calls clk_disable_unprepare(udphy->apb_clk) once when udphy->cur_mode reaches UDPHY_MODE_NONE in cix_usbdp_phy_power_off(). If one child PHY is already active (udphy->cur_mode !=3D UDPHY_MODE_NONE) and udphy->next_mode changes = such that cix_usbdp_phy_power_on() invokes sky1_udphy_init() a second time, udphy->apb_clk is prepared and enabled again without a matching disable. In addition, when udphy->next_mode =3D=3D UDPHY_MODE_DP, udphy_dp_phy_power= _on() overwrites udphy->cur_mode =3D UDPHY_MODE_DP instead of setting the bit with |=3D UDPHY_MODE_DP. If UDPHY_MODE_USB was already set in udphy->cur_mode, t= hat bit is lost and a subsequent cix_u3phy_exit() returns early without powering off the PHY or disabling udphy->apb_clk. Second, cix_usbdp_phy_power_on() returns 0 without calling sky1_udphy_init() when udphy->cur_mode =3D=3D UDPHY_MODE_DP and udphy->next_mode =3D=3D UDPHY_MODE_DP_USB. If the PHY was initialized in 4-lane DP-only mode using sky1_udphy_dp_conf (where PHY_PMA_LANE_MAP is 0x51D9 and no USB3 lane registers are programmed) and then transitions to UDPHY_MODE_DP_USB, calling cix_u3phy_init() skips sky1_udphy_init() and leaves the USB3 lanes unconfigured. Similarly, udphy_orien_sw_set() updates udphy->flip without updating udphy->usbphy_syscon or forcing re-initialization, so if udphy->flip changes while cix_usbdp_phy_power_on() takes one of the early return paths, the syscon orientation bit and PMA lane configuration remain in the previous orientation. [ ... ] > +static int udphy_dp_phy_verify_config(struct cix_udphy *udphy, > + struct phy_configure_opts_dp *dp) > +{ > + int i; > + > + switch (dp->lanes) { > + case 1: > + case 2: > + case 4: > + break; > + default: > + return -EINVAL; > + } [Severity: High] What happens in udphy_dp_phy_verify_config() when a DisplayPort consumer calls phy_configure() with dp->lanes =3D=3D 4 while the PHY is in 2-lane co= mbo mode (UDPHY_MODE_DP_USB), or calls phy_configure() with dp->set_lanes =3D= =3D 0? Because udphy_dp_phy_verify_config() does not check that dp->lanes is within udphy_dplane_get(udphy), passing dp->lanes =3D=3D 4 while in UDPHY_MODE_DP_= USB is accepted and causes udphy_dp_phy_set_rate() and udphy_dp_phy_set_voltages() to overwrite the PMA registers for all 4 lanes, clobbering the 2 lanes assigned to USB3. Also, struct phy_configure_opts_dp gates lane reconfiguration on dp->set_lanes, so callers updating only link rate or voltage levels with dp->set_lanes =3D=3D 0 may leave dp->lanes unset and fail this check with -EINVAL. > + > + /* > + * If changing voltages is required, check swing and pre-emphasis > + * levels, per-lane. > + */ > + if (dp->set_voltages) { > + for (i =3D 0; i < dp->lanes; i++) { > + if (dp->voltage[i] > 3 || dp->pre[i] > 3) > + return -EINVAL; > + > + /* > + * Sum of voltage swing and pre-emphasis levels cannot > + * exceed 3. > + */ > + if (dp->voltage[i] + dp->pre[i] > 3) > + return -EINVAL; > + } > + } > + > + return 0; > +} > + > +static int udphy_dp_phy_set_rate(struct cix_udphy *udphy, > + struct phy_configure_opts_dp *dp) > +{ > + int ret; > + const struct phy_link_cfg *conf =3D NULL; > + > + dev_dbg(udphy->dev, "lane %d, rate %x\n", dp->lanes, dp->link_rate); > + > + regmap_update_bits(udphy->phy_regmap, PHY_PMA_PLL_CTRL, BIT(1), 0x0); > + usleep_range(10, 20); > + > + switch (dp->link_rate) { > + case 0x6: > + conf =3D &link_cfg[0]; > + ret =3D regmap_multi_reg_write(udphy->phy_regmap, sky1_udphy_dp_partia= l_conf, > + ARRAY_SIZE(sky1_udphy_dp_partial_conf)); > + break; > + case 0xa: > + conf =3D &link_cfg[1]; > + ret =3D regmap_multi_reg_write(udphy->phy_regmap, sky1_udphy_dp_partia= l_conf, > + ARRAY_SIZE(sky1_udphy_dp_partial_conf)); > + break; > + case 0x14: > + conf =3D &link_cfg[2]; > + ret =3D regmap_multi_reg_write(udphy->phy_regmap, sky1_udphy_dp_partia= l_conf, > + ARRAY_SIZE(sky1_udphy_dp_partial_conf)); > + break; > + case 0x1e: > + conf =3D &link_cfg[3]; > + ret =3D regmap_multi_reg_write(udphy->phy_regmap, sky1_udphy_dp_8p1_co= nf, > + ARRAY_SIZE(sky1_udphy_dp_8p1_conf)); > + break; > + default: > + return -EINVAL; > + } [Severity: High] Should udphy_dp_phy_set_rate() match dp->link_rate against link rates in Mb= /s (1620, 2700, 5400, 8100) rather than raw DPCD link bandwidth codes (0x6, 0xa, 0x14, 0x1e)? In include/linux/phy/phy-dp.h, struct phy_configure_opts_dp specifies link_rate in Mb/s. Standard DisplayPort controller drivers passing 1620, 2700, 5400, or 8100 Mb/s will hit the default case and fail with -EINVAL. Additionally, because udphy_dp_phy_verify_config() does not validate dp->link_rate before udphy_dp_phy_set_rate() clears BIT(1) in PHY_PMA_PLL_CTRL, returning -EINVAL here (or on a regmap_multi_reg_write() failure) leaves PLL1 disabled in hardware. [ ... ] > +static int udphy_dp_phy_set_voltages(struct cix_udphy *udphy, > + struct phy_configure_opts_dp *dp) > +{ > + u32 index =3D dp->voltage[0] * 4 + dp->pre[0]; > + const struct phy_voltage_conf *cfg =3D volt_cfg; [Severity: High] Why does udphy_dp_phy_set_voltages() compute index only from dp->voltage[0] and dp->pre[0] and apply it to all lanes? In udphy_dp_phy_verify_config(), dp->voltage[i] and dp->pre[i] are validated for each lane i up to dp->lanes, but udphy_dp_phy_set_voltages() ignores dp->voltage[1..3] and dp->pre[1..3] and programs lane 0's swing and pre-emphasis settings into every active lane in the 2-lane and 4-lane cases. [ ... ] > +static int udphy_dp_phy_configure(struct phy *phy, > + union phy_configure_opts *opts) > +{ > + struct cix_udphy *udphy =3D phy_get_drvdata(phy); > + int ret; > + > + mutex_lock(&udphy->mutex); > + ret =3D udphy_dp_phy_verify_config(udphy, &opts->dp); > + if (ret) > + goto unlock; > + > + if (opts->dp.set_rate) { > + ret =3D udphy_dp_phy_set_rate(udphy, &opts->dp); > + if (ret) { > + dev_err(udphy->dev, "failed to set DP link rate\n"); > + goto unlock; > + } > + } > + > + if (opts->dp.set_voltages) { > + ret =3D udphy_dp_phy_set_voltages(udphy, &opts->dp); > + if (ret) { > + dev_err(udphy->dev, "dp_phy_set_voltages failed\n"); > + goto unlock; > + } > + } > + mutex_unlock(&udphy->mutex); > + return 0; > + > +unlock: > + mutex_unlock(&udphy->mutex); > + return ret; > +} [Severity: High] Can udphy_dp_phy_configure() access PHY MMIO registers while udphy->apb_clk is disabled and udphy->preset is asserted? In cix_udphy_probe() and sky1_udphy_exit(), udphy->reset and udphy->preset are asserted and udphy->apb_clk is disabled. If udphy_dp_phy_power_on() is called when UDPHY_MODE_DP is not set in udphy->next_mode (for example, when usbdp_typec_mux_set() sets udphy->next_mode =3D UDPHY_MODE_USB for TYPEC_STATE_SAFE or USB-only mode), udphy_dp_phy_power_on() returns 0 witho= ut enabling udphy->apb_clk or deasserting udphy->preset. If the DisplayPort controller then calls phy_configure() (or calls phy_configure() before phy_power_on()), udphy_dp_phy_configure() does not check whether udphy->cur_mode & UDPHY_MODE_DP is active before accessing udphy->phy_regmap in udphy_dp_phy_set_rate() and udphy_dp_phy_set_voltages(= ). [ ... ] > +static int cix_u3phy_set_mode(struct phy *phy, enum phy_mode mode, int s= ubmode) > +{ > + if (mode =3D=3D PHY_MODE_INVALID) > + return cix_u3phy_exit(phy); > + > + return cix_u3phy_init(phy); > +} > + > +static const struct phy_ops cix_u3phy_ops =3D { > + .set_mode =3D cix_u3phy_set_mode, > + .exit =3D cix_u3phy_exit, > + .owner =3D THIS_MODULE, > +}; [Severity: High] Is it intentional that cix_u3phy_ops defines .exit =3D cix_u3phy_exit witho= ut .init, .power_on, or .power_off, and instead wires cix_u3phy_init() and cix_u3phy_exit() into .set_mode? Standard USB controller drivers (such as cdns3, dwc3, and xhci-plat) manage the PHY lifecycle through phy_init(), phy_power_on(), phy_power_off(), and phy_exit(). During system resume (for example in cdns3_controller_resume()), calling phy_exit() followed by phy_init() and phy_power_on() without calling phy_set_mode() will run cix_u3phy_exit() and leave the USB3 PHY powered off because .init and .power_on are NULL. [ ... ] > +static void udphy_set_default_mode(struct cix_udphy *udphy) > +{ > + udphy->cur_mode =3D UDPHY_MODE_NONE; > +} > + > +static int cix_udphy_probe(struct platform_device *pdev) > +{ [ ... ] > + ret =3D device_property_read_u8(dev, "cix,default-conf", &udphy->next_m= ode); > + if (ret) > + udphy->next_mode =3D UDPHY_MODE_DP_USB; > + > + reset_control_assert(udphy->reset); > + reset_control_assert(udphy->preset); [ ... ] > + udphy_set_default_mode(udphy); [Severity: Medium] The commit message states: The bootloader may hand over the port already initialized; in that case the first power_on calls skip the re-initialization. However, cix_udphy_probe() unconditionally asserts both udphy->reset and udphy->preset, and udphy_set_default_mode() sets udphy->cur_mode =3D UDPHY_MODE_NONE, so the first call to cix_usbdp_phy_power_on() will always re-initialize the PHY. Does the probe path or commit message need to be updated to match the intended bootloader handover behavior? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102082112.2306= 326-1-gary.yang@cixtech.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD456606A32F for ; Mon, 2 Nov 2026 08:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=JAb8iYm3; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LIUlEg6q DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=J2LqAXSlTQ9JhiR61Zzz+Cjh5aUM4N9mwRKeACsJXeQ=; b=JAb8iYm3W4IZ6ficJdFYFysDUi 1Yo/kvSq9n2lLzSPsNefmZLzihTtMe09x8j2wRgH/LqIhl9KcJv/J+qvgmK+w2HDLo8bzEfU5G8Dc Kp5oYX31P9byDVFlYCybEBtXj/gobkmszi5NEb5nkFkiVmm2wItgJLuHmeew/4XX47UhY6q4ECN0T WEXiuGY/5Kq6Wv+k+qOqOEv5buopxYeD5CpLKVGrsn7ss5vrXaLnMSubcjuOpnxaweDhASsg8ueof /VnI9nBDV7PeApSm2kT1co4GbPtvRubJkyTzDGYvfktO6aqqNkxUkGzTvNx9X5Bipe2CYIxiPXKS7 aHtira6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNnZF-0000000FtF7-1G27; Mon, 02 Nov 2026 08:39:01 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNnZD-0000000FtF0-3Q8u for linux-phy@lists.infradead.org; Mon, 02 Nov 2026 08:38:59 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7E96943823; Mon, 2 Nov 2026 08:38:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04F8E1F00A18; Mon, 2 Nov 2026 08:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793608739; bh=+ujXPh5DWImCZX0JZvrqR6XdNCQ9pQMh1AAs5cuycDw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=LIUlEg6qDTYcydeff3YbsDqdkgXDQNAYrO2VdNd68YqcYI76REarYWvHpdKAd7zEu RUW1CzLuol4ymEUOkmAPONi9kywNAdix6xuHeKyfvjcY5oFfn3NciXMArVG41hLF4U 6BbZzFnJjFdDXZ2UmjVctL6uqNpQC7vT6OLz6HSOTrtaaZwxrU2l43m6CrENlzOjPV WWNTEqFK2J+tXVkvmBaOj0HTNBw/HJw7zGotsV6rMh0+AGCWODJZSca2NojR9rgB/D MID6RjyFxgstbSuXZ5PZrOluop7PH4wTyBffQscrDYY3JdU1TKi8mWgbxhsWOmJAMD LO4DPi40v6UgQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] phy: cix: add Sky1 USB/DP combo PHY driver To: "Gary Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261102082112.2306326-3-gary.yang@cixtech.com> References: <20261102082112.2306326-1-gary.yang@cixtech.com> <20261102082112.2306326-3-gary.yang@cixtech.com> Date: Mon, 02 Nov 2026 08:38:58 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIHBoeTogY2l4OiB1ZHBo eV9kcF9waHlfc2V0X3JhdGUoKSBjaGVja3MgRFBDRCBjb2RlcyBpbnN0ZWFkIG9mIE1iL3MgbGlu a19yYXRlCi0gW0hpZ2hdIHBoeTogY2l4OiB1ZHBoeV9kcF9waHlfc2V0X3ZvbHRhZ2VzKCkgYXBw bGllcyBsYW5lIDAgc2V0dGluZ3MgdG8gYWxsIGxhbmVzCi0gW0hpZ2hdIHBoeTogY2l4OiBtb2Rl IHRyYWNraW5nIGluIGNpeF91c2JkcF9waHlfcG93ZXJfb24oKSBsZWFrcyBjbGsgYW5kIHNraXBz IGluaXQKLSBbSGlnaF0gcGh5OiBjaXg6IHVkcGh5X2RwX3BoeV9jb25maWd1cmUoKSBhY2Nlc3Nl cyBNTUlPIHdoZW4gRFAgUEhZIGlzIHVucG93ZXJlZAotIFtIaWdoXSBwaHk6IGNpeDogdWRwaHlf ZHBfcGh5X3ZlcmlmeV9jb25maWcoKSBtaXNoYW5kbGVzIGRwLT5sYW5lcyBhbmQgZHAtPnNldF9s YW5lcwotIFtIaWdoXSBwaHk6IGNpeDogY2l4X3UzcGh5X29wcyBvbWl0cyAuaW5pdC8ucG93ZXJf b24gYW5kIG1pc3VzZXMgLnNldF9tb2RlCi0gW01lZGl1bV0gcGh5OiBjaXg6IGNpeF91ZHBoeV9w cm9iZSgpIHJlc2V0cyBQSFkgZGVzcGl0ZSBib290bG9hZGVyIGhhbmRvdmVyIGNsYWltCi0tCgpj b21taXQgZDRlMGNlNDU3M2IwYTg0NmZiMjRhZjNkNmM3NDVjNzc5OGQ4ZjdhOQpBdXRob3I6IEdh cnkgWWFuZyA8Z2FyeS55YW5nQGNpeHRlY2guY29tPgoKcGh5OiBjaXg6IGFkZCBTa3kxIFVTQi9E UCBjb21ibyBQSFkgZHJpdmVyCgpUaGlzIGNvbW1pdCBhZGRzIGEgZHJpdmVyIGZvciB0aGUgQ0lY IFNreTEgVVNCL0RQIGNvbWJvIFBIWSwgZXhwb3NpbmcKc2VwYXJhdGUgY2hpbGQgUEhZcyBmb3Ig dGhlIFN1cGVyU3BlZWRQbHVzIFVTQiBsYW5lIGFuZCBEaXNwbGF5UG9ydCBsYW5lCndoaWxlIHJl Z2lzdGVyaW5nIGEgVHlwZS1DIG9yaWVudGF0aW9uIHN3aXRjaCBhbmQgbW9kZSBtdXguCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9jaXgvcGh5LWNpeC11c2JkcC5jIGIvZHJpdmVycy9waHkv Y2l4L3BoeS1jaXgtdXNiZHAuYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAw MDAwMDAwMC4uZDU5NmU4OWM3NGY3Ngo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL3Bo eS9jaXgvcGh5LWNpeC11c2JkcC5jCgpbIC4uLiBdCgo+ICtzdGF0aWMgaW50IHNreTFfdWRwaHlf ZXhpdChzdHJ1Y3QgY2l4X3VkcGh5ICp1ZHBoeSkKPiArewo+ICsJcmVzZXRfY29udHJvbF9hc3Nl cnQodWRwaHktPnJlc2V0KTsKPiArCXJlc2V0X2NvbnRyb2xfYXNzZXJ0KHVkcGh5LT5wcmVzZXQp Owo+ICsJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHVkcGh5LT5hcGJfY2xrKTsKPiArCXJldHVybiAw Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHNreTFfdWRwaHlfaW5pdChzdHJ1Y3QgY2l4X3VkcGh5 ICp1ZHBoeSkKPiArewo+ICsJaW50IHJldDsKPiArCXUzMiB2YWx1ZTsKPiArCWNvbnN0IHN0cnVj dCBjaXhfdWRwaHlfY29uX2RpciAqY29uX2RpciA9ICZ1ZHBoeS0+Y2ZnLT5jb25fZGlyW3VkcGh5 LT5pZF07Cj4gKwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKHVkcGh5LT51c2JwaHlfc3lzY29uLCBj b25fZGlyLT5vZmZzZXQsCj4gKwkJCSAgIEdFTk1BU0soY29uX2Rpci0+Yml0LCBjb25fZGlyLT5i aXQpLAo+ICsJCQkgICB1ZHBoeS0+ZmxpcCA8PCBjb25fZGlyLT5iaXQpOwo+ICsKPiArCXVzbGVl cF9yYW5nZSgxMCwgMjApOwo+ICsKPiArCXJlZ21hcF9yZWFkKHVkcGh5LT51c2JwaHlfc3lzY29u LCBjb25fZGlyLT5vZmZzZXQsICZ2YWx1ZSk7Cj4gKwo+ICsJLyogdXNiIHJjc3UgcmVzZXQgaXMg ZGVmYXVsdCBkZWFzc2VydCAqLwo+ICsJcmVzZXRfY29udHJvbF9hc3NlcnQodWRwaHktPnJlc2V0 KTsKPiArCXJlc2V0X2NvbnRyb2xfYXNzZXJ0KHVkcGh5LT5wcmVzZXQpOwo+ICsKPiArCXJldCA9 IHNreTFfdWRwaHlfY2xrX2VuYWJsZSh1ZHBoeS0+YXBiX2Nsayk7Cj4gKwlpZiAocmV0KSB7Cj4g KwkJZGV2X2Vycih1ZHBoeS0+ZGV2LCAiRmFpbGVkIHRvIHByZXBhcmVfZW5hYmxlIHVkcGh5IGFw YiBjbG9ja1xuIik7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KClsgLi4uIF0KCj4gK3N0YXRpYyBp bnQgdWRwaHlfb3JpZW5fc3dfc2V0KHN0cnVjdCB0eXBlY19zd2l0Y2hfZGV2ICpzdywKPiArCQkJ ICAgICAgZW51bSB0eXBlY19vcmllbnRhdGlvbiBvcmllbikKPiArewo+ICsJc3RydWN0IGNpeF91 ZHBoeSAqdWRwaHkgPSB0eXBlY19zd2l0Y2hfZ2V0X2RydmRhdGEoc3cpOwo+ICsKPiArCW11dGV4 X2xvY2soJnVkcGh5LT5tdXRleCk7Cj4gKwo+ICsJaWYgKG9yaWVuID09IFRZUEVDX09SSUVOVEFU SU9OX05PTkUpCj4gKwkJZ290byB1bmxvY2tfcmV0Owo+ICsKPiArCXVkcGh5LT5mbGlwID0gKG9y aWVuID09IFRZUEVDX09SSUVOVEFUSU9OX1JFVkVSU0UpID8gdHJ1ZSA6IGZhbHNlOwo+ICsKPiAr dW5sb2NrX3JldDoKPiArCW11dGV4X3VubG9jaygmdWRwaHktPm11dGV4KTsKPiArCXJldHVybiAw Owo+ICt9CgpbIC4uLiBdCgo+ICtzdGF0aWMgaW50IGNpeF91c2JkcF9waHlfcG93ZXJfb24oc3Ry dWN0IGNpeF91ZHBoeSAqdWRwaHkpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBjaXhfdWRwaHlfY2Zn ICpwaHlfY2ZncyA9IHVkcGh5LT5jZmc7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWlmICh1ZHBoeS0+ Y3VyX21vZGUgPT0gdWRwaHktPm5leHRfbW9kZSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpZiAo KHVkcGh5LT5jdXJfbW9kZSA9PSBVRFBIWV9NT0RFX1VTQiB8fCB1ZHBoeS0+Y3VyX21vZGUgPT0g VURQSFlfTU9ERV9EUCkgJiYKPiArCSAgICB1ZHBoeS0+bmV4dF9tb2RlID09IFVEUEhZX01PREVf RFBfVVNCKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWlmIChwaHlfY2Zncy0+dWRwaHlfaW5pdCkg ewo+ICsJCXJldCA9IHBoeV9jZmdzLT51ZHBoeV9pbml0KHVkcGh5KTsKPiArCQlpZiAocmV0KSB7 Cj4gKwkJCWRldl9lcnIodWRwaHktPmRldiwgImZhaWxlZCB0byBpbml0IHVkcGh5XG4iKTsKPiAr CQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4g K3N0YXRpYyBpbnQgY2l4X3VzYmRwX3BoeV9wb3dlcl9vZmYoc3RydWN0IGNpeF91ZHBoeSAqdWRw aHkpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBjaXhfdWRwaHlfY2ZnICpwaHlfY2ZncyA9IHVkcGh5 LT5jZmc7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWlmIChwaHlfY2Zncy0+dWRwaHlfZXhpdCkgewo+ ICsJCXJldCA9IHBoeV9jZmdzLT51ZHBoeV9leGl0KHVkcGh5KTsKPiArCQlpZiAocmV0KSB7Cj4g KwkJCWRldl9lcnIodWRwaHktPmRldiwgImZhaWxlZCB0byBleGl0IHVkcGh5XG4iKTsKPiArCQkJ cmV0dXJuIHJldDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJdWRwaHktPmN1cl9tb2RlID0gVURQSFlf TU9ERV9OT05FOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgdWRwaHlfZHBf cGh5X3Bvd2VyX29uKHN0cnVjdCBwaHkgKnBoeSkKPiArewo+ICsJc3RydWN0IGNpeF91ZHBoeSAq dWRwaHkgPSBwaHlfZ2V0X2RydmRhdGEocGh5KTsKPiArCWludCByZXQgPSAwOwo+ICsKPiArCW11 dGV4X2xvY2soJnVkcGh5LT5tdXRleCk7Cj4gKwlpZiAoISh1ZHBoeS0+bmV4dF9tb2RlICYgVURQ SFlfTU9ERV9EUCkpCj4gKwkJZ290byB1bmxvY2s7Cj4gKwo+ICsJcmV0ID0gY2l4X3VzYmRwX3Bo eV9wb3dlcl9vbih1ZHBoeSk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gdW5sb2NrOwo+ICsKPiAr CXBoeV9zZXRfYnVzX3dpZHRoKHBoeSwgdWRwaHlfZHBsYW5lX2dldCh1ZHBoeSkpOwo+ICsJaWYg KHVkcGh5LT5uZXh0X21vZGUgPT0gVURQSFlfTU9ERV9EUCkKPiArCQl1ZHBoeS0+Y3VyX21vZGUg PSBVRFBIWV9NT0RFX0RQOwo+ICsJZWxzZQo+ICsJCXVkcGh5LT5jdXJfbW9kZSB8PSBVRFBIWV9N T0RFX0RQOwo+ICsKPiArdW5sb2NrOgo+ICsJbXV0ZXhfdW5sb2NrKCZ1ZHBoeS0+bXV0ZXgpOwo+ ICsJcmV0dXJuIHJldDsKPiArfQoKW1NldmVyaXR5OiBIaWdoXQpDYW4gdGhlIG1vZGUgdHJhY2tp bmcgaW4gY2l4X3VzYmRwX3BoeV9wb3dlcl9vbigpIGFuZCB1ZHBoeV9kcF9waHlfcG93ZXJfb24o KQpsZWFrIHRoZXVkcGh5LT5hcGJfY2xrIGVuYWJsZSBjb3VudCBvciBza2lwIG5lZWRlZCBoYXJk d2FyZSByZS1pbml0aWFsaXphdGlvbj8KCkZpcnN0LCBza3kxX3VkcGh5X2luaXQoKSB1bmNvbmRp dGlvbmFsbHkgY2FsbHMKc2t5MV91ZHBoeV9jbGtfZW5hYmxlKHVkcGh5LT5hcGJfY2xrKSwgd2hl cmVhcyBza3kxX3VkcGh5X2V4aXQoKSBvbmx5IGNhbGxzCmNsa19kaXNhYmxlX3VucHJlcGFyZSh1 ZHBoeS0+YXBiX2Nsaykgb25jZSB3aGVuIHVkcGh5LT5jdXJfbW9kZSByZWFjaGVzClVEUEhZX01P REVfTk9ORSBpbiBjaXhfdXNiZHBfcGh5X3Bvd2VyX29mZigpLiBJZiBvbmUgY2hpbGQgUEhZIGlz IGFscmVhZHkKYWN0aXZlICh1ZHBoeS0+Y3VyX21vZGUgIT0gVURQSFlfTU9ERV9OT05FKSBhbmQg dWRwaHktPm5leHRfbW9kZSBjaGFuZ2VzIHN1Y2gKdGhhdCBjaXhfdXNiZHBfcGh5X3Bvd2VyX29u KCkgaW52b2tlcyBza3kxX3VkcGh5X2luaXQoKSBhIHNlY29uZCB0aW1lLAp1ZHBoeS0+YXBiX2Ns ayBpcyBwcmVwYXJlZCBhbmQgZW5hYmxlZCBhZ2FpbiB3aXRob3V0IGEgbWF0Y2hpbmcgZGlzYWJs ZS4KCkluIGFkZGl0aW9uLCB3aGVuIHVkcGh5LT5uZXh0X21vZGUgPT0gVURQSFlfTU9ERV9EUCwg dWRwaHlfZHBfcGh5X3Bvd2VyX29uKCkKb3ZlcndyaXRlcyB1ZHBoeS0+Y3VyX21vZGUgPSBVRFBI WV9NT0RFX0RQIGluc3RlYWQgb2Ygc2V0dGluZyB0aGUgYml0IHdpdGgKfD0gVURQSFlfTU9ERV9E UC4gSWYgVURQSFlfTU9ERV9VU0Igd2FzIGFscmVhZHkgc2V0IGluIHVkcGh5LT5jdXJfbW9kZSwg dGhhdApiaXQgaXMgbG9zdCBhbmQgYSBzdWJzZXF1ZW50IGNpeF91M3BoeV9leGl0KCkgcmV0dXJu cyBlYXJseSB3aXRob3V0IHBvd2VyaW5nCm9mZiB0aGUgUEhZIG9yIGRpc2FibGluZyB1ZHBoeS0+ YXBiX2Nsay4KClNlY29uZCwgY2l4X3VzYmRwX3BoeV9wb3dlcl9vbigpIHJldHVybnMgMCB3aXRo b3V0IGNhbGxpbmcgc2t5MV91ZHBoeV9pbml0KCkKd2hlbiB1ZHBoeS0+Y3VyX21vZGUgPT0gVURQ SFlfTU9ERV9EUCBhbmQgdWRwaHktPm5leHRfbW9kZSA9PQpVRFBIWV9NT0RFX0RQX1VTQi4gSWYg dGhlIFBIWSB3YXMgaW5pdGlhbGl6ZWQgaW4gNC1sYW5lIERQLW9ubHkgbW9kZSB1c2luZwpza3kx X3VkcGh5X2RwX2NvbmYgKHdoZXJlIFBIWV9QTUFfTEFORV9NQVAgaXMgMHg1MUQ5IGFuZCBubyBV U0IzIGxhbmUKcmVnaXN0ZXJzIGFyZSBwcm9ncmFtbWVkKSBhbmQgdGhlbiB0cmFuc2l0aW9ucyB0 byBVRFBIWV9NT0RFX0RQX1VTQiwgY2FsbGluZwpjaXhfdTNwaHlfaW5pdCgpIHNraXBzIHNreTFf dWRwaHlfaW5pdCgpIGFuZCBsZWF2ZXMgdGhlIFVTQjMgbGFuZXMKdW5jb25maWd1cmVkLgoKU2lt aWxhcmx5LCB1ZHBoeV9vcmllbl9zd19zZXQoKSB1cGRhdGVzIHVkcGh5LT5mbGlwIHdpdGhvdXQg dXBkYXRpbmcKdWRwaHktPnVzYnBoeV9zeXNjb24gb3IgZm9yY2luZyByZS1pbml0aWFsaXphdGlv biwgc28gaWYgdWRwaHktPmZsaXAgY2hhbmdlcwp3aGlsZSBjaXhfdXNiZHBfcGh5X3Bvd2VyX29u KCkgdGFrZXMgb25lIG9mIHRoZSBlYXJseSByZXR1cm4gcGF0aHMsIHRoZQpzeXNjb24gb3JpZW50 YXRpb24gYml0IGFuZCBQTUEgbGFuZSBjb25maWd1cmF0aW9uIHJlbWFpbiBpbiB0aGUgcHJldmlv dXMKb3JpZW50YXRpb24uCgpbIC4uLiBdCgo+ICtzdGF0aWMgaW50IHVkcGh5X2RwX3BoeV92ZXJp ZnlfY29uZmlnKHN0cnVjdCBjaXhfdWRwaHkgKnVkcGh5LAo+ICsJCQkJICAgICAgc3RydWN0IHBo eV9jb25maWd1cmVfb3B0c19kcCAqZHApCj4gK3sKPiArCWludCBpOwo+ICsKPiArCXN3aXRjaCAo ZHAtPmxhbmVzKSB7Cj4gKwljYXNlIDE6Cj4gKwljYXNlIDI6Cj4gKwljYXNlIDQ6Cj4gKwkJYnJl YWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQoKW1NldmVyaXR5OiBI aWdoXQpXaGF0IGhhcHBlbnMgaW4gdWRwaHlfZHBfcGh5X3ZlcmlmeV9jb25maWcoKSB3aGVuIGEg RGlzcGxheVBvcnQgY29uc3VtZXIKY2FsbHMgcGh5X2NvbmZpZ3VyZSgpIHdpdGggZHAtPmxhbmVz ID09IDQgd2hpbGUgdGhlIFBIWSBpcyBpbiAyLWxhbmUgY29tYm8KbW9kZSAoVURQSFlfTU9ERV9E UF9VU0IpLCBvciBjYWxscyBwaHlfY29uZmlndXJlKCkgd2l0aCBkcC0+c2V0X2xhbmVzID09IDA/ CgpCZWNhdXNlIHVkcGh5X2RwX3BoeV92ZXJpZnlfY29uZmlnKCkgZG9lcyBub3QgY2hlY2sgdGhh dCBkcC0+bGFuZXMgaXMgd2l0aGluCnVkcGh5X2RwbGFuZV9nZXQodWRwaHkpLCBwYXNzaW5nIGRw LT5sYW5lcyA9PSA0IHdoaWxlIGluIFVEUEhZX01PREVfRFBfVVNCCmlzIGFjY2VwdGVkIGFuZCBj YXVzZXMgdWRwaHlfZHBfcGh5X3NldF9yYXRlKCkgYW5kCnVkcGh5X2RwX3BoeV9zZXRfdm9sdGFn ZXMoKSB0byBvdmVyd3JpdGUgdGhlIFBNQSByZWdpc3RlcnMgZm9yIGFsbCA0IGxhbmVzLApjbG9i YmVyaW5nIHRoZSAyIGxhbmVzIGFzc2lnbmVkIHRvIFVTQjMuCgpBbHNvLCBzdHJ1Y3QgcGh5X2Nv bmZpZ3VyZV9vcHRzX2RwIGdhdGVzIGxhbmUgcmVjb25maWd1cmF0aW9uIG9uCmRwLT5zZXRfbGFu ZXMsIHNvIGNhbGxlcnMgdXBkYXRpbmcgb25seSBsaW5rIHJhdGUgb3Igdm9sdGFnZSBsZXZlbHMg d2l0aApkcC0+c2V0X2xhbmVzID09IDAgbWF5IGxlYXZlIGRwLT5sYW5lcyB1bnNldCBhbmQgZmFp bCB0aGlzIGNoZWNrIHdpdGgKLUVJTlZBTC4KCj4gKwo+ICsJLyoKPiArCSAqIElmIGNoYW5naW5n IHZvbHRhZ2VzIGlzIHJlcXVpcmVkLCBjaGVjayBzd2luZyBhbmQgcHJlLWVtcGhhc2lzCj4gKwkg KiBsZXZlbHMsIHBlci1sYW5lLgo+ICsJICovCj4gKwlpZiAoZHAtPnNldF92b2x0YWdlcykgewo+ ICsJCWZvciAoaSA9IDA7IGkgPCBkcC0+bGFuZXM7IGkrKykgewo+ICsJCQlpZiAoZHAtPnZvbHRh Z2VbaV0gPiAzIHx8IGRwLT5wcmVbaV0gPiAzKQo+ICsJCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ ICsJCQkvKgo+ICsJCQkgKiBTdW0gb2Ygdm9sdGFnZSBzd2luZyBhbmQgcHJlLWVtcGhhc2lzIGxl dmVscyBjYW5ub3QKPiArCQkJICogZXhjZWVkIDMuCj4gKwkJCSAqLwo+ICsJCQlpZiAoZHAtPnZv bHRhZ2VbaV0gKyBkcC0+cHJlW2ldID4gMykKPiArCQkJCXJldHVybiAtRUlOVkFMOwo+ICsJCX0K PiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCB1ZHBoeV9kcF9w aHlfc2V0X3JhdGUoc3RydWN0IGNpeF91ZHBoeSAqdWRwaHksCj4gKwkJCQkgc3RydWN0IHBoeV9j b25maWd1cmVfb3B0c19kcCAqZHApCj4gK3sKPiArCWludCByZXQ7Cj4gKwljb25zdCBzdHJ1Y3Qg cGh5X2xpbmtfY2ZnICpjb25mID0gTlVMTDsKPiArCj4gKwlkZXZfZGJnKHVkcGh5LT5kZXYsICJs YW5lICVkLCByYXRlICV4XG4iLCBkcC0+bGFuZXMsIGRwLT5saW5rX3JhdGUpOwo+ICsKPiArCXJl Z21hcF91cGRhdGVfYml0cyh1ZHBoeS0+cGh5X3JlZ21hcCwgUEhZX1BNQV9QTExfQ1RSTCwgQklU KDEpLCAweDApOwo+ICsJdXNsZWVwX3JhbmdlKDEwLCAyMCk7Cj4gKwo+ICsJc3dpdGNoIChkcC0+ bGlua19yYXRlKSB7Cj4gKwljYXNlIDB4NjoKPiArCQljb25mID0gJmxpbmtfY2ZnWzBdOwo+ICsJ CXJldCA9IHJlZ21hcF9tdWx0aV9yZWdfd3JpdGUodWRwaHktPnBoeV9yZWdtYXAsIHNreTFfdWRw aHlfZHBfcGFydGlhbF9jb25mLAo+ICsJCQkJCSAgICAgQVJSQVlfU0laRShza3kxX3VkcGh5X2Rw X3BhcnRpYWxfY29uZikpOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAweGE6Cj4gKwkJY29uZiA9ICZs aW5rX2NmZ1sxXTsKPiArCQlyZXQgPSByZWdtYXBfbXVsdGlfcmVnX3dyaXRlKHVkcGh5LT5waHlf cmVnbWFwLCBza3kxX3VkcGh5X2RwX3BhcnRpYWxfY29uZiwKPiArCQkJCQkgICAgIEFSUkFZX1NJ WkUoc2t5MV91ZHBoeV9kcF9wYXJ0aWFsX2NvbmYpKTsKPiArCQlicmVhazsKPiArCWNhc2UgMHgx NDoKPiArCQljb25mID0gJmxpbmtfY2ZnWzJdOwo+ICsJCXJldCA9IHJlZ21hcF9tdWx0aV9yZWdf d3JpdGUodWRwaHktPnBoeV9yZWdtYXAsIHNreTFfdWRwaHlfZHBfcGFydGlhbF9jb25mLAo+ICsJ CQkJCSAgICAgQVJSQVlfU0laRShza3kxX3VkcGh5X2RwX3BhcnRpYWxfY29uZikpOwo+ICsJCWJy ZWFrOwo+ICsJY2FzZSAweDFlOgo+ICsJCWNvbmYgPSAmbGlua19jZmdbM107Cj4gKwkJcmV0ID0g cmVnbWFwX211bHRpX3JlZ193cml0ZSh1ZHBoeS0+cGh5X3JlZ21hcCwgc2t5MV91ZHBoeV9kcF84 cDFfY29uZiwKPiArCQkJCQkgICAgIEFSUkFZX1NJWkUoc2t5MV91ZHBoeV9kcF84cDFfY29uZikp Owo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KCltT ZXZlcml0eTogSGlnaF0KU2hvdWxkIHVkcGh5X2RwX3BoeV9zZXRfcmF0ZSgpIG1hdGNoIGRwLT5s aW5rX3JhdGUgYWdhaW5zdCBsaW5rIHJhdGVzIGluIE1iL3MKKDE2MjAsIDI3MDAsIDU0MDAsIDgx MDApIHJhdGhlciB0aGFuIHJhdyBEUENEIGxpbmsgYmFuZHdpZHRoIGNvZGVzICgweDYsCjB4YSwg MHgxNCwgMHgxZSk/CgpJbiBpbmNsdWRlL2xpbnV4L3BoeS9waHktZHAuaCwgc3RydWN0IHBoeV9j b25maWd1cmVfb3B0c19kcCBzcGVjaWZpZXMKbGlua19yYXRlIGluIE1iL3MuIFN0YW5kYXJkIERp c3BsYXlQb3J0IGNvbnRyb2xsZXIgZHJpdmVycyBwYXNzaW5nIDE2MjAsCjI3MDAsIDU0MDAsIG9y IDgxMDAgTWIvcyB3aWxsIGhpdCB0aGUgZGVmYXVsdCBjYXNlIGFuZCBmYWlsIHdpdGggLUVJTlZB TC4KCkFkZGl0aW9uYWxseSwgYmVjYXVzZSB1ZHBoeV9kcF9waHlfdmVyaWZ5X2NvbmZpZygpIGRv ZXMgbm90IHZhbGlkYXRlCmRwLT5saW5rX3JhdGUgYmVmb3JlIHVkcGh5X2RwX3BoeV9zZXRfcmF0 ZSgpIGNsZWFycyBCSVQoMSkgaW4KUEhZX1BNQV9QTExfQ1RSTCwgcmV0dXJuaW5nIC1FSU5WQUwg aGVyZSAob3Igb24gYSByZWdtYXBfbXVsdGlfcmVnX3dyaXRlKCkKZmFpbHVyZSkgbGVhdmVzIFBM TDEgZGlzYWJsZWQgaW4gaGFyZHdhcmUuCgpbIC4uLiBdCgo+ICtzdGF0aWMgaW50IHVkcGh5X2Rw X3BoeV9zZXRfdm9sdGFnZXMoc3RydWN0IGNpeF91ZHBoeSAqdWRwaHksCj4gKwkJCQkgICAgIHN0 cnVjdCBwaHlfY29uZmlndXJlX29wdHNfZHAgKmRwKQo+ICt7Cj4gKwl1MzIgaW5kZXggPSBkcC0+ dm9sdGFnZVswXSAqIDQgKyBkcC0+cHJlWzBdOwo+ICsJY29uc3Qgc3RydWN0IHBoeV92b2x0YWdl X2NvbmYgKmNmZyA9IHZvbHRfY2ZnOwoKW1NldmVyaXR5OiBIaWdoXQpXaHkgZG9lcyB1ZHBoeV9k cF9waHlfc2V0X3ZvbHRhZ2VzKCkgY29tcHV0ZSBpbmRleCBvbmx5IGZyb20gZHAtPnZvbHRhZ2Vb MF0KYW5kIGRwLT5wcmVbMF0gYW5kIGFwcGx5IGl0IHRvIGFsbCBsYW5lcz8KCkluIHVkcGh5X2Rw X3BoeV92ZXJpZnlfY29uZmlnKCksIGRwLT52b2x0YWdlW2ldIGFuZCBkcC0+cHJlW2ldIGFyZSB2 YWxpZGF0ZWQKZm9yIGVhY2ggbGFuZSBpIHVwIHRvIGRwLT5sYW5lcywgYnV0IHVkcGh5X2RwX3Bo eV9zZXRfdm9sdGFnZXMoKSBpZ25vcmVzCmRwLT52b2x0YWdlWzEuLjNdIGFuZCBkcC0+cHJlWzEu LjNdIGFuZCBwcm9ncmFtcyBsYW5lIDAncyBzd2luZyBhbmQKcHJlLWVtcGhhc2lzIHNldHRpbmdz IGludG8gZXZlcnkgYWN0aXZlIGxhbmUgaW4gdGhlIDItbGFuZSBhbmQgNC1sYW5lIGNhc2VzLgoK WyAuLi4gXQoKPiArc3RhdGljIGludCB1ZHBoeV9kcF9waHlfY29uZmlndXJlKHN0cnVjdCBwaHkg KnBoeSwKPiArCQkJCSAgdW5pb24gcGh5X2NvbmZpZ3VyZV9vcHRzICpvcHRzKQo+ICt7Cj4gKwlz dHJ1Y3QgY2l4X3VkcGh5ICp1ZHBoeSA9IHBoeV9nZXRfZHJ2ZGF0YShwaHkpOwo+ICsJaW50IHJl dDsKPiArCj4gKwltdXRleF9sb2NrKCZ1ZHBoeS0+bXV0ZXgpOwo+ICsJcmV0ID0gdWRwaHlfZHBf cGh5X3ZlcmlmeV9jb25maWcodWRwaHksICZvcHRzLT5kcCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdv dG8gdW5sb2NrOwo+ICsKPiArCWlmIChvcHRzLT5kcC5zZXRfcmF0ZSkgewo+ICsJCXJldCA9IHVk cGh5X2RwX3BoeV9zZXRfcmF0ZSh1ZHBoeSwgJm9wdHMtPmRwKTsKPiArCQlpZiAocmV0KSB7Cj4g KwkJCWRldl9lcnIodWRwaHktPmRldiwgImZhaWxlZCB0byBzZXQgRFAgbGluayByYXRlXG4iKTsK PiArCQkJZ290byB1bmxvY2s7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlmIChvcHRzLT5kcC5zZXRf dm9sdGFnZXMpIHsKPiArCQlyZXQgPSB1ZHBoeV9kcF9waHlfc2V0X3ZvbHRhZ2VzKHVkcGh5LCAm b3B0cy0+ZHApOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2Vycih1ZHBoeS0+ZGV2LCAiZHBf cGh5X3NldF92b2x0YWdlcyBmYWlsZWRcbiIpOwo+ICsJCQlnb3RvIHVubG9jazsKPiArCQl9Cj4g Kwl9Cj4gKwltdXRleF91bmxvY2soJnVkcGh5LT5tdXRleCk7Cj4gKwlyZXR1cm4gMDsKPiArCj4g K3VubG9jazoKPiArCW11dGV4X3VubG9jaygmdWRwaHktPm11dGV4KTsKPiArCXJldHVybiByZXQ7 Cj4gK30KCltTZXZlcml0eTogSGlnaF0KQ2FuIHVkcGh5X2RwX3BoeV9jb25maWd1cmUoKSBhY2Nl c3MgUEhZIE1NSU8gcmVnaXN0ZXJzIHdoaWxlIHVkcGh5LT5hcGJfY2xrCmlzIGRpc2FibGVkIGFu ZCB1ZHBoeS0+cHJlc2V0IGlzIGFzc2VydGVkPwoKSW4gY2l4X3VkcGh5X3Byb2JlKCkgYW5kIHNr eTFfdWRwaHlfZXhpdCgpLCB1ZHBoeS0+cmVzZXQgYW5kIHVkcGh5LT5wcmVzZXQKYXJlIGFzc2Vy dGVkIGFuZCB1ZHBoeS0+YXBiX2NsayBpcyBkaXNhYmxlZC4gSWYgdWRwaHlfZHBfcGh5X3Bvd2Vy X29uKCkgaXMKY2FsbGVkIHdoZW4gVURQSFlfTU9ERV9EUCBpcyBub3Qgc2V0IGluIHVkcGh5LT5u ZXh0X21vZGUgKGZvciBleGFtcGxlLCB3aGVuCnVzYmRwX3R5cGVjX211eF9zZXQoKSBzZXRzIHVk cGh5LT5uZXh0X21vZGUgPSBVRFBIWV9NT0RFX1VTQiBmb3IKVFlQRUNfU1RBVEVfU0FGRSBvciBV U0Itb25seSBtb2RlKSwgdWRwaHlfZHBfcGh5X3Bvd2VyX29uKCkgcmV0dXJucyAwIHdpdGhvdXQK ZW5hYmxpbmcgdWRwaHktPmFwYl9jbGsgb3IgZGVhc3NlcnRpbmcgdWRwaHktPnByZXNldC4KCklm IHRoZSBEaXNwbGF5UG9ydCBjb250cm9sbGVyIHRoZW4gY2FsbHMgcGh5X2NvbmZpZ3VyZSgpIChv ciBjYWxscwpwaHlfY29uZmlndXJlKCkgYmVmb3JlIHBoeV9wb3dlcl9vbigpKSwgdWRwaHlfZHBf cGh5X2NvbmZpZ3VyZSgpIGRvZXMgbm90CmNoZWNrIHdoZXRoZXIgdWRwaHktPmN1cl9tb2RlICYg VURQSFlfTU9ERV9EUCBpcyBhY3RpdmUgYmVmb3JlIGFjY2Vzc2luZwp1ZHBoeS0+cGh5X3JlZ21h cCBpbiB1ZHBoeV9kcF9waHlfc2V0X3JhdGUoKSBhbmQgdWRwaHlfZHBfcGh5X3NldF92b2x0YWdl cygpLgoKWyAuLi4gXQoKPiArc3RhdGljIGludCBjaXhfdTNwaHlfc2V0X21vZGUoc3RydWN0IHBo eSAqcGh5LCBlbnVtIHBoeV9tb2RlIG1vZGUsIGludCBzdWJtb2RlKQo+ICt7Cj4gKwlpZiAobW9k ZSA9PSBQSFlfTU9ERV9JTlZBTElEKQo+ICsJCXJldHVybiBjaXhfdTNwaHlfZXhpdChwaHkpOwo+ ICsKPiArCXJldHVybiBjaXhfdTNwaHlfaW5pdChwaHkpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgY29u c3Qgc3RydWN0IHBoeV9vcHMgY2l4X3UzcGh5X29wcyA9IHsKPiArCS5zZXRfbW9kZSAgICAgICA9 IGNpeF91M3BoeV9zZXRfbW9kZSwKPiArCS5leGl0CQk9IGNpeF91M3BoeV9leGl0LAo+ICsJLm93 bmVyCQk9IFRISVNfTU9EVUxFLAo+ICt9OwoKW1NldmVyaXR5OiBIaWdoXQpJcyBpdCBpbnRlbnRp b25hbCB0aGF0IGNpeF91M3BoeV9vcHMgZGVmaW5lcyAuZXhpdCA9IGNpeF91M3BoeV9leGl0IHdp dGhvdXQKLmluaXQsIC5wb3dlcl9vbiwgb3IgLnBvd2VyX29mZiwgYW5kIGluc3RlYWQgd2lyZXMg Y2l4X3UzcGh5X2luaXQoKSBhbmQKY2l4X3UzcGh5X2V4aXQoKSBpbnRvIC5zZXRfbW9kZT8KClN0 YW5kYXJkIFVTQiBjb250cm9sbGVyIGRyaXZlcnMgKHN1Y2ggYXMgY2RuczMsIGR3YzMsIGFuZCB4 aGNpLXBsYXQpIG1hbmFnZQp0aGUgUEhZIGxpZmVjeWNsZSB0aHJvdWdoIHBoeV9pbml0KCksIHBo eV9wb3dlcl9vbigpLCBwaHlfcG93ZXJfb2ZmKCksIGFuZApwaHlfZXhpdCgpLiBEdXJpbmcgc3lz dGVtIHJlc3VtZSAoZm9yIGV4YW1wbGUgaW4gY2RuczNfY29udHJvbGxlcl9yZXN1bWUoKSksCmNh bGxpbmcgcGh5X2V4aXQoKSBmb2xsb3dlZCBieSBwaHlfaW5pdCgpIGFuZCBwaHlfcG93ZXJfb24o KSB3aXRob3V0IGNhbGxpbmcKcGh5X3NldF9tb2RlKCkgd2lsbCBydW4gY2l4X3UzcGh5X2V4aXQo KSBhbmQgbGVhdmUgdGhlIFVTQjMgUEhZIHBvd2VyZWQgb2ZmCmJlY2F1c2UgLmluaXQgYW5kIC5w b3dlcl9vbiBhcmUgTlVMTC4KClsgLi4uIF0KCj4gK3N0YXRpYyB2b2lkIHVkcGh5X3NldF9kZWZh dWx0X21vZGUoc3RydWN0IGNpeF91ZHBoeSAqdWRwaHkpCj4gK3sKPiArCXVkcGh5LT5jdXJfbW9k ZSA9IFVEUEhZX01PREVfTk9ORTsKPiArfQo+ICsKPiArc3RhdGljIGludCBjaXhfdWRwaHlfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewoKWyAuLi4gXQoKPiArCXJldCA9 IGRldmljZV9wcm9wZXJ0eV9yZWFkX3U4KGRldiwgImNpeCxkZWZhdWx0LWNvbmYiLCAmdWRwaHkt Pm5leHRfbW9kZSk7Cj4gKwlpZiAocmV0KQo+ICsJCXVkcGh5LT5uZXh0X21vZGUgPSBVRFBIWV9N T0RFX0RQX1VTQjsKPiArCj4gKwlyZXNldF9jb250cm9sX2Fzc2VydCh1ZHBoeS0+cmVzZXQpOwo+ ICsJcmVzZXRfY29udHJvbF9hc3NlcnQodWRwaHktPnByZXNldCk7CgpbIC4uLiBdCgo+ICsJdWRw aHlfc2V0X2RlZmF1bHRfbW9kZSh1ZHBoeSk7CgpbU2V2ZXJpdHk6IE1lZGl1bV0KVGhlIGNvbW1p dCBtZXNzYWdlIHN0YXRlczoKCiAgVGhlIGJvb3Rsb2FkZXIgbWF5IGhhbmQgb3ZlciB0aGUgcG9y dCBhbHJlYWR5IGluaXRpYWxpemVkOyBpbiB0aGF0CiAgY2FzZSB0aGUgZmlyc3QgcG93ZXJfb24g Y2FsbHMgc2tpcCB0aGUgcmUtaW5pdGlhbGl6YXRpb24uCgpIb3dldmVyLCBjaXhfdWRwaHlfcHJv YmUoKSB1bmNvbmRpdGlvbmFsbHkgYXNzZXJ0cyBib3RoIHVkcGh5LT5yZXNldCBhbmQKdWRwaHkt PnByZXNldCwgYW5kIHVkcGh5X3NldF9kZWZhdWx0X21vZGUoKSBzZXRzIHVkcGh5LT5jdXJfbW9k ZSA9ClVEUEhZX01PREVfTk9ORSwgc28gdGhlIGZpcnN0IGNhbGwgdG8gY2l4X3VzYmRwX3BoeV9w b3dlcl9vbigpIHdpbGwgYWx3YXlzCnJlLWluaXRpYWxpemUgdGhlIFBIWS4gRG9lcyB0aGUgcHJv YmUgcGF0aCBvciBjb21taXQgbWVzc2FnZSBuZWVkIHRvIGJlCnVwZGF0ZWQgdG8gbWF0Y2ggdGhl IGludGVuZGVkIGJvb3Rsb2FkZXIgaGFuZG92ZXIgYmVoYXZpb3I/CgotLSAKU2FzaGlrbyBBSSBy ZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYxMTAyMDgyMTEyLjIz MDYzMjYtMS1nYXJ5LnlhbmdAY2l4dGVjaC5jb20/cGFydD0yCgotLSAKbGludXgtcGh5IG1haWxp bmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK