From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793618211; b=Lq0962Zv8POw1+4XcCoGtEKSlAFfCDQa5jR/zesYmXHJ9YvOv27JR1T/obPmWLxNdPQ9 P0oB50eU0bKTr9a5/4cHPqtvrNNKF9byxmOBwYGGuRX66TPLqTF0qHIIYBShFJeCIMUE7 515/hVy2ReHScULo5/J4zVREJ8a4A5wBWbp/E4Am47R098F2FU2hTawv7V/xyJ9lL3wv1 bjHWc1Y5R6fjyin05+bUVqt5E0NWPnJGskfJqfeKdEJGakMxPxdb3UbrPm6BxIs8TvFpJ 4aAkU5Qh+b41jJ4iwpzK82eebk+kFSv4F/pzfjjTRaMVy1QtS7SB24tlTWib3ktOOYw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793618211; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=yAiN693EoE8Bv9AfkhxHQHZO02i5vG4nfF8UEUAX4DM=; b=ql1d2IvMZVkpZF0JimRBsBpg/gz9u79RPVS9dgfxlaYxfh07cCfX6cRBdoN6Lnfq5kzy d1f+1eghq394pBXjDdPbOnemb8lzj9Y2hwn6uwq+23NmAutEoRnNmrADEsAbAtkHJOsLZ 93m/Oa2GkcUxix/8YohJRqbOW80u22OiNZXdGr5tvhOezSVuvFOcH6azGcErylEP+SbHp ObwAILlyo+4z1LTlFwc+ug1a7BnPE0lxbx0ozW9wN0zeOGvfYa2XpHsICdP9xGfRu3lCI WL3w46GYjIqdEKDTAfCdcGatvJEiJmICg/APQ8V28Q/OXb1J4WMjlRhyyBiscYbolBw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dBJgUvxg; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99CC7606A324; Mon, 2 Nov 2026 11:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dBJgUvxg Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7CF91F00A1B; Mon, 2 Nov 2026 11:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793618211; bh=yAiN693EoE8Bv9AfkhxHQHZO02i5vG4nfF8UEUAX4DM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dBJgUvxgoTPg5T5Qmv2EvBcUPlsR0aAeYVYrqLoA8ZnCl2H4A8+uMEy82wjHu6eJA rxKwGH8Z/uJnhtLLLhrMriJ2OyBIDS81m5uTjET7CZIXIETX4MSrcTv2ruEbUpAtVd xdBxAaffXh8yGAcsCvEsW7t17gIum9IlVPmJX9ffwCOqsVeWLXAU9UYGErVcrKagNU 7NIjV3Y1b6Vy9yv5rNzDWjzG+XvKzmcthqOFOjK41wJqBsfMAIrZDaJ3rIQ7wHFPau hc9xc9XjBOGZ1zWmhqY/E9NJb+fff0Ri8przHBzMEWA/MGzUHuo6rDWqVWzJx6kubr lHZW4/JozhRgQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support Reply-To: sashiko-reviews@lists.linux.dev To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> References: <20261102-a9_i3c-v2-0-0c474bfccffa@amlogic.com> <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 02 Nov 2026 11:16:50 +0000 X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] dt-bindings: i3c: silvaco: unwieldy conditionals and invalid fal= lback -- commit 0af7894c213f5346efb5a1f1360dff5a7a1704bb Author: Junyi Zhao dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support This commit adds Amlogic A9 I3C controller compatibles (amlogic,a9-i3c and amlogic,a9-ao-i3c) with a silvaco,i3c-master-v1 fallback to the Silvaco I3C master Device Tree binding schema and adjusts the clock count constraints f= or each variant. > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yam= l b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > index 853092f7522d3..de1fdec654a26 100644 > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > @@ -19,6 +19,8 @@ properties: > - enum: > - nxp,imx94-i3c > - nxp,imx95-i3c > + - amlogic,a9-i3c > + - amlogic,a9-ao-i3c > - const: silvaco,i3c-master-v1 > =20 > reg: > @@ -28,14 +30,14 @@ properties: > maxItems: 1 > =20 > clocks: > - minItems: 2 > + minItems: 1 > items: > - description: system clock > - description: bus clock > - description: other (slower) events clock > =20 > clock-names: > - minItems: 2 > + minItems: 1 > items: > - const: pclk > - const: fast_clk > @@ -72,12 +74,30 @@ allOf: > enum: > - nxp,imx94-i3c > - nxp,imx95-i3c > + - amlogic,a9-i3c > then: > properties: > clocks: > + minItems: 2 > maxItems: 2 > clock-names: > + minItems: 2 > maxItems: 2 > + - if: > + properties: > + compatible: > + contains: > + const: amlogic,a9-ao-i3c > + then: > + properties: > + clocks: > + maxItems: 1 > + description: > + The "ao" variant is the controller instance in the Always-On= (AO) > + domain, which has no separate bus clock and derives the > + bus clock from an internal divider. > + clock-names: > + maxItems: 1 [Severity: Medium] With the top-level clocks and clock-names minItems lowered to 1 and a third if-then conditional block added under allOf to handle 1-clock, 2-clock, and 3-clock variants, the per-compatible conditionals in silvaco,i3c-master.yaml are becoming unwieldy. Since the Amlogic variants (especially the AO domain instance with its internal bus clock divider) differ significantly from the base binding, would it be cleaner to split the Amlogic binding into a separate schema document rather than piling more conditionals into this fil= e? Also, is silvaco,i3c-master-v1 an appropriate fallback compatible for amlogic,a9-i3c and amlogic,a9-ao-i3c? If a device tree node for amlogic,a9-ao-i3c binds via the generic silvaco,i3c-master-v1 compatible (which uses svc_default_drvdata without a vendor_init callback), svc_i3c_master_probe() looks up fast_clk in master->clks and fails with -EINVAL because fast_clk is absent from the Device Tree and the internal clock divider at offset 0x304 is never registered. Similarly, amlogic,a9-i3c requires Amlogic-specific fast_clk ra= te setup in aml_i3c_init() and hardware quirks (SVC_I3C_QUIRK_FIFO_EMPTY, SVC_I3C_QUIRK_FALSE_SLVSTART, and SVC_I3C_QUIRK_DAA_CORRUPT) to operate, much like nuvoton,npcm845-i3c which does not use silvaco,i3c-master-v1 as a fallback. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-a9_i3c-v2-= 0-0c474bfccffa@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD31B606A324 for ; Mon, 2 Nov 2026 11:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=x10wk5Zf; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dBJgUvxg DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=WwTHOlP98TIN3LN9nI68wRTZ51SXfi+unNG9xnOu2k8=; b=x10wk5ZfbNo67WgoUnqzlVULVW +sv2CgxjTpTlWFf6yb2RbBGVVc0U35SDsjJWOMqOMH2yEscg8U416DLRei1ZYw9uMKKmvhQJVR1su JF6BGJUYRjqstGV2U6rutkjLdFjAI/Eu7GI+frTw/B+YqHX+5uHmjOGK4nZr8m9mB/k+2qvhzhucT OIbPuj7WteIYG9Vq9xvT9AYmIW91EBdWywNiVmr+mNQnV+MgyEE7pplAEhuwFgG0Mq6xEUfhZPIGV NiSDVXNgpT29AKFT5QmjWRuoRO0MCkArRr3pY8xy0uO3J2tgLKR2qDgZDgdYCdyN9mN+oL83QTg91 RX8dP/oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNq21-0000000GHd5-1kuv; Mon, 02 Nov 2026 11:16:53 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNq20-0000000GHcY-12ZM; Mon, 02 Nov 2026 11:16:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7C97360DD8; Mon, 2 Nov 2026 11:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7CF91F00A1B; Mon, 2 Nov 2026 11:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793618211; bh=yAiN693EoE8Bv9AfkhxHQHZO02i5vG4nfF8UEUAX4DM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dBJgUvxgoTPg5T5Qmv2EvBcUPlsR0aAeYVYrqLoA8ZnCl2H4A8+uMEy82wjHu6eJA rxKwGH8Z/uJnhtLLLhrMriJ2OyBIDS81m5uTjET7CZIXIETX4MSrcTv2ruEbUpAtVd xdBxAaffXh8yGAcsCvEsW7t17gIum9IlVPmJX9ffwCOqsVeWLXAU9UYGErVcrKagNU 7NIjV3Y1b6Vy9yv5rNzDWjzG+XvKzmcthqOFOjK41wJqBsfMAIrZDaJ3rIQ7wHFPau hc9xc9XjBOGZ1zWmhqY/E9NJb+fff0Ri8przHBzMEWA/MGzUHuo6rDWqVWzJx6kubr lHZW4/JozhRgQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> References: <20261102-a9_i3c-v2-0-0c474bfccffa@amlogic.com> <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> Date: Mon, 02 Nov 2026 11:16:50 +0000 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHQtYmluZGluZ3M6 IGkzYzogc2lsdmFjbzogdW53aWVsZHkgY29uZGl0aW9uYWxzIGFuZCBpbnZhbGlkIGZhbGxiYWNr Ci0tCgpjb21taXQgMGFmNzg5NGMyMTNmNTM0NmVmYjVhMWYxMzYwZGZmNWE3YTE3MDRiYgpBdXRo b3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5jb20+CgpkdC1iaW5kaW5nczogaTNj OiBzaWx2YWNvLGkzYy1tYXN0ZXI6IEFkZCBBbWxvZ2ljIEE5IHN1cHBvcnQKClRoaXMgY29tbWl0 IGFkZHMgQW1sb2dpYyBBOSBJM0MgY29udHJvbGxlciBjb21wYXRpYmxlcyAoYW1sb2dpYyxhOS1p M2MgYW5kCmFtbG9naWMsYTktYW8taTNjKSB3aXRoIGEgc2lsdmFjbyxpM2MtbWFzdGVyLXYxIGZh bGxiYWNrIHRvIHRoZSBTaWx2YWNvIEkzQwptYXN0ZXIgRGV2aWNlIFRyZWUgYmluZGluZyBzY2hl bWEgYW5kIGFkanVzdHMgdGhlIGNsb2NrIGNvdW50IGNvbnN0cmFpbnRzIGZvcgplYWNoIHZhcmlh bnQuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaTNj L3NpbHZhY28saTNjLW1hc3Rlci55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+IGluZGV4IDg1MzA5MmY3NTIyZDMuLmRl MWZkZWM2NTRhMjYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9pM2Mvc2lsdmFjbyxpM2MtbWFzdGVyLnlhbWwKPiBAQCAtMTksNiAr MTksOCBAQCBwcm9wZXJ0aWVzOgo+ICAgICAgICAgICAgLSBlbnVtOgo+ICAgICAgICAgICAgICAg IC0gbnhwLGlteDk0LWkzYwo+ICAgICAgICAgICAgICAgIC0gbnhwLGlteDk1LWkzYwo+ICsgICAg ICAgICAgICAgIC0gYW1sb2dpYyxhOS1pM2MKPiArICAgICAgICAgICAgICAtIGFtbG9naWMsYTkt YW8taTNjCj4gICAgICAgICAgICAtIGNvbnN0OiBzaWx2YWNvLGkzYy1tYXN0ZXItdjEKPiAgCj4g ICAgcmVnOgo+IEBAIC0yOCwxNCArMzAsMTQgQEAgcHJvcGVydGllczoKPiAgICAgIG1heEl0ZW1z OiAxCj4gIAo+ICAgIGNsb2NrczoKPiAtICAgIG1pbkl0ZW1zOiAyCj4gKyAgICBtaW5JdGVtczog MQo+ICAgICAgaXRlbXM6Cj4gICAgICAgIC0gZGVzY3JpcHRpb246IHN5c3RlbSBjbG9jawo+ICAg ICAgICAtIGRlc2NyaXB0aW9uOiBidXMgY2xvY2sKPiAgICAgICAgLSBkZXNjcmlwdGlvbjogb3Ro ZXIgKHNsb3dlcikgZXZlbnRzIGNsb2NrCj4gIAo+ICAgIGNsb2NrLW5hbWVzOgo+IC0gICAgbWlu SXRlbXM6IDIKPiArICAgIG1pbkl0ZW1zOiAxCj4gICAgICBpdGVtczoKPiAgICAgICAgLSBjb25z dDogcGNsawo+ICAgICAgICAtIGNvbnN0OiBmYXN0X2Nsawo+IEBAIC03MiwxMiArNzQsMzAgQEAg YWxsT2Y6Cj4gICAgICAgICAgICAgIGVudW06Cj4gICAgICAgICAgICAgICAgLSBueHAsaW14OTQt aTNjCj4gICAgICAgICAgICAgICAgLSBueHAsaW14OTUtaTNjCj4gKyAgICAgICAgICAgICAgLSBh bWxvZ2ljLGE5LWkzYwo+ICAgICAgdGhlbjoKPiAgICAgICAgcHJvcGVydGllczoKPiAgICAgICAg ICBjbG9ja3M6Cj4gKyAgICAgICAgICBtaW5JdGVtczogMgo+ICAgICAgICAgICAgbWF4SXRlbXM6 IDIKPiAgICAgICAgICBjbG9jay1uYW1lczoKPiArICAgICAgICAgIG1pbkl0ZW1zOiAyCj4gICAg ICAgICAgICBtYXhJdGVtczogMgo+ICsgIC0gaWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAg ICAgICAgY29tcGF0aWJsZToKPiArICAgICAgICAgIGNvbnRhaW5zOgo+ICsgICAgICAgICAgICBj b25zdDogYW1sb2dpYyxhOS1hby1pM2MKPiArICAgIHRoZW46Cj4gKyAgICAgIHByb3BlcnRpZXM6 Cj4gKyAgICAgICAgY2xvY2tzOgo+ICsgICAgICAgICAgbWF4SXRlbXM6IDEKPiArICAgICAgICAg IGRlc2NyaXB0aW9uOgo+ICsgICAgICAgICAgICBUaGUgImFvIiB2YXJpYW50IGlzIHRoZSBjb250 cm9sbGVyIGluc3RhbmNlIGluIHRoZSBBbHdheXMtT24gKEFPKQo+ICsgICAgICAgICAgICBkb21h aW4sIHdoaWNoIGhhcyBubyBzZXBhcmF0ZSBidXMgY2xvY2sgYW5kIGRlcml2ZXMgdGhlCj4gKyAg ICAgICAgICAgIGJ1cyBjbG9jayBmcm9tIGFuIGludGVybmFsIGRpdmlkZXIuCj4gKyAgICAgICAg Y2xvY2stbmFtZXM6Cj4gKyAgICAgICAgICBtYXhJdGVtczogMQoKW1NldmVyaXR5OiBNZWRpdW1d CldpdGggdGhlIHRvcC1sZXZlbCBjbG9ja3MgYW5kIGNsb2NrLW5hbWVzIG1pbkl0ZW1zIGxvd2Vy ZWQgdG8gMSBhbmQgYSB0aGlyZAppZi10aGVuIGNvbmRpdGlvbmFsIGJsb2NrIGFkZGVkIHVuZGVy IGFsbE9mIHRvIGhhbmRsZSAxLWNsb2NrLCAyLWNsb2NrLCBhbmQKMy1jbG9jayB2YXJpYW50cywg dGhlIHBlci1jb21wYXRpYmxlIGNvbmRpdGlvbmFscyBpbiBzaWx2YWNvLGkzYy1tYXN0ZXIueWFt bAphcmUgYmVjb21pbmcgdW53aWVsZHkuIFNpbmNlIHRoZSBBbWxvZ2ljIHZhcmlhbnRzIChlc3Bl Y2lhbGx5IHRoZSBBTyBkb21haW4KaW5zdGFuY2Ugd2l0aCBpdHMgaW50ZXJuYWwgYnVzIGNsb2Nr IGRpdmlkZXIpIGRpZmZlciBzaWduaWZpY2FudGx5IGZyb20gdGhlCmJhc2UgYmluZGluZywgd291 bGQgaXQgYmUgY2xlYW5lciB0byBzcGxpdCB0aGUgQW1sb2dpYyBiaW5kaW5nIGludG8gYQpzZXBh cmF0ZSBzY2hlbWEgZG9jdW1lbnQgcmF0aGVyIHRoYW4gcGlsaW5nIG1vcmUgY29uZGl0aW9uYWxz IGludG8gdGhpcyBmaWxlPwoKQWxzbywgaXMgc2lsdmFjbyxpM2MtbWFzdGVyLXYxIGFuIGFwcHJv cHJpYXRlIGZhbGxiYWNrIGNvbXBhdGlibGUgZm9yCmFtbG9naWMsYTktaTNjIGFuZCBhbWxvZ2lj LGE5LWFvLWkzYz8KCklmIGEgZGV2aWNlIHRyZWUgbm9kZSBmb3IgYW1sb2dpYyxhOS1hby1pM2Mg YmluZHMgdmlhIHRoZSBnZW5lcmljCnNpbHZhY28saTNjLW1hc3Rlci12MSBjb21wYXRpYmxlICh3 aGljaCB1c2VzIHN2Y19kZWZhdWx0X2RydmRhdGEgd2l0aG91dCBhCnZlbmRvcl9pbml0IGNhbGxi YWNrKSwgc3ZjX2kzY19tYXN0ZXJfcHJvYmUoKSBsb29rcyB1cCBmYXN0X2NsayBpbgptYXN0ZXIt PmNsa3MgYW5kIGZhaWxzIHdpdGggLUVJTlZBTCBiZWNhdXNlIGZhc3RfY2xrIGlzIGFic2VudCBm cm9tIHRoZQpEZXZpY2UgVHJlZSBhbmQgdGhlIGludGVybmFsIGNsb2NrIGRpdmlkZXIgYXQgb2Zm c2V0IDB4MzA0IGlzIG5ldmVyCnJlZ2lzdGVyZWQuIFNpbWlsYXJseSwgYW1sb2dpYyxhOS1pM2Mg cmVxdWlyZXMgQW1sb2dpYy1zcGVjaWZpYyBmYXN0X2NsayByYXRlCnNldHVwIGluIGFtbF9pM2Nf aW5pdCgpIGFuZCBoYXJkd2FyZSBxdWlya3MgKFNWQ19JM0NfUVVJUktfRklGT19FTVBUWSwKU1ZD X0kzQ19RVUlSS19GQUxTRV9TTFZTVEFSVCwgYW5kIFNWQ19JM0NfUVVJUktfREFBX0NPUlJVUFQp IHRvIG9wZXJhdGUsCm11Y2ggbGlrZSBudXZvdG9uLG5wY204NDUtaTNjIHdoaWNoIGRvZXMgbm90 IHVzZSBzaWx2YWNvLGkzYy1tYXN0ZXItdjEgYXMgYQpmYWxsYmFjay4KCi0tIApTYXNoaWtvIEFJ IHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMDItYTlfaTNj LXYyLTAtMGM0NzRiZmNjZmZhQGFtbG9naWMuY29tP3BhcnQ9MgoKLS0gCmxpbnV4LWkzYyBtYWls aW5nIGxpc3QKbGludXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1pM2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF29D606A324 for ; Mon, 2 Nov 2026 11:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sZIw9HWY; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dBJgUvxg DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Ps+5hBE40NiEFg7NS3QruM6Buj1TiShABRejZkwsyD0=; b=sZIw9HWYW5CAdSAS8ULDWUhLsa pVH/UYeuwSVMhQSpUIOrONWxbOwXGClzp+tIU0ENnt21rxTLoP0atWEuiZoENgD8XbfaLBeaIJghM OLRtszqycf5DvlOBA0H4OYrwOOfhaRuc2EXwKnSVlCwto2xCCXF+VABSiuj5GrHRgMtINalYeOF57 BDBBWCwvjYy7ra+DpuxuaA9kmpB1qJVpypho58EOBFBROL2lWAAsHHPacY5BqWKWNFbN5nfJrahuW V25n38KmqdVyqOOAWWkviGdkx/wyv6/6aZ6Yfmw2VQ2MiKHmf+feY59eTdcYC5YBLf9Mw7xzT0T5O CfUW7olg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNq21-0000000GHd1-1QEf; Mon, 02 Nov 2026 11:16:53 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xNq20-0000000GHcY-12ZM; Mon, 02 Nov 2026 11:16:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7C97360DD8; Mon, 2 Nov 2026 11:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7CF91F00A1B; Mon, 2 Nov 2026 11:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793618211; bh=yAiN693EoE8Bv9AfkhxHQHZO02i5vG4nfF8UEUAX4DM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dBJgUvxgoTPg5T5Qmv2EvBcUPlsR0aAeYVYrqLoA8ZnCl2H4A8+uMEy82wjHu6eJA rxKwGH8Z/uJnhtLLLhrMriJ2OyBIDS81m5uTjET7CZIXIETX4MSrcTv2ruEbUpAtVd xdBxAaffXh8yGAcsCvEsW7t17gIum9IlVPmJX9ffwCOqsVeWLXAU9UYGErVcrKagNU 7NIjV3Y1b6Vy9yv5rNzDWjzG+XvKzmcthqOFOjK41wJqBsfMAIrZDaJ3rIQ7wHFPau hc9xc9XjBOGZ1zWmhqY/E9NJb+fff0Ri8przHBzMEWA/MGzUHuo6rDWqVWzJx6kubr lHZW4/JozhRgQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: i3c: silvaco,i3c-master: Add Amlogic A9 support To: "Junyi Zhao" Cc: linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org, neil.armstrong@linaro.org, "Alexandre Belloni" In-Reply-To: <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> References: <20261102-a9_i3c-v2-0-0c474bfccffa@amlogic.com> <20261102-a9_i3c-v2-2-0c474bfccffa@amlogic.com> Date: Mon, 02 Nov 2026 11:16:50 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHQtYmluZGluZ3M6 IGkzYzogc2lsdmFjbzogdW53aWVsZHkgY29uZGl0aW9uYWxzIGFuZCBpbnZhbGlkIGZhbGxiYWNr Ci0tCgpjb21taXQgMGFmNzg5NGMyMTNmNTM0NmVmYjVhMWYxMzYwZGZmNWE3YTE3MDRiYgpBdXRo b3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1sb2dpYy5jb20+CgpkdC1iaW5kaW5nczogaTNj OiBzaWx2YWNvLGkzYy1tYXN0ZXI6IEFkZCBBbWxvZ2ljIEE5IHN1cHBvcnQKClRoaXMgY29tbWl0 IGFkZHMgQW1sb2dpYyBBOSBJM0MgY29udHJvbGxlciBjb21wYXRpYmxlcyAoYW1sb2dpYyxhOS1p M2MgYW5kCmFtbG9naWMsYTktYW8taTNjKSB3aXRoIGEgc2lsdmFjbyxpM2MtbWFzdGVyLXYxIGZh bGxiYWNrIHRvIHRoZSBTaWx2YWNvIEkzQwptYXN0ZXIgRGV2aWNlIFRyZWUgYmluZGluZyBzY2hl bWEgYW5kIGFkanVzdHMgdGhlIGNsb2NrIGNvdW50IGNvbnN0cmFpbnRzIGZvcgplYWNoIHZhcmlh bnQuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaTNj L3NpbHZhY28saTNjLW1hc3Rlci55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+IGluZGV4IDg1MzA5MmY3NTIyZDMuLmRl MWZkZWM2NTRhMjYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kzYy9zaWx2YWNvLGkzYy1tYXN0ZXIueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9pM2Mvc2lsdmFjbyxpM2MtbWFzdGVyLnlhbWwKPiBAQCAtMTksNiAr MTksOCBAQCBwcm9wZXJ0aWVzOgo+ICAgICAgICAgICAgLSBlbnVtOgo+ICAgICAgICAgICAgICAg IC0gbnhwLGlteDk0LWkzYwo+ICAgICAgICAgICAgICAgIC0gbnhwLGlteDk1LWkzYwo+ICsgICAg ICAgICAgICAgIC0gYW1sb2dpYyxhOS1pM2MKPiArICAgICAgICAgICAgICAtIGFtbG9naWMsYTkt YW8taTNjCj4gICAgICAgICAgICAtIGNvbnN0OiBzaWx2YWNvLGkzYy1tYXN0ZXItdjEKPiAgCj4g ICAgcmVnOgo+IEBAIC0yOCwxNCArMzAsMTQgQEAgcHJvcGVydGllczoKPiAgICAgIG1heEl0ZW1z OiAxCj4gIAo+ICAgIGNsb2NrczoKPiAtICAgIG1pbkl0ZW1zOiAyCj4gKyAgICBtaW5JdGVtczog MQo+ICAgICAgaXRlbXM6Cj4gICAgICAgIC0gZGVzY3JpcHRpb246IHN5c3RlbSBjbG9jawo+ICAg ICAgICAtIGRlc2NyaXB0aW9uOiBidXMgY2xvY2sKPiAgICAgICAgLSBkZXNjcmlwdGlvbjogb3Ro ZXIgKHNsb3dlcikgZXZlbnRzIGNsb2NrCj4gIAo+ICAgIGNsb2NrLW5hbWVzOgo+IC0gICAgbWlu SXRlbXM6IDIKPiArICAgIG1pbkl0ZW1zOiAxCj4gICAgICBpdGVtczoKPiAgICAgICAgLSBjb25z dDogcGNsawo+ICAgICAgICAtIGNvbnN0OiBmYXN0X2Nsawo+IEBAIC03MiwxMiArNzQsMzAgQEAg YWxsT2Y6Cj4gICAgICAgICAgICAgIGVudW06Cj4gICAgICAgICAgICAgICAgLSBueHAsaW14OTQt aTNjCj4gICAgICAgICAgICAgICAgLSBueHAsaW14OTUtaTNjCj4gKyAgICAgICAgICAgICAgLSBh bWxvZ2ljLGE5LWkzYwo+ICAgICAgdGhlbjoKPiAgICAgICAgcHJvcGVydGllczoKPiAgICAgICAg ICBjbG9ja3M6Cj4gKyAgICAgICAgICBtaW5JdGVtczogMgo+ICAgICAgICAgICAgbWF4SXRlbXM6 IDIKPiAgICAgICAgICBjbG9jay1uYW1lczoKPiArICAgICAgICAgIG1pbkl0ZW1zOiAyCj4gICAg ICAgICAgICBtYXhJdGVtczogMgo+ICsgIC0gaWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAg ICAgICAgY29tcGF0aWJsZToKPiArICAgICAgICAgIGNvbnRhaW5zOgo+ICsgICAgICAgICAgICBj b25zdDogYW1sb2dpYyxhOS1hby1pM2MKPiArICAgIHRoZW46Cj4gKyAgICAgIHByb3BlcnRpZXM6 Cj4gKyAgICAgICAgY2xvY2tzOgo+ICsgICAgICAgICAgbWF4SXRlbXM6IDEKPiArICAgICAgICAg IGRlc2NyaXB0aW9uOgo+ICsgICAgICAgICAgICBUaGUgImFvIiB2YXJpYW50IGlzIHRoZSBjb250 cm9sbGVyIGluc3RhbmNlIGluIHRoZSBBbHdheXMtT24gKEFPKQo+ICsgICAgICAgICAgICBkb21h aW4sIHdoaWNoIGhhcyBubyBzZXBhcmF0ZSBidXMgY2xvY2sgYW5kIGRlcml2ZXMgdGhlCj4gKyAg ICAgICAgICAgIGJ1cyBjbG9jayBmcm9tIGFuIGludGVybmFsIGRpdmlkZXIuCj4gKyAgICAgICAg Y2xvY2stbmFtZXM6Cj4gKyAgICAgICAgICBtYXhJdGVtczogMQoKW1NldmVyaXR5OiBNZWRpdW1d CldpdGggdGhlIHRvcC1sZXZlbCBjbG9ja3MgYW5kIGNsb2NrLW5hbWVzIG1pbkl0ZW1zIGxvd2Vy ZWQgdG8gMSBhbmQgYSB0aGlyZAppZi10aGVuIGNvbmRpdGlvbmFsIGJsb2NrIGFkZGVkIHVuZGVy IGFsbE9mIHRvIGhhbmRsZSAxLWNsb2NrLCAyLWNsb2NrLCBhbmQKMy1jbG9jayB2YXJpYW50cywg dGhlIHBlci1jb21wYXRpYmxlIGNvbmRpdGlvbmFscyBpbiBzaWx2YWNvLGkzYy1tYXN0ZXIueWFt bAphcmUgYmVjb21pbmcgdW53aWVsZHkuIFNpbmNlIHRoZSBBbWxvZ2ljIHZhcmlhbnRzIChlc3Bl Y2lhbGx5IHRoZSBBTyBkb21haW4KaW5zdGFuY2Ugd2l0aCBpdHMgaW50ZXJuYWwgYnVzIGNsb2Nr IGRpdmlkZXIpIGRpZmZlciBzaWduaWZpY2FudGx5IGZyb20gdGhlCmJhc2UgYmluZGluZywgd291 bGQgaXQgYmUgY2xlYW5lciB0byBzcGxpdCB0aGUgQW1sb2dpYyBiaW5kaW5nIGludG8gYQpzZXBh cmF0ZSBzY2hlbWEgZG9jdW1lbnQgcmF0aGVyIHRoYW4gcGlsaW5nIG1vcmUgY29uZGl0aW9uYWxz IGludG8gdGhpcyBmaWxlPwoKQWxzbywgaXMgc2lsdmFjbyxpM2MtbWFzdGVyLXYxIGFuIGFwcHJv cHJpYXRlIGZhbGxiYWNrIGNvbXBhdGlibGUgZm9yCmFtbG9naWMsYTktaTNjIGFuZCBhbWxvZ2lj LGE5LWFvLWkzYz8KCklmIGEgZGV2aWNlIHRyZWUgbm9kZSBmb3IgYW1sb2dpYyxhOS1hby1pM2Mg YmluZHMgdmlhIHRoZSBnZW5lcmljCnNpbHZhY28saTNjLW1hc3Rlci12MSBjb21wYXRpYmxlICh3 aGljaCB1c2VzIHN2Y19kZWZhdWx0X2RydmRhdGEgd2l0aG91dCBhCnZlbmRvcl9pbml0IGNhbGxi YWNrKSwgc3ZjX2kzY19tYXN0ZXJfcHJvYmUoKSBsb29rcyB1cCBmYXN0X2NsayBpbgptYXN0ZXIt PmNsa3MgYW5kIGZhaWxzIHdpdGggLUVJTlZBTCBiZWNhdXNlIGZhc3RfY2xrIGlzIGFic2VudCBm cm9tIHRoZQpEZXZpY2UgVHJlZSBhbmQgdGhlIGludGVybmFsIGNsb2NrIGRpdmlkZXIgYXQgb2Zm c2V0IDB4MzA0IGlzIG5ldmVyCnJlZ2lzdGVyZWQuIFNpbWlsYXJseSwgYW1sb2dpYyxhOS1pM2Mg cmVxdWlyZXMgQW1sb2dpYy1zcGVjaWZpYyBmYXN0X2NsayByYXRlCnNldHVwIGluIGFtbF9pM2Nf aW5pdCgpIGFuZCBoYXJkd2FyZSBxdWlya3MgKFNWQ19JM0NfUVVJUktfRklGT19FTVBUWSwKU1ZD X0kzQ19RVUlSS19GQUxTRV9TTFZTVEFSVCwgYW5kIFNWQ19JM0NfUVVJUktfREFBX0NPUlJVUFQp IHRvIG9wZXJhdGUsCm11Y2ggbGlrZSBudXZvdG9uLG5wY204NDUtaTNjIHdoaWNoIGRvZXMgbm90 IHVzZSBzaWx2YWNvLGkzYy1tYXN0ZXItdjEgYXMgYQpmYWxsYmFjay4KCi0tIApTYXNoaWtvIEFJ IHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMDItYTlfaTNj LXYyLTAtMGM0NzRiZmNjZmZhQGFtbG9naWMuY29tP3BhcnQ9MgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QK bGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=