Re: [PATCH] drm/etnaviv: Keep busy jobs alive in the hangcheck

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/etnaviv: missing kernel-parameters.txt entry for hang_max_ms parameter
--

commit d016b8a43dc381c8473158580794cfa7c242820a
Author: Christian Gmeiner <cgmeiner@igalia.com>

drm/etnaviv: Keep busy jobs alive in the hangcheck

This commit checks VIVS_HI_IDLE_STATE in the scheduler timeout handler to
keep jobs alive while non-FE/MC hardware units are busy, up to a new
hang_max_ms module parameter limit.

> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_sched.c b/drivers/gpu/drm/etnaviv/etnaviv_sched.c
> index 3cc50d697c891..cef1ed33ff919 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_sched.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_sched.c
> @@ -17,6 +17,9 @@ static int etnaviv_job_hang_limit = 0;
>  module_param_named(job_hang_limit, etnaviv_job_hang_limit, int , 0444);
>  static int etnaviv_hw_jobs_limit = 4;
>  module_param_named(hw_job_limit, etnaviv_hw_jobs_limit, int , 0444);
> +static unsigned int etnaviv_hang_max_ms = 30000;
> +module_param_named(hang_max_ms, etnaviv_hang_max_ms, uint, 0644);
> +MODULE_PARM_DESC(hang_max_ms, "Time a busy job may run without front-end progress (ms, 0 = no extension)");

[Severity: Low]
Should this new hang_max_ms module parameter (etnaviv_hang_max_ms in
drivers/gpu/drm/etnaviv/etnaviv_sched.c), which can also be set on the kernel
command line at boot as etnaviv.hang_max_ms=, be documented in
Documentation/admin-guide/kernel-parameters.txt?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-etnaviv-compute-hangcheck-v1-1-1f81dd1806a2@igalia.com?part=1