Re: [PATCH 2/2] PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] PCI/PM: undocumented HP ZBook 15 G4 quirk with wrong DMI_BOARD_NAME match
- [Low] PCI/PM: wrong GitLab issue URL in comment for HP Spectre x360 quirk
--

commit e809ddf27f4e25c996dc6c51452553c16b6c434f
Author: Mario Limonciello <superm1@kernel.org>

PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

This commit adds DMI entries to bridge_d3_blacklist in drivers/pci/pci.c to
prevent PCIe Root Ports from entering D3cold on the HP Spectre x360
Convertible 15-ch0xx, where the AMD Polaris Radeon dGPU fails to transition
back from D3cold to D0 during runtime PM resume.

> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 17ec7f065682d..151b98757ba57 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3039,6 +3039,24 @@ static const struct dmi_system_id bridge_d3_blacklist[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "314D"),
>  		},
>  	},
> +	{
> +		/*
> +		 * Changing power state of root port dGPU is connected fails
> +		 * https://gitlab.freedesktop.org/drm/amd/-/issues/3229
> +		 */

[Severity: Low]
This isn't a bug, but the comment in bridge_d3_blacklist in
drivers/pci/pci.c points to issue 3229 (which belongs to the earlier
Hewlett-Packard HP Pavilion 17 Notebook PC/1972 entry). Should this
reference https://gitlab.freedesktop.org/drm/amd/-/issues/3389 to match the
Closes tag in the commit message?

> +		.ident = "HP Spectre x360 Convertible 15-ch0xx",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "83BB"),
> +		},
> +	},
> +	{
> +		.ident = "HP ZBook 15 G4",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "HP ZBook 15 G4"),
> +		},
> +	},

[Severity: Medium]
Was the HP ZBook 15 G4 entry in bridge_d3_blacklist in drivers/pci/pci.c
included here intentionally, given that the commit message only describes the
HP Spectre x360 Convertible 15-ch0xx?

Also, when pci_bridge_d3_possible() calls
dmi_check_system(bridge_d3_blacklist), will DMI_MATCH(DMI_BOARD_NAME,
"HP ZBook 15 G4") ever match on target hardware? On HP systems,
DMI_BOARD_NAME holds a 4-character hex board ID (such as "83BB" or "1972" in
the preceding entries), while "HP ZBook 15 G4" is the marketing string
stored in DMI_PRODUCT_NAME.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-superm1-kbz-222179-v1-0-c91a664ba251@kernel.org?part=2