Re: [PATCH v18 06/15] xfs: use read ioend for fsverity data verification

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] xfs: missing include of xfs_fsverity.h in fs/xfs/xfs_super.c breaks build
--

commit ee4503160b45b8debf89daa601b6a9be79307262
Author: Andrey Albershteyn <aalbersh@kernel.org>

xfs: use read ioend for fsverity data verification

This commit uses read ioends to offload fsverity data verification to a
dedicated fsverity workqueue, avoiding deadlocks with metadata read
completions. It also adds a slab cache and mempool for fsverity ioend
structures and passes fsverity_info from the iomap context to the ioend.

> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 5a06132aa3846..3a7d7334e9a65 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -2516,8 +2516,20 @@ xfs_init_caches(void)
>  	if (!xfs_parent_args_cache)
>  		goto out_destroy_xmi_cache;
>  
> +#ifdef CONFIG_FS_VERITY
> +	xfs_fsverity_ioend_cache = kmem_cache_create("xfs_fsverity_ioend",
> +					     sizeof(struct xfs_fsverity_ioend),
> +					     0, 0, NULL);
> +	if (!xfs_fsverity_ioend_cache)
> +		goto out_destroy_parent_args_cache;
> +#endif
> +
>  	return 0;
>  
> +#ifdef CONFIG_FS_VERITY
> + out_destroy_parent_args_cache:
> +	kmem_cache_destroy(xfs_parent_args_cache);
> +#endif
>   out_destroy_xmi_cache:
>  	kmem_cache_destroy(xfs_xmi_cache);
>   out_destroy_xmd_cache:
> @@ -2580,6 +2592,9 @@ xfs_destroy_caches(void)
>  	 * destroy caches.
>  	 */
>  	rcu_barrier();
> +#ifdef CONFIG_FS_VERITY
> +	kmem_cache_destroy(xfs_fsverity_ioend_cache);
> +#endif
>  	kmem_cache_destroy(xfs_parent_args_cache);
>  	kmem_cache_destroy(xfs_xmd_cache);
>  	kmem_cache_destroy(xfs_xmi_cache);
> @@ -2660,10 +2675,14 @@ init_xfs_fs(void)
>  	if (error)
>  		goto out;
>  
> -	error = xfs_init_workqueues();
> +	error = xfs_fsverity_init();
>  	if (error)
>  		goto out_destroy_caches;
>  
> +	error = xfs_init_workqueues();
> +	if (error)
> +		goto out_fsverity_exit;
> +
>  	error = xfs_mru_cache_init();
>  	if (error)
>  		goto out_destroy_wq;
> @@ -2740,6 +2759,8 @@ init_xfs_fs(void)
>  	xfs_mru_cache_uninit();
>   out_destroy_wq:
>  	xfs_destroy_workqueues();
> + out_fsverity_exit:
> +	xfs_fsverity_exit();
>   out_destroy_caches:
>  	xfs_destroy_caches();
>   out:
> @@ -2763,6 +2784,7 @@ exit_xfs_fs(void)
>  	xfs_cleanup_procfs();
>  	xfs_mru_cache_uninit();
>  	xfs_destroy_workqueues();
> +	xfs_fsverity_exit();
>  	xfs_destroy_caches();
>  	xfs_uuid_table_free();
>  }

[Severity: Low]
Does fs/xfs/xfs_super.c fail to build at this commit because xfs_fsverity.h
is not included yet?

In fs/xfs/xfs_super.c, xfs_init_caches() and xfs_destroy_caches() reference
xfs_fsverity_ioend_cache and struct xfs_fsverity_ioend when CONFIG_FS_VERITY
is enabled, while init_xfs_fs() and exit_xfs_fs() unconditionally call
xfs_fsverity_init() and xfs_fsverity_exit().

Those declarations and static inline stubs live in fs/xfs/xfs_fsverity.h,
which is not included in fs/xfs/xfs_super.c until a later commit in the
series, 996c2dec93ad ("xfs: add fs-verity support").

Should #include "xfs_fsverity.h" be moved into fs/xfs/xfs_super.c in this
commit so the series remains bisectable under both CONFIG_FS_VERITY=y and
CONFIG_FS_VERITY=n?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102144147.2393369-1-aalbersh@kernel.org?part=6