Re: [PATCH v11 2/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: rockchip: unsorted nodes and missing blank lines in quarkpi-ca2
--

commit 994e70f88ca26a3876389bdd486ca82fe1479b19
Author: Bob Hui <bg9oxa@163.com>

arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2

This commit adds the device tree for the ALIENTEK QuarkPi-CA2, an RK3588S
based card computer.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts
> new file mode 100644
> index 0000000000000..c7889f729191d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts

[ ... ]

> +	aliases {
> +		ethernet0 = &gmac1;
> +		mmc0 = &sdhci;
> +		mmc1 = &sdmmc;
> +	};
> +	analog_sound: analog-sound {
> +		compatible = "simple-audio-card";

[ ... ]

> +		simple-audio-card,routing =
> +			"Headphones", "LOUT1",
> +			"Headphones", "ROUT1",
> +			"Headphones", "Headphone Power OUTL",
> +			"Headphones", "Headphone Power OUTR",
> +			"Headphone Power INL", "LOUT1",
> +			"Headphone Power INR", "ROUT1",
> +			"LINPUT1", "Headset Mic",
> +			"RINPUT1", "Headset Mic";
> +		sound_cpu: simple-audio-card,cpu {
> +			sound-dai = <&i2s0_8ch>;
> +		};
> +
> +		sound_codec: simple-audio-card,codec {
> +			sound-dai = <&es8388>;
> +			system-clock-frequency = <12288000>;
> +		};
> +	};
> +
> +	hp_amp: audio-amplifier {
> +		compatible = "simple-audio-amplifier";
> +		sound-name-prefix = "Headphone Power";
> +		enable-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};
> +	hdmi0-con {
> +		compatible = "hdmi-connector";

[ ... ]

> +	headset_keys: headset-keys {
> +		compatible = "adc-keys";
> +		io-channels = <&saradc 3>;
> +		io-channel-names = "buttons";
> +		keyup-threshold-microvolt = <1800000>;
> +		poll-interval = <100>;
> +
> +		button-play-pause {
> +			label = "play pause";
> +			linux,code = <KEY_PLAYPAUSE>;
> +			press-threshold-microvolt = <2000>;
> +		};
> +	};
> +	ir_receiver: ir-receiver {
> +		compatible = "gpio-ir-receiver";

[ ... ]

> +&pinctrl {
> +	headphone {
> +		hp_con: hp-con {
> +			rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +		hp_det: hp-det {
> +			rockchip,pins = <1 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +	ir {
> +		ir_receiver_pin: ir-receiver-pin {
> +			rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};
> +
> +	leds {
> +		work_led_pin: work-led-pin {
> +			rockchip,pins = <1 RK_PD7 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +	};
> +
> +	pcie {
> +		pcie2x1l2_perstn: pcie2x1l2-perstn {
> +			rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +	sdmmc {
> +		sd_s0_pwr: sd-s0-pwr {
> +			rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +	};

[ ... ]

> +&pwm14 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm14m1_pins>;
> +	status = "okay";
> +};
> +
> +&pwm7 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm7m0_pins>;
> +	status = "okay";
> +};

[ ... ]

> +		regulators {
> +			vdd_cpu_lit_s0: vdd_cpu_lit_mem_s0: dcdc-reg2 {
> +				regulator-name = "vdd_cpu_lit_s0";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <550000>;
> +				regulator-max-microvolt = <950000>;
> +				regulator-ramp-delay = <12500>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 {
> +				regulator-name = "vdd_vdenc_s0";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <550000>;
> +				regulator-max-microvolt = <950000>;
> +				regulator-ramp-delay = <12500>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vdd_gpu_s0: dcdc-reg1 {
> +				regulator-name = "vdd_gpu_s0";
> +				regulator-boot-on;
> +				regulator-min-microvolt = <550000>;
> +				regulator-max-microvolt = <950000>;
> +				regulator-ramp-delay = <12500>;
> +				regulator-enable-ramp-delay = <400>;
> +
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};
> +
> +			vcc_1v8_s3: dcdc-reg10 {
> +				regulator-name = "vcc_1v8_s3";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +				};
> +			};
> +
> +			vdd_log_s0: dcdc-reg3 {

[Severity: Low]
As reported by Heiko Stuebner on v10 [1], should all nodes without unit
addresses and phandle references in arch/arm64/boot/dts/rockchip/rk3588s-quarkpi-ca2.dts
be sorted in natural alpha-numeric order, with blank lines separating
sibling nodes?

Specifically:
- Under &spi2/pmic@0/regulators, dcdc-reg2 and dcdc-reg4 are placed before
  dcdc-reg1, and dcdc-reg10 is placed before dcdc-reg3 instead of natural
  alpha-numeric order dcdc-reg1 through dcdc-reg10.
- Phandle reference &pwm14 is placed before &pwm7 instead of &pwm7 before
  &pwm14.
- Inside analog-sound, simple-audio-card,cpu is placed before
  simple-audio-card,codec.
- Blank lines are missing between aliases and analog-sound, after
  simple-audio-card,routing in analog-sound, between chosen and hdmi0-con,
  between headset-keys and ir-receiver, and between hp-con and hp-det,
  headphone and ir, and pcie and sdmmc in &pinctrl.

[1] https://lore.kernel.org/r/2372620.HovnAMPojK@phil

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-quarkpi-ca2-v11-0-eb246076a82f@163.com?part=2