Re: [PATCH RESEND] usb: mtu3: fix system suspend in gadget mode after soft disconnect

[sashiko-bot@kernel.org]

> ssusb_gadget_suspend() removes the D+ pullup for system suspend by calling
> mtu3_dev_on_off(mtu, 0) directly. That writes the hardware SOFT_CONN bit
> but leaves mtu->softconnect alone, deliberately: ssusb_gadget_resume()
> needs it to decide whether to pull up again.
> 
> wait_for_ip_sleep() then asks ssusb_gadget_ip_sleep_check() whether the IP
> can sleep, and that function tests mtu->softconnect -- the gadget's intent
> rather than the state of the pin. So it answers "pulled up, the IP can
> sleep" for a device that was just disconnected, and the poll for
> SSUSB_IP_SLEEP_STS runs to its 100 ms timeout:
> 
>   mtu3 11271000.usb: gadget (high-speed) pullup D-
>   mtu3 11271000.usb: ip sleep failed!!!
>   mtu3 11271000.usb: gadget (high-speed) pullup D+
>   mtu3 11271000.usb: PM: dpm_run_callback(): mtu3_suspend returns -16
> [ ... ]
> is still set and the IP-sleep poll is still performed.
> 
> Fixes: e69027c25361 ("usb: mtu3: allow system suspend during active gadget connection")
> Assisted-by: LLM
> Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-rbrue-suez-upstreaming-mtu3-fix-suspend-usb-gadget-mode-v1-1-70a74a392015@gmail.com?part=1