From: sashiko-bot@kernel.org
To: "Roman Vivchar" <rva333@protonmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
lee@kernel.org
Subject: Re: [PATCH 2/2] backlight: add ktd3137 support
Date: Mon, 02 Nov 2026 20:18:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-194088@kernel.org> (raw)
In-Reply-To: <20261102-6768-ktd3137-v1-2-b5b4f903c56e@protonmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] backlight: ktd3137: use named initializer in ktd3137_ids
--
commit d3260d17f4919396b8ff6c1268dffef7e26e01cf
Author: Roman Vivchar <rva333@protonmail.com>
backlight: add ktd3137 support
This commit adds a backlight driver for the Kinetic KTD3137 display
backlight IC.
> diff --git a/drivers/video/backlight/ktd3137.c b/drivers/video/backlight/ktd3137.c
> new file mode 100644
> index 0000000000000..a3ff334b8d460
> --- /dev/null
> +++ b/drivers/video/backlight/ktd3137.c
> @@ -0,0 +1,262 @@
[ ... ]
> +static const struct i2c_device_id ktd3137_ids[] = {
> + { "ktd3137" },
> + { }
> +};
[Severity: Low]
This isn't a bug, but in drivers/video/backlight/ktd3137.c, could the
struct i2c_device_id entry in ktd3137_ids[] use a named initializer
({ .name = "ktd3137" }) instead of a positional initializer to match I2C
subsystem conventions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-6768-ktd3137-v1-0-b5b4f903c56e@protonmail.com?part=2
next prev parent reply other threads:[~2026-11-02 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:58 [PATCH 0/2] backlight: add ktd3137 support Roman Vivchar via B4 Relay
2026-11-02 19:58 ` Roman Vivchar
2026-11-02 19:58 ` [PATCH 1/2] dt-bindings: leds: backlight: add Kinetic KTD3137 Roman Vivchar via B4 Relay
2026-11-02 19:58 ` Roman Vivchar
2026-11-02 20:09 ` sashiko-bot
2026-11-03 14:05 ` Daniel Thompson
2026-11-03 14:34 ` Roman Vivchar
2026-11-03 14:42 ` Daniel Thompson
2026-11-03 15:21 ` Roman Vivchar
2026-11-03 17:10 ` Daniel Thompson
2026-11-02 19:58 ` [PATCH 2/2] backlight: add ktd3137 support Roman Vivchar via B4 Relay
2026-11-02 19:58 ` Roman Vivchar
2026-11-02 20:18 ` sashiko-bot [this message]
2026-11-03 14:15 ` Daniel Thompson
2026-11-03 14:45 ` Roman Vivchar
2026-11-03 14:58 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194088@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.