From: sashiko-bot@kernel.org
To: "Yuho Choi" <oss.patchbox@gmail.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v2] vdpa/mlx5: Don't free QP buffers if destroying the QP fails
Date: Mon, 02 Nov 2026 20:51:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-194152@kernel.org> (raw)
In-Reply-To: <20261102204734.443140-2-oss.patchbox@gmail.com>
> qp_destroy() frees the RQ buffer and doorbell record of a driver-owned
> QP even when DESTROY_QP fails. The QP then still exists in firmware and
> can read WQEs and the doorbell record from freed memory.
>
> Return without freeing them in that case, as cq_destroy() does, and
> include the QP type and the error in the warning.
>
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102204734.443140-2-oss.patchbox@gmail.com?part=1
prev parent reply other threads:[~2026-11-02 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 20:47 [PATCH v2] vdpa/mlx5: Don't free QP buffers if destroying the QP fails Yuho Choi
2026-11-02 20:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194152@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=oss.patchbox@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.