From: sashiko-bot@kernel.org
To: "Benjamin Segall" <bsegall@google.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: fix racy update of cpc->hrtimer_interval
Date: Mon, 02 Nov 2026 23:24:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-194330@kernel.org> (raw)
In-Reply-To: <xm26se1ihlqb.fsf@google.com>
> Updates to cpc->hrtimer_interval can race with reads either in the
> hrtimer itself, or other calls to perf_mux_hrtimer_restart. This is not
> exactly expected to be a common config change, but it's easy enough to
> fix.
>
> Since there's already an IPI to each cpu to restart the timer, and all
> reads are with irqs disabled, just move the update onto the target cpu.
>
> Fixes: 62b856397927 ("perf: Add sysfs entry to adjust multiplexing interval per PMU")
> Signed-off-by: Ben Segall <bsegall@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/xm26se1ihlqb.fsf@google.com?part=1
prev parent reply other threads:[~2026-11-02 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 23:11 [PATCH] perf: fix racy update of cpc->hrtimer_interval Benjamin Segall
2026-11-02 23:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194330@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bsegall@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.