From: sashiko-bot@kernel.org
To: "Guangshuo Li" <liguangshuo@mail.sdu.edu.cn>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: serial: samsung: Fix potential NULL dereference on removal
Date: Tue, 03 Nov 2026 00:53:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-194390@kernel.org> (raw)
In-Reply-To: <20261103-cmc-tty-2-683dcb126b@mail.sdu.edu.cn>
> Removing one port unregisters the shared UART driver and clears its
> state even when other ports remain registered. Removing another port
> then dereferences the cleared state.
>
> Keep the UART driver registered until all platform devices are removed
> at module exit. Retain registration on first probe.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: 6f134c3c7703 ("serial: samsung: Move uart_register_driver call to device probe")
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-cmc-tty-0-f5f5ec0841@mail.sdu.edu.cn?part=2
prev parent reply other threads:[~2026-11-03 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 0:45 [PATCH 0/2] tty: serial: Keep UART driver state until ports are removed Guangshuo Li
2026-11-03 0:45 ` [PATCH 1/2] tty: serial: ip22zilog: Fix potential NULL dereference on exit Guangshuo Li
2026-11-03 0:50 ` sashiko-bot
2026-11-03 0:45 ` [PATCH 2/2] tty: serial: samsung: Fix potential NULL dereference on removal Guangshuo Li
2026-11-03 0:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194390@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.