Re: [RFC PATCH] ALSA: pcmtest: Add a volume control with event fault injection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ALSA: pcmtest: missing documentation for new control fault module parameters
--

commit 37a7a575ca0b14787e4948616e5cc636a185dad2
Author: HyeongJun An <sammiee5311@gmail.com>

ALSA: pcmtest: Add a volume control with event fault injection

This commit adds a stereo playback volume mixer control to the virtual pcmtest
driver along with two module parameters, inject_ctl_no_event and
inject_ctl_spurious_event, to inject event reporting faults in
snd_pcmtst_volume_put().

> diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
> index 66bee8a2ce343..c95bb47174871 100644
> --- a/sound/drivers/pcmtest.c
> +++ b/sound/drivers/pcmtest.c

[ ... ]

> @@ -109,11 +114,17 @@ module_param(inject_trigger_err, bool, 0600);
>  MODULE_PARM_DESC(inject_trigger_err, "Inject EINVAL error in the 'trigger' callback");
>  module_param(inject_open_err, bool, 0600);
>  MODULE_PARM_DESC(inject_open_err, "Inject EBUSY error in the 'open' callback");
> +module_param(inject_ctl_no_event, bool, 0600);
> +MODULE_PARM_DESC(inject_ctl_no_event, "Report no change from the control 'put' callback");
> +module_param(inject_ctl_spurious_event, bool, 0600);
> +MODULE_PARM_DESC(inject_ctl_spurious_event, "Report a change from the control 'put' callback");

[Severity: Low]
Since inject_ctl_no_event and inject_ctl_spurious_event are registered via
module_param() in sound/drivers/pcmtest.c and can be passed on the kernel
command line at boot (as snd_pcmtest.inject_ctl_no_event= and
snd_pcmtest.inject_ctl_spurious_event=) or set via sysfs, should these new
parameters be documented in Documentation/admin-guide/kernel-parameters.txt
and under the Configuration and Errors injection sections of
Documentation/sound/cards/pcmtest.rst in this patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103011000.1012035-1-sammiee5311@gmail.com?part=1