From: sashiko-bot@kernel.org
To: "Xiangwu Lai" <laixiangwu@cmss.chinamobile.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: bcm63xx: Propagate iudma_init() error code
Date: Tue, 03 Nov 2026 01:50:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-194439@kernel.org> (raw)
In-Reply-To: <20261103014457.1255-1-laixiangwu@cmss.chinamobile.com>
> bcm63xx_init_udc_hw() calls iudma_init() and stores the return code
> in rc, but then returns 0 unconditionally. When iudma_init() fails,
> the hardware has already been torn down by bcm63xx_uninit_udc_hw(),
> yet the probe believes initialization succeeded and goes on to
> register a gadget controller with non-functional IUDMA channels.
>
> Return rc so the probe fails and reports the real error.
>
> Fixes: 613065e53cb1 ("usb: gadget: bcm63xx UDC driver")
> Signed-off-by: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103014457.1255-1-laixiangwu@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-03 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 1:44 [PATCH] usb: gadget: udc: bcm63xx: Propagate iudma_init() error code Xiangwu Lai
2026-11-03 1:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194439@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.