Re: [PATCH v2 3/3] usb: dwc3: starfive: Add JHB100 USB device adapter port enable quirk

[sashiko-bot@kernel.org]

> Add an extra iomem field to struct dwc3_gerneric, so as JHB100
> can add PHY adapter setting. Other soc also can use it.
> 
> Also Add Starfive JHB100 USB 2.0 device controller generic init
> function to remap PHY adapter io memory region and add adapter
> pre-run/stop function.
> 
> On the JHB100 BMC SoC, each DWC3 device controller is connected to a
> port of the xHCI controller that is exported to the server host over
> PCIe, through a PHY adapter. Setting the adapter USB 2.0 port enable
> bit asserts the connect status in the xHCI PORTSC register, so it must
> only be set once the gadget is ready to be enumerated, otherwise the
> host fails to enumerate the device. And clear the ppt enable bit
> while gadget device stop.
> 
> Add an optional "adapter" register region and toggle the port enable
> bit from the pre_run_stop glue callback.
> 
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103064836.71059-1-minda.chen@starfivetech.com?part=3