Re: [PATCH v4 01/22] ASoC: dt-bindings: cs42l84: Allow referenced dai-common properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: dt-bindings: cs42l84: loss of #sound-dai-cells const: 0 constraint
--

commit 51c8f9a50da0d86d550f375ea1f80d7bccc11075
Author: James Calligeros <jcalligeros99@gmail.com>

ASoC: dt-bindings: cs42l84: Allow referenced dai-common properties

This patch updates the cirrus,cs42l84 Devicetree binding schema to reference
dai-common.yaml, switches additionalProperties to unevaluatedProperties, and
removes the explicit #sound-dai-cells property definition.

>     ASoC: dt-bindings: cs42l84: Allow referenced dai-common properties
>     
>     Some consumers may wish to prepend the codec's name with a known value
>     to identify a specific codec among many and set #sound-dai-cells. Allow
>     this by allowing referenced properties from dai-common.yaml.
>     
>     Signed-off-by: James Calligeros <jcalligeros99@gmail.com>

> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> index 94062c1d9d45f..66cae8b7db5da 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> @@ -9,6 +9,9 @@ title: Cirrus Logic CS42L84 audio CODEC
>  maintainers:
>    - Martin Povišer <povik+lin@cutebit.org>
>  
> +allOf:
> +  - $ref: dai-common.yaml#
> +
>  description: |
>    The CS42L84 is a headphone jack codec made by Cirrus Logic and embedded
>    in personal computers sold by Apple. It was first seen in 2021 Macbook
> @@ -29,14 +32,11 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> -  '#sound-dai-cells':
> -    const: 0
> -

[Severity: Low]
Does removing the const: 0 constraint on #sound-dai-cells weaken schema
validation for cirrus,cs42l84 nodes?

Documentation/devicetree/bindings/sound/dai-common.yaml only sets:

  properties:
    '#sound-dai-cells': true

However, the CS42L84 driver in sound/soc/codecs/cs42l84.c registers only a
single DAI in cs42l84_i2c_probe():

  ret = devm_snd_soc_register_component(&i2c_client->dev,
          &soc_component_dev_cs42l84, &cs42l84_dai, 1);

Without const: 0 in cirrus,cs42l84.yaml, dtbs_check will allow non-zero
#sound-dai-cells values even though the codec only supports 0 cells.

Also, since cirrus,cs42l84.yaml already permitted #sound-dai-cells prior to
this change, should the commit message be updated so it does not claim that
referencing dai-common.yaml is needed to allow setting #sound-dai-cells, and
should '#sound-dai-cells': const: 0 be retained here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-macaudio-v4-0-637484efe46d@gmail.com?part=1