From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/IOV: drop PF reference if max VF bus computation fails
Date: Tue, 03 Nov 2026 10:56:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-195087@kernel.org> (raw)
In-Reply-To: <20261103104239.1373721-1-vulab@iscas.ac.cn>
> sriov_init() takes a reference on the PF found on the bus and stores it
> in iov->dev. The reference is normally released by sriov_release()
> through sriov_disable(). But if compute_max_vf_buses() fails, the
> error path clears dev->sriov and frees the iov without dropping that
> reference, so the PF device refcount is leaked once per failed SR-IOV
> initialisation.
>
> Release the PF reference on that path before freeing the iov.
>
> Fixes: ea9a8854161d ("PCI: Set SR-IOV NumVFs to zero after enumeration")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103104239.1373721-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 10:42 [PATCH] PCI/IOV: drop PF reference if max VF bus computation fails Wentao Liang
2026-11-03 10:56 ` sashiko-bot [this message]
2026-11-03 11:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195087@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.