From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: m41t80: use devm for the square wave clock provider
Date: Tue, 03 Nov 2026 11:07:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-195112@kernel.org> (raw)
In-Reply-To: <20261103105808.1395292-1-vulab@iscas.ac.cn>
> m41t80_sqw_register_clk() registers the square wave clock with
> clk_register() and publishes it with of_clk_add_provider(), but neither is
> ever torn down again: m41t80_remove() only unregisters the watchdog.
>
> The provider therefore keeps a reference to the device node and points at
> m41t80->sqw, which lives in devm-allocated driver data that is freed when
> the device is unbound. Resolving the clock afterwards dereferences freed
> memory.
>
> Switch to devm_clk_hw_register() and devm_of_clk_add_hw_provider() so that
> the clock and its provider are released with the device. The function no
> longer returns a struct clk pointer, so make it return an int instead.
>
> Fixes: 1373e77b4f10 ("rtc: m41t80: add clock provider support")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103105808.1395292-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 10:58 [PATCH] rtc: m41t80: use devm for the square wave clock provider Wentao Liang
2026-11-03 11:07 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-03 10:56 Wentao Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195112@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.