From: sashiko-bot@kernel.org
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/3] tty: fix misapplied compat_ptr() in tty_compat_ioctl()
Date: Tue, 03 Nov 2026 11:19:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-195137@kernel.org> (raw)
In-Reply-To: <63e9d84a1e8e23852423206cf3f8907aafc88f17.1793704520.git.jirislaby@kernel.org>
> Since commit f0193d3ea73b below, `cmd` was converted with compat_ptr(),
> while `arg` was passed to ld->ops->ioctl() unmodified. Fix it so `cmd`
> stays `cmd` and `arg` gets converted through compat_ptr() as intended.
>
> Notes:
> 2) compat_ptr() did nothing to `cmd`, provided it is uint,
> 1) compat_ptr() is no-op everywhere (was different on s390 before
> 8e0b986c59c6 ("s390: Remove compat support")),
> 3) `arg` might not have been chopped correctly until 8e0b986c59c6. But I
> am not sure why noone noticed all those (7) years (from f0193d3ea73b
> to 8e0b986c59c6)?
>
> Fixes: f0193d3ea73b ("change semantics of ldisc ->compat_ioctl()")
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793704520.git.jirislaby@kernel.org?part=3
prev parent reply other threads:[~2026-11-03 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:16 [PATCH 0/3] tty, serial: a couple of unrelated fixes Jiri Slaby (SUSE)
2026-11-03 11:16 ` [PATCH 1/3] serial: 8250_exar: check priv->gpio properly Jiri Slaby (SUSE)
2026-11-03 11:20 ` sashiko-bot
2026-11-03 11:16 ` [PATCH 2/3] serial: 8250_hp300: reorder HPDCA code Jiri Slaby (SUSE)
2026-11-03 11:20 ` sashiko-bot
2026-11-03 11:16 ` [PATCH 3/3] tty: fix misapplied compat_ptr() in tty_compat_ioctl() Jiri Slaby (SUSE)
2026-11-03 11:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195137@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.