From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@flipper.net>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/5] usb: typec: tcpm: Stop a source from repeating a cable Soft_Reset
Date: Tue, 03 Nov 2026 11:34:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-195156@kernel.org> (raw)
In-Reply-To: <20261103-husb311-cable-comm-v1-1-6217dabc1a85@flipper.net>
> A soft reset AMS starts with upcoming_state set to SOFT_RESET_SEND and a
> call to tcpm_ams_start(). A sink then enters SOFT_RESET_SEND through
> upcoming_state, which consumes it. A source enters SOFT_RESET_SEND right
> away and leaves upcoming_state set, for the next SRC_READY to replay.
>
> After an SOP Soft_Reset that is harmless, as the Accept handler or a
> hard reset replaces upcoming_state. The SOP' Soft_Reset sent after a
> VCONN swap returns to SRC_READY instead, so a source resets the cable
> plug a second time, outside of any AMS.
>
> Clear upcoming_state when a source enters SOFT_RESET_SEND right away.
>
> Cc: stable@vger.kernel.org
> Fixes: 6bd181ba60e1 ("usb: typec: tcpm: add control message support to sop'")
> Signed-off-by: Alexey Charkov <alchark@flipper.net>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-husb311-cable-comm-v1-0-6217dabc1a85@flipper.net?part=1
next prev parent reply other threads:[~2026-11-03 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:21 [PATCH 0/5] usb: typec: cable comms on RT1711H-compatible TCPCs and FUSB302 Alexey Charkov
2026-11-03 11:21 ` [PATCH 1/5] usb: typec: tcpm: Stop a source from repeating a cable Soft_Reset Alexey Charkov
2026-11-03 11:34 ` sashiko-bot [this message]
2026-11-03 11:21 ` [PATCH 2/5] usb: typec: tcpci: Receive SOP' only while sourcing VCONN Alexey Charkov
2026-11-03 11:39 ` sashiko-bot
2026-11-12 0:26 ` Sebastian Reichel
2026-11-03 11:21 ` [PATCH 3/5] usb: typec: tcpci_rt1711h: Enable SOP' communication Alexey Charkov
2026-11-03 11:43 ` sashiko-bot
2026-11-12 0:27 ` Sebastian Reichel
2026-11-03 11:21 ` [PATCH 4/5] usb: typec: fusb302: Tell SOP' messages apart from SOP Alexey Charkov
2026-11-03 11:47 ` sashiko-bot
2026-11-11 23:16 ` Sebastian Reichel
2026-11-03 11:21 ` [PATCH 5/5] usb: typec: fusb302: Enable SOP' communication Alexey Charkov
2026-11-03 11:51 ` sashiko-bot
2026-11-11 23:16 ` Sebastian Reichel
2026-11-11 14:00 ` [PATCH 0/5] usb: typec: cable comms on RT1711H-compatible TCPCs and FUSB302 Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195156@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alchark@flipper.net \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.