Re: [PATCH rdma v9 3/7] RDMA/zrdma: Add internal headers and hardware register definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] RDMA/zrdma: private duplication of PF driver auxiliary device structures
--

commit 41373c3ba84c37bb5af763979de45792b2597a0b
Author: Yanze Zhang <zhang.yanze@zte.com.cn>

RDMA/zrdma: Add internal headers and hardware register definitions

This commit adds internal header files defining driver device structures,
resource allocation helpers, and hardware limits for the ZTE DingHai RDMA
driver.

> diff --git a/drivers/infiniband/hw/zrdma/zrdma_main.h b/drivers/infiniband/hw/zrdma/zrdma_main.h
> new file mode 100644
> index 0000000000000..d65811735e74e
> --- /dev/null
> +++ b/drivers/infiniband/hw/zrdma/zrdma_main.h
> @@ -0,0 +1,177 @@

[ ... ]

> +struct zxdh_pci_f {

[ ... ]

> +	struct zxdh_sc_dev sc_dev;
> +	struct pci_dev *pcidev;
> +	struct zxdh_rdma_core_dev *zdev_info;
> +	struct zxdh_hw hw;
> +
> +	spinlock_t rsrc_lock; /* protects resource allocation arrays */
> +
> +	struct msix_entry *msix_entries;
> +	struct zxdh_gen_ops gen_ops;
> +	struct zxdh_device *zdev;
> +	u16 qp_index;
> +	bool net_irq_cap;
> +	int common_func_num_max;
> +	void *dh_dev;
> +};
> +
> +struct zxdh_device {
> +	struct ib_device ibdev;
> +	struct zxdh_pci_f *rf;
> +	struct net_device *netdev;
> +	struct list_head ah_list;
> +	struct mutex ah_list_lock; /* protects ah_list operations */
> +	u8 ibdev_status;
> +	u8 roce_mode : 1;
> +	enum init_completion_state init_state;
> +	struct zxdh_auxiliary_dev *zxdh_adev;

[ ... ]

> diff --git a/drivers/infiniband/hw/zrdma/zrdma_type.h b/drivers/infiniband/hw/zrdma/zrdma_type.h
> index ded4052453455..c6ad2be17c159 100644
> --- a/drivers/infiniband/hw/zrdma/zrdma_type.h
> +++ b/drivers/infiniband/hw/zrdma/zrdma_type.h
> @@ -21,6 +21,12 @@ enum zxdh_function_type {
>  	ZXDH_FUNCTION_TYPE_VF,
>  };
>  
> +/*
> + * The structures below describe the auxiliary device of the DingHai PF
> + * driver. Their layout has to match the definition of the PF driver
> + * exactly, because the probe path reads them through the auxiliary device
> + * that the PF driver provides.
> + */
>  struct zxdh_rdma_core_dev;

[Severity: Medium]
Should the cross-driver auxiliary device structures (struct
zxdh_auxiliary_dev, struct zxdh_rdma_core_dev, struct zxdh_rdma_core_ops, and
struct zxdh_rdma_if) be defined in a shared header under include/linux/
rather than privately duplicated in drivers/infiniband/hw/zrdma/zrdma_type.h
and referenced by struct zxdh_pci_f (zdev_info) and struct zxdh_device
(zxdh_adev) in drivers/infiniband/hw/zrdma/zrdma_main.h?

In a subsequent patch in the series, zxdh_probe() in
drivers/infiniband/hw/zrdma/zrdma_main.c casts the auxiliary_device pointer
via container_of(aux_dev, struct zxdh_auxiliary_dev, adev) and dereferences
zxdh_adev->rdma_ops and zxdh_adev->zxdh_info.

However, the in-tree DingHai PF driver under drivers/net/ethernet/zte/dinghai/
(en_pf.c, en_pf.h, dh_queue.h) does not define struct zxdh_auxiliary_dev or
struct zxdh_rdma_core_dev and does not register any auxiliary device. Relying
on manual struct layout matching across subsystems with untyped void *
placeholders (such as ops, parent, auxiliary_ops[18], and dh_dev) risks type
confusion and memory corruption if either driver changes.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103125654.2707069-1-zhang.yanze@zte.com.cn?part=3