Re: [PATCH v14 04/12] ext4: add ext4_dir_entry_is_tail()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ext4: unrelated error message changes in ext4_dx_csum_verify() and _set()
--

commit b38526265cad346b429002b55eb969cb4c97bc1c
Author: Artem Blagodarenko <artem.blagodarenko@gmail.com>

ext4: add ext4_dir_entry_is_tail()

This commit adds the ext4_dir_entry_is_tail() helper and replaces the
open-coded check in get_dirent_tail() with a call to it.

> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index dc8035707feb6..6e934e2732fe9 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c

[ ... ]

> @@ -478,7 +474,8 @@ static int ext4_dx_csum_verify(struct inode *inode,
>  		return 0;
>  	}
>  	if (count > limit) {
> -		EXT4_ERROR_INODE(inode, "dir seems corrupt?  Run e2fsck -D.");
> +		EXT4_ERROR_INODE(inode, "dir seems corrupt (%i > %i)? "
> +				 "Run e2fsck -D.", count, limit);
>  		return 0;
>  	}
>  	t = (struct dx_tail *)(((struct dx_entry *)c) + limit);
> @@ -511,7 +508,8 @@ static void ext4_dx_csum_set(struct inode *inode, struct ext4_dir_entry_2 *diren
>  		return;
>  	}
>  	if (count > limit) {
> -		EXT4_ERROR_INODE(inode, "dir seems corrupt?  Run e2fsck -D.");
> +		EXT4_ERROR_INODE(inode, "dir seems corrupt (%i > %i)? "
> +				 " Run e2fsck -D.", count, limit);
>  		return;
>  	}

[Severity: Low]
This isn't a bug, but were these error message updates in
ext4_dx_csum_verify() and ext4_dx_csum_set() meant to be folded into
commit 70f1e1d58c97 ("ext4: validate count against limit in
ext4_dx_csum_verify/_set") instead of included in this patch without mention
in the commit message?

Also, the continuation line in ext4_dx_csum_set() has an extra leading space
compared to ext4_dx_csum_verify(), resulting in two spaces before
"Run e2fsck -D.".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103134921.610047-1-ablagodarenko@thelustrecollective.com?part=4