All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Christian Aurich Zanettini Martins"
	<christian.aurichzm@gmail.com>, "Mike Rapoport" <rppt@kernel.org>,
	"Pasha Tatashin" <pasha.tatashin@soleen.com>,
	"Pratyush Yadav" <pratyush@kernel.org>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] liveupdate: check for duplicate session before growing block set
Date: Tue, 03 Nov 2026 15:42:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-195638@kernel.org> (raw)
In-Reply-To: <20261103153928.716753-1-christian.aurichzm@gmail.com>

> luo_session_insert() grows the outgoing block set before checking for a
> duplicate session name. On -EEXIST the new block stays in the set.
> 
> If the session count is an exact multiple of the per-block capacity (51
> with 4K pages), that block stays empty. It is serialized with count 0,
> which kho_block_set_restore() rejects in the next kernel:
> 
>   luo: Block contains invalid entry count: 0
>   Kernel panic - not syncing: The incoming tree failed to initialize properly [-EINVAL], disabling live update
> 
> Check for the duplicate before growing the block set, as
> luo_preserve_file() does with the token.
> 
> Fixes: 2a441a14c2c0 ("liveupdate: Remove limit on the number of sessions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103153928.716753-1-christian.aurichzm@gmail.com?part=1



  reply	other threads:[~2026-11-03 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 15:39 [PATCH] liveupdate: check for duplicate session before growing block set Christian Aurich Zanettini Martins
2026-11-03 15:42 ` sashiko-bot [this message]
2026-11-03 16:03 ` Pratyush Yadav
2026-11-03 18:30 ` Mike Rapoport
2026-11-03 19:32 ` Pasha Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-195638@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=christian.aurichzm@gmail.com \
    --cc=kexec@lists.infradead.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.