From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 2/3] serial: core: Allow drivers to enable TTY wakeup at registration
Date: Tue, 03 Nov 2026 15:59:57 +0000 [thread overview]
Message-ID: <sashiko-outbox-195674@kernel.org> (raw)
In-Reply-To: <b73bdbabd8d8fba2a2ff5d8576261bda6d8b0b5c.1793719239.git.stefano.r@variscite.com>
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> The serial core marks registered TTY devices as wakeup capable but leaves
> wakeup disabled. Drivers whose suspend path checks the TTY wakeup policy
> cannot enable that policy by initializing wakeup on the physical parent.
>
> Add tty_wakeup_default to struct uart_port so a driver can request that
> the core enable wakeup when registering its TTY device. The field only
> sets the initial policy; userspace can still change power/wakeup.
>
> Apply the setting only to the matching TTY device, leaving serdev wakeup
> policy unchanged. Drivers that do not set the field retain the existing
> default. Warn if enabling wakeup fails without preventing port use.
>
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793719239.git.stefano.r@variscite.com?part=2
next prev parent reply other threads:[~2026-11-03 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 15:51 [PATCH v1 0/3] serial: Support driver-selected TTY wakeup defaults Stefano Radaelli
2026-11-03 15:51 ` [PATCH v1 1/3] dt-bindings: serial: fsl-lpuart: Allow wakeup-source Stefano Radaelli
2026-11-03 15:56 ` sashiko-bot
2026-11-06 12:58 ` Krzysztof Kozlowski
2026-11-03 15:51 ` [PATCH v1 2/3] serial: core: Allow drivers to enable TTY wakeup at registration Stefano Radaelli
2026-11-03 15:59 ` sashiko-bot [this message]
2026-11-03 15:51 ` [PATCH v1 3/3] serial: fsl_lpuart: Enable TTY wakeup for wakeup-source ports Stefano Radaelli
2026-11-03 16:07 ` sashiko-bot
2026-11-03 16:16 ` Stefano Radaelli
2026-11-06 14:00 ` [PATCH v1 0/3] serial: Support driver-selected TTY wakeup defaults Johan Hovold
2026-11-06 15:16 ` Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-195674@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.