Re: [RFC PATCH 1/3] media: i2c: ov13b10: add an I2C device ID table

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] media: i2c: ov13b10: positional initializer used in ov13b10_i2c_ids
--

commit 21e45a243d633457ccb952eaf0648a9a4b43242c
Author: Seifelden Abdelmonem <saif.elden.hatim@gmail.com>

media: i2c: ov13b10: add an I2C device ID table

This commit adds an I2C device ID table to the ov13b10 driver so that it
can bind to I2C clients instantiated by name without an ACPI companion,
such as on AMD ISP4 platforms.

> diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c
> index 242a958341267..d33fb70328946 100644
> --- a/drivers/media/i2c/ov13b10.c
> +++ b/drivers/media/i2c/ov13b10.c
> @@ -1706,6 +1706,12 @@ static const struct acpi_device_id ov13b10_acpi_ids[] = {
>  MODULE_DEVICE_TABLE(acpi, ov13b10_acpi_ids);
>  #endif
>  
> +static const struct i2c_device_id ov13b10_i2c_ids[] = {
> +	{ "ov13b10" },

[Severity: Low]
This isn't a bug, but should the new entry in ov13b10_i2c_ids in
drivers/media/i2c/ov13b10.c use a named initializer ({ .name = "ov13b10" })
instead of a positional initializer to follow I2C subsystem conventions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103155313.114347-1-saif.elden.hatim@gmail.com?part=1